[Xamarin.Android.Tools.AndroidSdk] Check all <intent-filter/>s (#214)

Context: https://developercommunity.visualstudio.com/t/Cannot-deploy-to-Android-emulators-and-d/10428163
Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1863835
Context: https://developer.android.com/guide/components/intents-filters
The [`<activity/>`][0] and related elements within
`AndroidManifest.xml` can have multiple [`<intent-filter/>`][1]s
specified. Android does not require that `<intent-filter/>`s be
listed in any particular order.
However, Visual Studio *does* care about the order (?!)!
[Activity(Exported = true, Label = "@string/app_name", MainLauncher = true)]
[IntentFilter(
new[] { Android.Content.Intent.ActionView },
Categories = new[] {
Android.Content.Intent.CategoryDefault,
Android.Content.Intent.CategoryBrowsable,
}
)]
[IntentFilter(
new[] { Android.Content.Intent.ActionMain },
Categories = new[] {
Android.Content.Intent.CategoryLauncher,
Android.Content.Intent.CategoryLeanbackLauncher,
}
)]
public partial class MainActivity : Activity {}
If the `[IntentFilter]` with `Android.Content.Intent.ActionMain`
is *not* first, then Visual Studio does not consider this Activity
to be a launchable activity.
The reason for this is, in part, because
`AndroidAppManifest.GetLaunchableActivities()` only looked at the
*first* `<intent-filter/>` to see if it had the category of
`android.intent.category.LAUNCHER`.
Update `AndroidAppManifest.GetLaunchableActivities()` so that *all*
`<intent-filter/>` elements are checked for the
`.LAUNCHER` category.
**Workaround**: Specify the `[IntentFilter]` with `Intent.ActionMain`
first:
[Activity(Exported = true, Label = "@string/app_name", MainLauncher = true)]
[IntentFilter(
new[] { Android.Content.Intent.ActionMain },
Categories = new[] {
Android.Content.Intent.CategoryLauncher,
Android.Content.Intent.CategoryLeanbackLauncher,
}
)]
[IntentFilter(
new[] { Android.Content.Intent.ActionView },
Categories = new[] {
Android.Content.Intent.CategoryDefault,
Android.Content.Intent.CategoryBrowsable,
}
)]
public partial class MainActivity : Activity {}
Note: this change, in and of itself, may not be sufficient to fix
Visual Studio, as there are a few other places that have the same
"only check the first `<intent-filter/>`" bug.
[0]: https://developer.android.com/guide/topics/manifest/activity-element
[1]: https://developer.android.com/guide/topics/manifest/intent-filter-element

Author: jonpryor

src/Xamarin.Android.Tools.AndroidSdk/AndroidAppManifest.cs

@@ -323,8 +323,7 @@ void RemoveAndroidPermissions (IEnumerable<string> permissions)
 IEnumerable<XElement>GetLaunchableActivities()
 {
 foreach(varactivityinapplication.Elements("activity")){
-varfilter=activity.Element("intent-filter");
-if(filter!=null){
+foreach(varfilterinactivity.Elements("intent-filter")){
 foreach(varcategoryinfilter.Elements("category"))
 if(category!=null&&(string?)category.Attribute(aName)=="android.intent.category.LAUNCHER")
 yieldreturnactivity;

tests/Xamarin.Android.Tools.AndroidSdk-Tests/AndroidAppManifestTests.cs

@@ -45,6 +45,16 @@ static XDocument GetTestAppManifest ()
 }
 }
 
+[Test]
+publicvoidGetLaunchableActivityNames()
+{
+varversions=newAndroidVersions(Array.Empty<AndroidVersion>());
+varmanifest=AndroidAppManifest.Load(GetTestAppManifest(),versions);
+varlaunchers=manifest.GetLaunchableActivityNames().ToList();
+Assert.AreEqual(1,launchers.Count);
+Assert.AreEqual(".HasMultipleIntentFilters",launchers[0]);
+}
+
 [Test]
 publicvoidSetNewPermissions()
 {

tests/Xamarin.Android.Tools.AndroidSdk-Tests/Resources/manifest-simplewidget.xml

@@ -22,6 +22,17 @@
  <categoryandroid:name="android.intent.category.LAUNCHER" />
  </intent-filter>
  </activity>
+ <activityandroid:name=".HasMultipleIntentFilters"android:label="launcher?">
+ <intent-filter>
+ <actionandroid:name="android.intent.action.VIEW" />
+ <categoryandroid:name="android.intent.category.DEFAULT" />
+ <categoryandroid:name="android.intent.category.BROWSABLE" />
+ </intent-filter>
+ <intent-filter>
+ <actionandroid:name="android.intent.action.MAIN" />
+ <categoryandroid:name="android.intent.category.LAUNCHER" />
+ </intent-filter>
+ </activity>
  </application>
  <uses-permissionandroid:name="android.permission.INTERNET" />
  <uses-permissionandroid:name="android.permission.READ_CONTACTS" />