Uh oh!
There was an error while loading. Please reload this page.
Add feature flag for obj-inference diagnostic - #15315
Merged
Merged
Conversation
edgarfgp
approved these changes
Jun 5, 2023
T-Gro
approved these changes
Jun 6, 2023
vzarytovskii
commented
Jun 6, 2023
Member
I guess I'm a bit confused. Why does it need to be a separate PR, and not part of the feature? |
Smaug123
commented
Jun 6, 2023
ContributorAuthor
I can combine them if you like, but I'm still not confident that the feature itself is ready to go in, and I want to reduce churn on the FsComp file. |
psfinaki
approved these changes
Jun 6, 2023
vzarytovskii
commented
Jun 6, 2023
Member
Oh, I get it now, just to "reserve" it. It's fine that it goes first, yeah. |
Smaug123
commented
Jun 6, 2023
| LanguageFeature.ExtendedStringInterpolation, previewVersion | ||
| LanguageFeature.WarningWhenMultipleRecdTypeChoice, previewVersion | ||
| LanguageFeature.ImprovedImpliedArgumentNames, previewVersion | ||
| LanguageFeature.DiagnosticForObjInference, previewVersion |
ContributorAuthor
There was a problem hiding this comment.
For posterity, this precise line should probably not have gone in during this pull request, since the feature was not actually implemented yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No actual feature is implemented; just reserving the feature flag. The feature itself is #13298 .