Revert "[build] Enable NuGet's Central Package Management (#1114)" (#1138)

Context: dotnet/android#8279
This reverts commit 8c9eece.
Near the end of .NET 8 RC 1, the .NET 8 SDK depends on nightly
packages for .NET 6 and .NET 7:
* dotnet/runtime 7.0.11
* dotnet/runtime 6.0.22
These come from feeds within `NuGet.config` such as:
<packageSources>
<clear/>
<!-- Added manually for dotnet/runtime 7.0.11 -->
<add key="darc-pub-dotnet-runtime-a2ad4f0" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-a2ad4f03/nuget/v3/index.json" />
<!-- Added manually for dotnet/runtime 6.0.22 -->
<add key="darc-pub-dotnet-runtime-762f437" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-762f4379/nuget/v3/index.json" />
</packageSources>
The version number is stable, so the .NET releng team has
infrastructure to create a new feed per git commit.
Unfortunately, this makes NuGet central package management unusable
for us. 😢
As seen in dotnet/android#8279, we get errors like:
Package source mapping matches found for package ID 'Microsoft.NETCore.App.Ref' are: 'dotnet-public'.
…
external\Java.Interop\src\Java.Interop.Tools.Expressions\Java.Interop.Tools.Expressions.csproj error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 7.0.11)
- Found 83 version(s) in dotnet-public [ Nearest version: 8.0.0-preview.1.23110.8 ]
- Versions from dotnet-eng were not considered [Xamarin.Android.sln]
This is because it can only possibly resolve this package from
`dotnet-public`:
<packageSourceMapping>
<packageSource key="dotnet-public">
<package pattern="*" />
</packageSource>
</packageSourceMapping>
Because 7.0.11 hasn't shipped yet, it is on neither NuGet.org nor
`dotnet-public`.
For this to work, we would somehow need this `NuGet.config` fragment
to be added to the xamarin/java.interop repo whenever
xamarin/xamarin-android gets a newer .NET 8 SDK:
<packageSourceMapping>
<packageSource key="darc-pub-dotnet-runtime-[HASH]">
<package pattern="Microsoft.NETCore.App.Ref" />
</packageSource>
</packageSourceMapping>
For now, let's revert 8c9eece. Maybe there is some solution we can
come up with to use this in the future.

Author: jonathanpeppers

Directory.Build.props

@@ -11,7 +11,6 @@
  <DisableTransitiveFrameworkReferenceDownloads>true</DisableTransitiveFrameworkReferenceDownloads>
  <DotNetTargetFrameworkVersion>7.0</DotNetTargetFrameworkVersion>
  <DotNetTargetFramework>net$(DotNetTargetFrameworkVersion)</DotNetTargetFramework>
- <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
  </PropertyGroup>
 
  <Import

Directory.Build.targets

@@ -3,18 +3,36 @@
 
 <!-- Add Roslyn analyzers NuGet to all projects -->
  <ItemGroupCondition=" '$(DisableRoslynAnalyzers)' != 'True' ">
- <PackageReferenceInclude="Microsoft.CodeAnalysis.FxCopAnalyzers">
+ <PackageReferenceInclude="Microsoft.CodeAnalysis.FxCopAnalyzers"Version="3.3.0">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>
  </ItemGroup>
 
-<!--Set Assets for NUnit3TestAdapter-->
+<!--NuGet Dependencies-->
  <ItemGroup>
- <PackageReferenceUpdate="NUnit3TestAdapter">
+ <PackageReferenceUpdate="GitInfo"Version="2.1.2" />
+ <PackageReferenceUpdate="HtmlAgilityPack"Version="1.11.30" />
+ <PackageReferenceUpdate="Irony"Version="1.1.0" />
+ <PackageReferenceUpdate="Microsoft.Build.Framework"Version="17.3.2" />
+ <PackageReferenceUpdate="Microsoft.Build.Utilities.Core"Version="17.3.2" />
+ <PackageReferenceUpdate="Microsoft.CodeAnalysis.CSharp"Version="4.3.1" />
+ <PackageReferenceUpdate="Microsoft.CSharp"Version="4.7.0" />
+ <PackageReferenceUpdate="Microsoft.DotNet.GenAPI"Version="7.0.0-beta.22103.1" />
+ <PackageReferenceUpdate="Microsoft.NET.Test.Sdk"Version="17.5.0-preview-20221003-04" />
+ <PackageReferenceUpdate="Microsoft.SourceLink.GitHub"Version="1.1.1" />
+ <PackageReferenceUpdate="Microsoft.Xml.SgmlReader"Version="1.8.16" />
+ <PackageReferenceUpdate="Mono.CSharp"Version="4.0.0.143" />
+ <PackageReferenceUpdate="Mono.Linq.Expressions"Version="2.0.0" />
+ <PackageReferenceUpdate="Mono.Options"Version="6.12.0.148" />
+ <PackageReferenceUpdate="Mono.Terminal"Version="5.4.2" />
+ <PackageReferenceUpdate="nunit"Version="3.13.2" />
+ <PackageReferenceUpdate="NUnit.ConsoleRunner"Version="3.12.0" />
+ <PackageReferenceUpdate="NUnit3TestAdapter"Version="4.0.0">
  <PrivateAssets>all</PrivateAssets>
  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  </PackageReference>
+ <PackageReferenceUpdate="protobuf-net"Version="2.4.4" />
  </ItemGroup>
 
  <ImportProject="build-tools\scripts\VersionInfo.targets" />

Directory.Packages.props

@@ -11,14 +11,4 @@
 <!-- For Microsoft.DotNet.GenAPI -->
  <addkey="dotnet-eng"value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json"protocolVersion="3" />
  </packageSources>
-
- <packageSourceMapping>
-<!-- key value for <packageSource> should match key values from <packageSources> element -->
- <packageSourcekey="dotnet-public">
- <packagepattern="*" />
- </packageSource>
- <packageSourcekey="dotnet-eng">
- <packagepattern="Microsoft.DotNet.GenAPI" />
- </packageSource>
- </packageSourceMapping>
 </configuration>

NuGet.Config

@@ -1,7 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Projectxmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+ <PropertyGroup>
+ <_XamarinAndroidCecilVersionCondition=" '$(_XamarinAndroidCecilVersion)' == '' ">0.11.4</_XamarinAndroidCecilVersion>
+ </PropertyGroup>
  <ItemGroupCondition=" '$(_XamarinAndroidCecilPath)' == '' ">
- <PackageReferenceInclude="Mono.Cecil" />
+ <PackageReferenceInclude="Mono.Cecil"Version="$(_XamarinAndroidCecilVersion)"/>
  </ItemGroup>
  <ItemGroupCondition=" '$(_XamarinAndroidCecilPath)' != '' ">
  <ReferenceInclude="$(_XamarinAndroidCecilPath)" />

build-tools/scripts/cecil.projitems

@@ -20,11 +20,9 @@
  <PackageReferenceInclude="NUnit3TestAdapter" />
  </ItemGroup>
 
-<!--
  <ImportProject="..\..\build-tools\scripts\cecil.projitems" />
--->
+
  <ItemGroup>
- <PackageReferenceInclude="Mono.Cecil" />
  <PackageReferenceInclude="Mono.Linq.Expressions" />
  </ItemGroup>