[generator] Output correct formatting for binding warnings (#737)

In d664e90 we refactored some output around binding warning messages
in order to better support localization. Unfortunately this
refactoring left out a period between some type and member names:
warning BG8700: Unknown return type 'Android.App.Admin.AppOpsManagerMode' for member
'Android.App.AppOpsManagerUnsafeCheckOp (java.lang.String, int, java.lang.String)'. `Android.App.AppOpsManagerUnsafeCheckOp` should instead be
`Android.App.AppOpsManager.UnsafeCheckOp`.
Fix `CodeGeneratorContext.GetContextTypeMember()` so that `.`s are
inserted everywhere required.

Author: jpobst

tests/generator-Tests/Unit-Tests/CodeGeneratorContextTests.cs

@@ -0,0 +1,40 @@
+usingSystem;
+usingSystem.Linq;
+usingMonoDroid.Generation;
+usingNUnit.Framework;
+
+namespacegeneratortests
+{
+[TestFixture]
+publicclassCodeGeneratorContextTests
+{
+[Test]
+publicvoidGetContextTypeMember()
+{
+varklass=newTestClass("Object","java.code.MyClass");
+
+klass.AddMethod(SupportTypeBuilder.CreateMethod(klass,"Echo",newCodeGenerationOptions(),"uint",false,false,newParameter("value","uint","uint",false)));
+klass.AddField(newTestField("string","Foo"));
+
+varcontext=newCodeGeneratorContext();
+context.ContextTypes.Push(klass);
+
+Assert.AreEqual("java.code.MyClass",context.GetContextTypeMember());
+
+context.ContextMethod=klass.Methods.Single();
+
+Assert.AreEqual("java.code.MyClass.Echo (uint)",context.GetContextTypeMember());
+
+context.ContextMethod=null;
+context.ContextField=klass.Fields.Single();
+
+Assert.AreEqual("java.code.MyClass.Foo",context.GetContextTypeMember());
+
+context.ContextMethod=klass.Methods.Single();
+context.ContextField=null;
+context.ContextTypes.Clear();
+
+Assert.AreEqual("Echo (uint)",context.GetContextTypeMember());
+}
+}
+}

tools/generator/CodeGeneratorContext.cs

@@ -19,14 +19,19 @@ public class CodeGeneratorContext
 
 publicstringGetContextTypeMember()
 {
-varoutput=ContextType?.FullName??string.Empty;
+varparts=newList<string>();
 
-if(ContextMethod!=null){
-output+=$"{ContextMethod.Name} ({string.Join(", ",ContextMethod?.Parameters.Select(p =>p.InternalType).ToArray())})";
-returnoutput;
-}
+// Type name
+if(!string.IsNullOrEmpty(ContextType?.FullName))
+parts.Add(ContextType?.FullName);
 
-returnoutput+ContextField?.Name;
+// Member name
+if(ContextMethod!=null)
+parts.Add($"{ContextMethod.Name} ({string.Join(", ",ContextMethod?.Parameters.Select(p =>p.InternalType).ToArray())})");
+elseif(ContextField!=null)
+parts.Add(ContextField.Name);
+
+returnstring.Join(".",parts);
 }
 }
 }