Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-api

Jun 9, 2026

src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs

-Original file line number
+Diff line change
@@ Expand Up / @@ -23,6 +23,14 @@ public void Kill() { } @@
  [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
  [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")]
  [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")]
+ public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; }
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")]
+ [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")]
+ public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; }
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")]
+ [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")]
  public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; }
  public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; }
  public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; }
@@ Expand DownExpand Up / @@ -242,6 +250,10 @@ public void Refresh() { } @@
  [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer
  public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; }
  public override string ToString() { throw null; }
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")]
+ [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")]
+ [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")]
+ public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; }
  public void WaitForExit() { }
  public bool WaitForExit(int milliseconds) { throw null; }
  public bool WaitForExit(System.TimeSpan timeout) { throw null; }
@@ Expand Down @@

...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs

-Original file line number
+Diff line change
@@ Expand Up / @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() @@
  Debug.Assert(_handle != null);
  _handle.DangerousRelease();
  }
  _waitStateHolder?.Dispose();
  return true;
  }
+ private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError)
+ {
+ int result = Interop.Sys.Kill(processId, 0);
+ if (result != 0)
+ {
+ Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo();
+ if (errorInfo.Error == Interop.Error.EPERM)
+ {
+ ThrowOpenProcessAccessDeniedException(processId);
+ }
+ if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL)
+ {
+ lastError = errorInfo.RawErrno;
+ processHandle = null;
+ return false;
+ }
+ throw new Win32Exception(errorInfo.RawErrno);
+ }
+ lastError = 0;
+ ProcessWaitState.Holder waitStateHolder = new(processId);
+ processHandle = new SafeProcessHandle(waitStateHolder);
+ return true;
+ }
  private bool SignalCore(PosixSignal signal)
  {
  if (!ProcessUtils.PlatformSupportsProcessStartAndKill)
@@ Expand Down @@

...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs

-Original file line number
+Diff line change
@@ Expand Up / @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() @@
  return Interop.Kernel32.CloseHandle(handle);
  }
+ private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError)
+ {
+ const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION
+ | Interop.Advapi32.ProcessOptions.SYNCHRONIZE
+ | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE;
+ SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId);
+ if (safeHandle.IsInvalid)
+ {
+ int error = Marshal.GetLastPInvokeError();
+ safeHandle.Dispose();
+ if (error == Interop.Errors.ERROR_ACCESS_DENIED)
+ {
+ ThrowOpenProcessAccessDeniedException(processId);
+ }
+ if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER)
+ {
+ lastError = error;
+ processHandle = null;
+ return false;
+ }
+ throw new Win32Exception(error);
+ }
+ lastError = 0;
+ safeHandle.ProcessId = processId;
+ processHandle = safeHandle;
+ return true;
+ }
  private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob()
  {
  Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default;
@@ Expand Down @@

...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs

-Original file line number
+Diff line change
@@ Expand Up @@
  SetHandle(existingHandle);
  }
+ /// <summary>
+ /// Opens an existing process by its process ID.
+ /// </summary>
+ /// <param name="processId">The process ID of the process to open.</param>
+ /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns>
+ /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception>
+ /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception>
+ /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception>
+ /// <remarks>
+ /// <para>
+ /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether
+ /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed.
+ /// </para>
+ /// <para>
+ /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests
+ /// broader rights for interop scenarios.
+ /// </para>
+ /// <para>
+ /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process.
+ /// </para>
+ /// <para>
+ /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown.
+ /// </para>
+ /// </remarks>
+ [UnsupportedOSPlatform("ios")]
+ [UnsupportedOSPlatform("tvos")]
+ [SupportedOSPlatform("maccatalyst")]
+ public static SafeProcessHandle Open(int processId)
+ {
+ ValidateOpenArguments(processId);
+ if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError))
+ {
+ throw new Win32Exception(lastError);
+ }
+ return handle;
+ }
+ /// <summary>
+ /// Attempts to open an existing process by its process ID.
+ /// </summary>
+ /// <param name="processId">The process ID of the process to open.</param>
+ /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param>
+ /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns>
+ /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception>
+ /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception>
+ /// <remarks>
+ /// <para>
+ /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>.
+ /// </para>
+ /// <para>
+ /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks
+ /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed.
+ /// </para>
+ /// <para>
+ /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests
+ /// broader rights for interop scenarios.
+ /// </para>
+ /// <para>
+ /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process.
+ /// </para>
+ /// </remarks>
+ [UnsupportedOSPlatform("ios")]
+ [UnsupportedOSPlatform("tvos")]
+ [SupportedOSPlatform("maccatalyst")]
+ public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle)
+ {
+ ValidateOpenArguments(processId);
+ return TryOpenCore(processId, out processHandle, out _);
+ }
+ private static void ValidateOpenArguments(int processId)
+ {
+ ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0);
+ if (!ProcessUtils.PlatformSupportsProcessStartAndKill)
+ {
+ throw new PlatformNotSupportedException();
+ }
+ }
+ private static void ThrowOpenProcessAccessDeniedException(int processId) =>
+ throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId));
  /// <summary>
  /// Starts a process using the specified <see cref="ProcessStartInfo"/>.
  /// </summary>
@@ Expand Down @@

src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx

-Original file line number
+Diff line change
@@ Expand Up / @@ -138,6 +138,9 @@ @@
  <data name="MissingProcess" xml:space="preserve">
  <value>Process with an Id of {0} is not running.</value>
  </data>
+ <data name="OpenProcessAccessDenied" xml:space="preserve">
+ <value>Access denied when opening process with an Id of {0}.</value>
+ </data>
  <data name="BadMinWorkset" xml:space="preserve">
  <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value>
  </data>
@@ Expand Down @@

src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs

-Original file line number
+Diff line change
@@ Expand Up / @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) @@
  return new Process(".", false, processId, null);
  }
+ /// <summary>
+ /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID.
+ /// </summary>
+ /// <param name="processId">The process ID of the process to open.</param>
+ /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param>
+ /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns>
+ /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception>
+ [UnsupportedOSPlatform("ios")]
+ [UnsupportedOSPlatform("tvos")]
+ [SupportedOSPlatform("maccatalyst")]
+ public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process)
+ {
+ ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0);
+ if (ProcessManager.IsProcessRunning(processId))
+ {
+ process = new Process(".", false, processId, null);
+ return true;
+ }
+ process = null;
+ return false;
+ }
  /// <devdoc>
  /// <para>
  /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are
@@ Expand Down @@

blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. dotnet /runtimePublic Notifications You must be signed in to change notification settings Fork 5.6k Star 18.2k Code Issues5k+ Pull requests563 Discussions Actions Projects Security and quality67 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById#126705 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Merged adamsitnik merged 29 commits into main from copilot/add-safeproceshandle-open-apiJun 9, 2026 Conversation 184 Commits 29 Checks 102 Files changed Uh oh! There was an error while loading. Please reload this page. Merged Implement SafeProcessHandle.Open/TryOpen and Process.TryGetProcessById #126705 Show file tree Hide file tree Changes from all commits Commits Show all changes 29 commits Select commit Hold shift + click to select a range bad944e Implement SafeProcessHandle.Open API with pidfd support on Linux Copilot Apr 9, 20262ed39ab Add SystemNative_OpenProcess to entrypoints.c Copilot Apr 9, 2026e2bc39d Refactor pidfd_open into TryOpenPidfd helper, extend ForkAndExecProce… Copilot Apr 9, 2026a114b09 Address review: use out instead of int* for pidfd params, set -1 on m… Copilot Apr 9, 2026b63ecec Address review: add outPidfd to assert, remove redundant null checks,… Copilot Apr 10, 202690cff12 Merge remote-tracking branch 'origin/main' into copilot/add-safeproce… Copilot May 22, 2026a3bf1ae Fix ProcessId property for pidfd-backed handles after merge Copilot May 22, 20269fd4c33 Address review: always use waitStateHolder in OpenCore, fix tests Copilot May 22, 202686ce237 Replace var with explicit type for waitStateHolder Copilot May 22, 2026e0c5ebf Use ConditionalFact for Open_NonExistentProcessId test to skip on iOS… Copilot May 25, 20260199f40 Simplify _pidfd assignment in OpenCore to set unconditionally Copilot May 25, 2026aff5970 Fix pidfd leak in OpenCore and ForkAndExecProcess on exception Copilot May 25, 2026534460d Move ProcessWaitState.Holder creation inside try block in OpenCore Copilot May 25, 20263fd0d5c Use __NR_pidfd_open directly, document exited-process behavior, add test Copilot May 26, 2026cc672e4 Remove pidfd support from SafeProcessHandle.Open Copilot May 28, 2026007b2cb Apply reviewer suggestions: simplify docs, remove pidfd remnants, cle… Copilot May 28, 2026d039b6e Add Process.TryGetProcessById and SafeProcessHandle.TryOpen APIs (#12… Copilot May 29, 2026f1ec54d Address latest SafeProcessHandle.Open review feedback Copilot May 29, 20262063cc4 Remove flaky PID-reuse reaped-process test Copilot May 29, 2026bb5959a Fix TryOpen error handling and explicit last-error flow Copilot May 29, 20265c5598e Merge branch 'main' into copilot/add-safeproceshandle-open-api adamsitnik May 29, 2026a543c72 Fix Unix TryOpenCore to use GetLastErrorInfo() and RawErrno for corre… Copilot May 29, 20263dbf342 Move throw into ThrowOpenProcessAccessDeniedException helper Copilot May 29, 202681abf1c Add Process.TryOpen platform impls, update TryGetProcessById, extend … Copilot Jun 2, 2026f799bc4 address my own feedback: make sure Process.TryGetProcessById mimics e… adamsitnik Jun 2, 20267387524 Apply suggestions from code review adamsitnik Jun 2, 20260e5bfb4 Add null assertion for opened process handle test Copilot Jun 3, 2026000a148 Use kill directly for Unix process open checks Copilot Jun 3, 2026e105eec Clarify SafeProcessHandle.Open/TryOpen docs vs Process.GetProcessById Copilot Jun 9, 2026 File filter Filter by extension Filter by extension .cs (7) .csproj (1) .resx (1) All 3 file types selected Only manifest files Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs System.Diagnostics.Process.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs SafeProcessHandle.Unix.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs SafeProcessHandle.Windows.cs src/libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs SafeProcessHandle.cs src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Strings.resx src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Process.cs src/libraries/System.Diagnostics.Process/tests/ProcessOpenTests.cs ProcessOpenTests.cs src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs ProcessTests.cs src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj System.Diagnostics.Process.Tests.csproj Some comments aren't visible on the classic Files Changed page. There are no files selected for viewing 12 changes: 12 additions & 0 deletions 12 src/libraries/System.Diagnostics.Process/ref/System.Diagnostics.Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -23,6 +23,14 @@ public void Kill() { } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Open(int processId) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryOpen(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out Microsoft.Win32.SafeHandles.SafeProcessHandle? processHandle) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static Microsoft.Win32.SafeHandles.SafeProcessHandle Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; } public bool TryWaitForExit(System.TimeSpan timeout, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.ProcessExitStatus? exitStatus) { throw null; } public System.Diagnostics.ProcessExitStatus WaitForExit() { throw null; } Expand DownExpand Up @@ -242,6 +250,10 @@ public void Refresh() { } [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] // this needs to come after the ios attribute due to limitations in the platform analyzer public static int StartAndForget(string fileName, System.Collections.Generic.IList<string>? arguments = null) { throw null; } public override string ToString() { throw null; } [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("ios")] [System.Runtime.Versioning.UnsupportedOSPlatformAttribute("tvos")] [System.Runtime.Versioning.SupportedOSPlatformAttribute("maccatalyst")] public static bool TryGetProcessById(int processId, [System.Diagnostics.CodeAnalysis.NotNullWhenAttribute(true)] out System.Diagnostics.Process? process) { throw null; } Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. public void WaitForExit() { } public bool WaitForExit(int milliseconds) { throw null; } public bool WaitForExit(System.TimeSpan timeout) { throw null; } Expand Down 31 changes: 31 additions & 0 deletions 31 ...ries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Unix.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -71,10 +71,41 @@ protected override bool ReleaseHandle() Debug.Assert(_handle != null); _handle.DangerousRelease(); } _waitStateHolder?.Dispose(); return true; } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { int result = Interop.Sys.Kill(processId, 0); if (result != 0) { Interop.ErrorInfo errorInfo = Interop.Sys.GetLastErrorInfo(); if (errorInfo.Error == Interop.Error.EPERM) { ThrowOpenProcessAccessDeniedException(processId); } if (errorInfo.Error == Interop.Error.ESRCH || errorInfo.Error == Interop.Error.EINVAL) { lastError = errorInfo.RawErrno; processHandle = null; return false; } throw new Win32Exception(errorInfo.RawErrno); } lastError = 0; ProcessWaitState.Holder waitStateHolder = new(processId); processHandle = new SafeProcessHandle(waitStateHolder); Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return true; } private bool SignalCore(PosixSignal signal) { if (!ProcessUtils.PlatformSupportsProcessStartAndKill) Expand Down 34 changes: 34 additions & 0 deletions 34 ...s/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.Windows.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -51,6 +51,40 @@ protected override bool ReleaseHandle() return Interop.Kernel32.CloseHandle(handle); } private static bool TryOpenCore(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle, out int lastError) { const int desiredAccess = Interop.Advapi32.ProcessOptions.PROCESS_QUERY_LIMITED_INFORMATION | Interop.Advapi32.ProcessOptions.SYNCHRONIZE | Interop.Advapi32.ProcessOptions.PROCESS_TERMINATE; SafeProcessHandle safeHandle = Interop.Kernel32.OpenProcess(desiredAccess, inherit: false, processId); if (safeHandle.IsInvalid) { int error = Marshal.GetLastPInvokeError(); safeHandle.Dispose(); if (error == Interop.Errors.ERROR_ACCESS_DENIED) { ThrowOpenProcessAccessDeniedException(processId); } if (error == Interop.Errors.ERROR_NOT_FOUND || error == Interop.Errors.ERROR_INVALID_PARAMETER) { lastError = error; processHandle = null; return false; } throw new Win32Exception(error); } lastError = 0; safeHandle.ProcessId = processId; processHandle = safeHandle; return true; } private static unsafe Interop.Kernel32.SafeJobHandle CreateKillOnParentExitJob() { Interop.Kernel32.JOBOBJECT_EXTENDED_LIMIT_INFORMATION limitInfo = default; Expand Down 85 changes: 85 additions & 0 deletions 85 ...libraries/System.Diagnostics.Process/src/Microsoft/Win32/SafeHandles/SafeProcessHandle.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -56,6 +56,91 @@ public SafeProcessHandle(IntPtr existingHandle, bool ownsHandle) SetHandle(existingHandle); } /// <summary> /// Opens an existing process by its process ID. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <returns>A <see cref="SafeProcessHandle"/> that represents the opened process.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="Win32Exception">Thrown when the process could not be opened.</exception> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// This API opens the handle immediately. In contrast, <see cref="Process.GetProcessById(int)"/> only checks whether /// the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// <para> /// On Unix, if the process has already exited and been reaped, a <see cref="Win32Exception"/> is thrown. /// </para> Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static SafeProcessHandle Open(int processId) { ValidateOpenArguments(processId); if (!TryOpenCore(processId, out SafeProcessHandle? handle, out int lastError)) { throw new Win32Exception(lastError); } return handle; } /// <summary> /// Attempts to open an existing process by its process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="processHandle">When this method returns <see langword="true"/>, contains the <see cref="SafeProcessHandle"/> for the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was successfully opened; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> /// <exception cref="UnauthorizedAccessException">Thrown when the process exists but the caller does not have permissions to open it.</exception> /// <remarks> /// <para> /// This method does not throw when the process does not exist. Instead, it returns <see langword="false"/>. /// </para> /// <para> /// This API opens the handle immediately. In contrast, <see cref="Process.TryGetProcessById(int, out Process)"/> only checks /// whether the process is currently running; opening the process handle is deferred until <see cref="Process.SafeHandle"/> is accessed. /// </para> /// <para> /// On Windows, this API requests query/synchronize/terminate rights, while <see cref="Process.SafeHandle"/> requests /// broader rights for interop scenarios. /// </para> /// <para> /// On Windows, if the process has already exited, the method may still succeed and return a valid handle representing the terminated process. /// </para> /// </remarks> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryOpen(int processId, [NotNullWhen(true)] out SafeProcessHandle? processHandle) { ValidateOpenArguments(processId); return TryOpenCore(processId, out processHandle, out _); } private static void ValidateOpenArguments(int processId) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (!ProcessUtils.PlatformSupportsProcessStartAndKill) { throw new PlatformNotSupportedException(); } } private static void ThrowOpenProcessAccessDeniedException(int processId) => throw new UnauthorizedAccessException(SR.Format(SR.OpenProcessAccessDenied, processId)); /// <summary> /// Starts a process using the specified <see cref="ProcessStartInfo"/>. /// </summary> Expand Down 3 changes: 3 additions & 0 deletions 3 src/libraries/System.Diagnostics.Process/src/Resources/Strings.resx Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -138,6 +138,9 @@ <data name="MissingProcess" xml:space="preserve"> <value>Process with an Id of {0} is not running.</value> </data> <data name="OpenProcessAccessDenied" xml:space="preserve"> <value>Access denied when opening process with an Id of {0}.</value> </data> <data name="BadMinWorkset" xml:space="preserve"> <value>Minimum working set size is invalid. It must be less than or equal to the maximum working set size.</value> </data> Expand Down 25 changes: 25 additions & 0 deletions 25 src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -936,6 +936,31 @@ public static Process GetProcessById(int processId) return new Process(".", false, processId, null); } /// <summary> /// Attempts to get a <see cref="Process"/> instance for an existing process with the specified process ID. /// </summary> /// <param name="processId">The process ID of the process to open.</param> /// <param name="process">When this method returns <see langword="true"/>, contains a <see cref="Process"/> representing the opened process; otherwise, <see langword="null"/>.</param> /// <returns><see langword="true"/> if the process was found and opened successfully; otherwise, <see langword="false"/>.</returns> /// <exception cref="ArgumentOutOfRangeException">Thrown when <paramref name="processId"/> is negative or zero.</exception> [UnsupportedOSPlatform("ios")] [UnsupportedOSPlatform("tvos")] [SupportedOSPlatform("maccatalyst")] public static bool TryGetProcessById(int processId, [NotNullWhen(true)] out Process? process) { ArgumentOutOfRangeException.ThrowIfLessThanOrEqual(processId, 0); if (ProcessManager.IsProcessRunning(processId)) { process = new Process(".", false, processId, null); return true; } process = null; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. return false; Comment threadadamsitnik marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. } /// <devdoc> /// <para> /// Creates an array of <see cref='System.Diagnostics.Process'/> components that are Expand Down Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Loading Oops, something went wrong. Uh oh! There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.