From 12c16edf11de47d4c879b1f106da4131d2282dc0 Mon Sep 17 00:00:00 2001
From: Eric StJohn <ericstj@microsoft.com>
Date: Wed, 26 Jul 2023 12:54:39 -0700
Subject: [PATCH] Remove unused suppressions for System.Linq.Expressions

---
 .../src/CompatibilitySuppressions.xml         | 307 +-----------------
 1 file changed, 1 insertion(+), 306 deletions(-)

diff --git a/src/libraries/System.Linq.Expressions/src/CompatibilitySuppressions.xml b/src/libraries/System.Linq.Expressions/src/CompatibilitySuppressions.xml
index 8186f7b52a9a9f..8185aa8209fa11 100644
--- a/src/libraries/System.Linq.Expressions/src/CompatibilitySuppressions.xml
+++ b/src/libraries/System.Linq.Expressions/src/CompatibilitySuppressions.xml
@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
 <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
   <Suppression>
     <DiagnosticId>CP0001</DiagnosticId>
@@ -24,78 +25,6 @@
     <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
     <Right>lib/net8.0/System.Linq.Expressions.dll</Right>
   </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Linq.Expressions.Interpreter.LightLambda</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.CallSiteOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.Closure</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.RuntimeOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Linq.Expressions.Interpreter.LightLambda</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.CallSiteOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.Closure</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.RuntimeOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Linq.Expressions.Interpreter.LightLambda</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.CallSiteOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.Closure</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0001</DiagnosticId>
-    <Target>T:System.Runtime.CompilerServices.RuntimeOps</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
   <Suppression>
     <DiagnosticId>CP0002</DiagnosticId>
     <Target>M:System.Linq.Expressions.ElementInit.get_ArgumentCount</Target>
@@ -168,244 +97,10 @@
     <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
     <Right>lib/net8.0/System.Linq.Expressions.dll</Right>
   </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanCompileToIL</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanInterpret</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanCompileToIL</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanInterpret</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.ElementInit.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.IndexExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.InvocationExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanCompileToIL</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.LambdaExpression.get_CanInterpret</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.MethodCallExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.get_ArgumentCount</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0002</DiagnosticId>
-    <Target>M:System.Linq.Expressions.NewExpression.GetArgument(System.Int32)</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
   <Suppression>
     <DiagnosticId>CP0020</DiagnosticId>
     <Target>M:System.Linq.Expressions.DynamicExpressionVisitor.#ctor</Target>
     <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
     <Right>lib/net8.0/System.Linq.Expressions.dll</Right>
   </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0020</DiagnosticId>
-    <Target>M:System.Linq.Expressions.DynamicExpressionVisitor.#ctor</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/ios/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0020</DiagnosticId>
-    <Target>M:System.Linq.Expressions.DynamicExpressionVisitor.#ctor</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/maccatalyst/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
-  <Suppression>
-    <DiagnosticId>CP0020</DiagnosticId>
-    <Target>M:System.Linq.Expressions.DynamicExpressionVisitor.#ctor</Target>
-    <Left>ref/net8.0/System.Linq.Expressions.dll</Left>
-    <Right>runtimes/tvos/lib/net8.0/System.Linq.Expressions.dll</Right>
-  </Suppression>
 </Suppressions>
\ No newline at end of file