Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx

[MichelZ]

Part of #2953

Aligning Task return, bringing over ArrayPool usage and aligning IsColumnEncryptionSupported changes between netcore and netfx

[codecov]

Codecov Report

Attention: Patch coverage is 75.67568% with 18 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base (4bc9ee6) to head (43a4fd6).
Report is 38 commits behind head on main.

Files with missing lines	Patch %	Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	78.26%	15 Missing ⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	40.00%	3 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #2982 +/- ##
==========================================
- Coverage 72.50% 72.46% -0.04% 
==========================================
Files 288 288 Lines 59529 59507 -22 ==========================================
- Hits 43159 43122 -37 - Misses 16370 16385 +15 

Flag	Coverage Δ
addons	92.58% <ø> (ø)
netcore	75.39% <40.00%> (-0.05%)	⬇️
netfx	70.90% <78.26%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benrr101]

In general, I think this is a decent change. I'm hesitant to start touching things in the TdsParser, but these changes seem to be pretty constrained. Only a few comments. Not sure about the feasibility of using stackalloc instead of array pool in the last commit.