Tests | Activate SplitPacket Tests

[MichelZ]

AI Blurp

This pull request includes several improvements and refactorings to the SplitPacketTest class and the DataTestUtility class in the Microsoft.Data.SqlClient test suite. The most important changes include adding new utility methods, refactoring existing methods, and enhancing the test class with proper resource disposal.

Improvements and refactorings:

• src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs: Added new methods IsNotNamedInstance and IsLocalHost to the DataTestUtility class for better connection string handling and test conditions.

Enhancements to test class:

• src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SplitPacketTest/SplitPacketTest.cs: Refactored the SplitPacketTest class to use private fields with underscores, added CancellationToken support to the SetupProxy method, and implemented the IDisposable interface for proper resource cleanup. [1][2][3][4][5]

These changes enhance the code readability, maintainability, and ensure that resources are properly managed during the tests.

Human stuff

This removes the ActiveIssue 5538 from the SplitPacketTest
It makes sure that the test is only run on localhost and without named instances due to the fact that the tests are proxying the requests.

Also added IDisposable cleanup so that the started threads don't hang around.

[MichelZ]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 3061 in repo dotnet/SqlClient

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.12%. Comparing base (bb4c3b7) to head (54ee201).
Report is 98 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bb4c3b7) and HEAD (54ee201). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (bb4c3b7)	HEAD (54ee201)
addons	1	0

Additional details and impacted files

@@ Coverage Diff @@## main #3061 +/- ##
==========================================
- Coverage 72.68% 66.12% -6.57% 
==========================================
Files 283 292 +9 Lines 58975 56691 -2284 ==========================================
- Hits 42864 37485 -5379 - Misses 16111 19206 +3095 

Flag	Coverage Δ
addons	?
netcore	69.01% <ø> (-6.47%)	⬇️
netfx	65.12% <ø> (-6.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.