Skip to content

[TEST] Improve SqlDataRecord DateOnly and TimeOnly coverage - #3128

Merged
benrr101 merged 4 commits into
dotnet:mainfrom
ErikEJ:issue-3125
Feb 25, 2025
Merged

[TEST] Improve SqlDataRecord DateOnly and TimeOnly coverage#3128
benrr101 merged 4 commits into
dotnet:mainfrom
ErikEJ:issue-3125

Conversation

@ErikEJ

@ErikEJErikEJ commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Make SqlDecimalConvertToDecimal_TestInRange run on non-US systems

fixes#3125
related to #2258

@ErikEJ
Improve SqlDataRecord DateOnly and TimeOnly coverage
5061ea5
Make SqlDecimalConvertToDecimal_TestInRange run on non-US systems
fixesdotnet#3125
related to dotnet#2258
@benrr101

benrr101 commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 31, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101

benrr101 commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Feb 3, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101

benrr101 commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

@ErikEJ looking into the test failures more, it looks like they're genuine failures of the test related to the changes you made. The value itself looks to be correct but the formatting is wrong. Looks like it's possible the assert isn't doing the right comparison?

benrr101
benrr101 requested changes Feb 11, 2025
View reviewed changes

@benrr101benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding until the unit tests are fixed

@ErikEJ

ErikEJ commented Feb 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@benrr101 Thanks - it is SO hard to locate the actual errors

@ErikEJ

ErikEJ commented Feb 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@benrr101 I had made the .NET Framework test pass locally 😆

@ErikEJ

ErikEJ commented Feb 19, 2025

Copy link
Copy Markdown
ContributorAuthor

@benrr101 Tests are passing now!

@benrr101

benrr101 commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Feb 19, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101

benrr101 commented Feb 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@ErikEJ Hmm, it looks like there's still an issue with the cast on netfx
https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109151&view=logs&j=166c4da6-b55b-5799-fbde-21502bcb70ff&t=a381c7c1-6591-5f42-6a10-14c2761ba4c4&l=700

@ErikEJ

ErikEJ commented Feb 20, 2025

Copy link
Copy Markdown
ContributorAuthor

@benrr101 OMG - the pipeline never ran - I will investigate, thanks

@ErikEJ

ErikEJ commented Feb 20, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@dotnet/sqlclientdevteam Pls kick the CI 🙏

@apoorvdeshmukh

apoorvdeshmukh commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Feb 20, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ErikEJ

ErikEJ commented Feb 21, 2025

Copy link
Copy Markdown
ContributorAuthor

@benrr101 Failing test seems unrelated ??

@benrr101

benrr101 commented Feb 21, 2025

Copy link
Copy Markdown
Contributor

@benrr101 Failing test seems unrelated ??

Agreed, it seems to be so. I'll proceed to kick it until its behavior improves.

@codecov

codecovBot commented Feb 21, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base (081fc51) to head (595c898).
Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (081fc51) and HEAD (595c898). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (081fc51)HEAD (595c898)
addons10
Additional details and impacted files
@@ Coverage Diff @@## main #3128 +/- ##
==========================================
- Coverage 72.73% 66.14% -6.59% 
==========================================
Files 283 279 -4 Lines 58997 58945 -52 ==========================================
- Hits 42910 38989 -3921 - Misses 16087 19956 +3869
FlagCoverage Δ
addons?
netcore69.22% <ø> (-6.32%)⬇️
netfx64.83% <ø> (-6.37%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benrr101
benrr101 approved these changes Feb 25, 2025
View reviewed changes

@benrr101benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing, LFG 🚢 🚢 🚢

@benrr101
benrr101 merged commit b5ce725 into dotnet:mainFeb 25, 2025
@mdaiglemdaigle added this to the 7.0-preview1 milestone Mar 21, 2025
@dependabotdependabotBot mentioned this pull request Jul 25, 2025
Open
This was referenced Jun 29, 2026
Closed
Closed
Closed
Open
Open
Closed
Closed
This was referenced Jul 8, 2026
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 17, 2026
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Aug 2, 2026
Open
Merged
Merged
Open
Closed
Merged
This was referenced Aug 10, 2026
Open
Open
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benrr101benrr101benrr101 approved these changes
@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees

@benrr101benrr101

Labels

None yet

Projects

None yet

Milestone

6.1-preview1

Development

Successfully merging this pull request may close these issues.

Add Support for DateOnly & TimeOnly types on SqlDataRecord

5 participants

@ErikEJ@benrr101@apoorvdeshmukh@paulmedynski@mdaigle