Skip to content

Disable failing TLS 1.0/1.1 tests - #3130

Merged
benrr101 merged 3 commits into
dotnet:mainfrom
edwardneal:correct-pr-3126
Jan 28, 2025
Merged

Disable failing TLS 1.0/1.1 tests#3130
benrr101 merged 3 commits into
dotnet:mainfrom
edwardneal:correct-pr-3126

Conversation

@edwardneal

@edwardnealedwardneal commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Rolls up change from original connection test matrix #3127. Corrects #3126, removing its associated test.
CI is currently failing on main branch - it no longer supports TLS 1.0/1.1, so the tests which require TLS 1.2 are failing. This PR removes them.

Does not require porting to release/6.0.

cc @benrr101

@edwardneal
Reverted changes to connection test matrix
a066a61
Tests were failing in main branch - CI environment only supports TLS 1.2
@benrr101

benrr101 commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 22, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101
benrr101 requested a review from a teamJanuary 22, 2025 23:32
paulmedynski
paulmedynski requested changes Jan 23, 2025
View reviewed changes

@paulmedynskipaulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in-file.

@edwardneal

edwardneal commented Jan 23, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks @paulmedynski, I've addressed them. Would you mind triggering the pipeline again please?

@paulmedynski

paulmedynski commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 23, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101

benrr101 commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 23, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@codecov

codecovBot commented Jan 24, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (ebfbebb) to head (4782c74).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ebfbebb) and HEAD (4782c74). Click for more details.

HEAD has 5 uploads less than BASE
FlagBASE (ebfbebb)HEAD (4782c74)
addons50
Additional details and impacted files
@@ Coverage Diff @@## main #3130 +/- ##
==========================================
- Coverage 72.72% 66.10% -6.62% 
==========================================
Files 283 277 -6 Lines 58996 58687 -309 ==========================================
- Hits 42905 38797 -4108 - Misses 16091 19890 +3799
FlagCoverage Δ
addons?
netcore69.19% <ø> (-6.31%)⬇️
netfx64.86% <ø> (-6.33%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101

benrr101 commented Jan 24, 2025

Copy link
Copy Markdown
Contributor

@edwardneal I'm not 100% sure about these failures, but can you merge/rebase from main and we can try again? @David-Engel made some changes that should fix running CI pipelines from forks

@edwardneal

edwardneal commented Jan 25, 2025

Copy link
Copy Markdown
ContributorAuthor

I've just done that. The pipeline hasn't run automatically though, so needs another trigger.

@cheenamalhotra

cheenamalhotra commented Jan 26, 2025

Copy link
Copy Markdown
Member

/azp run

@cheenamalhotracheenamalhotra added this to the 7.0-preview1 milestone Jan 26, 2025
@azure-pipelines

azure-pipelinesBot commented Jan 26, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@benrr101

benrr101 commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Ok, it all looks good to me 🚢

@benrr101
benrr101 merged commit 82edd8b into dotnet:mainJan 28, 2025
@edwardneal
edwardneal deleted the correct-pr-3126 branch January 28, 2025 18:05
benrr101 pushed a commit that referenced this pull request Mar 4, 2025
@edwardneal@benrr101
Disable failing TLS 1.0/1.1 tests (#3130)
5aa8c2c
* Reverted changes to connection test matrix
Tests were failing in main branch - CI environment only supports TLS 1.2
* Remove const from ConnectionTestParametersData
benrr101 pushed a commit that referenced this pull request Mar 4, 2025
@edwardneal@benrr101
Disable failing TLS 1.0/1.1 tests (#3130)
bc5bc5b
* Reverted changes to connection test matrix
Tests were failing in main branch - CI environment only supports TLS 1.2
* Remove const from ConnectionTestParametersData
This was referenced Jul 25, 2025
Open
Merged
Merged
This was referenced Jun 29, 2026
Closed
Closed
Closed
Open
Open
Closed
Closed
This was referenced Jul 8, 2026
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 17, 2026
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Aug 2, 2026
Open
Merged
Merged
Open
Closed
Merged
This was referenced Aug 10, 2026
Open
Open
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benrr101benrr101benrr101 approved these changes
@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.1-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@edwardneal@benrr101@paulmedynski@cheenamalhotra