Skip to content

Merge | LocalDbConfig - #3171

Merged
benrr101 merged 2 commits into
mainfrom
dev/russellben/merge/localdbconfig
Feb 26, 2025
Merged

Merge | LocalDbConfig#3171
benrr101 merged 2 commits into
mainfrom
dev/russellben/merge/localdbconfig

Conversation

@benrr101

Copy link
Copy Markdown
Contributor

Description: Finally back on track for merging the netfx and netcore projects. In this exciting installment, we're merging the LocalDbConfig file. This file contains a few class definitions that are used to provide an object model for accessing the program's configuration file. They only apply to netfx, and can be easily moved into the common project, tagged as netfx, and wrapped in #if NETFRAMEWORK. The file was also split into separate files for class and placed in a folder that better represents the namespace (Microsoft.Data.SqlClient.LocalDb).

Testing: No functional changes, just moving things around.

@benrr101benrr101 added the Common Project 🚮 Things that relate to the common project project label Feb 20, 2025
@benrr101benrr101 added this to the 7.0-preview1 milestone Feb 20, 2025
@benrr101
benrr101 requested a review from a teamFebruary 20, 2025 23:39
@codecov

codecovBot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.79%. Comparing base (17cb0b0) to head (6d7191e).
Report is 10 commits behind head on main.

Files with missing linesPatch %Lines
...Client/LocalDb/LocalDbInstancesCollection.netfx.cs0.00%10 Missing ⚠️
...src/Microsoft/Data/SqlClient/LocalDBAPI.Windows.cs0.00%4 Missing ⚠️
.../SqlClient/LocalDb/LocalDbInstanceElement.netfx.cs0.00%2 Missing ⚠️
...lient/LocalDb/LocalDbConfigurationSection.netfx.cs0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #3171 +/- ##
==========================================
- Coverage 72.96% 72.79% -0.18% 
==========================================
Files 283 284 +1 Lines 58997 59110 +113 ==========================================
- Hits 43048 43029 -19 - Misses 15949 16081 +132 
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.48% <0.00%> (-0.25%)⬇️
netfx71.14% <0.00%> (-0.22%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benrr101
benrr101 merged commit 2013a71 into mainFeb 26, 2025
@benrr101
benrr101 deleted the dev/russellben/merge/localdbconfig branch February 26, 2025 18:35
This was referenced Jul 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Common Project 🚮Things that relate to the common project project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@benrr101@mdaigle@cheenamalhotra