Skip to content

Allow sni version override for testing - #3184

Merged
mdaigle merged 3 commits into
mainfrom
dev/mdaigle/testing-sni-override
Mar 10, 2025
Merged

Allow sni version override for testing#3184
mdaigle merged 3 commits into
mainfrom
dev/mdaigle/testing-sni-override

Conversation

@mdaigle

@mdaiglemdaigle commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

When we make changes to SNI, it's important to test the changes in combination with MDS to avoid regressions. This PR adds the ability to trigger a pipeline run with an overridden SNI version pulled from the internal validation feed in ADO. This functionality is only available to pipeline runs within the ADO.Net project in ADO. Pipeline runs within the public project do not have access to the internal feed and will fail if an override version is set.

Proof that runs fail in public pipelines when sni override is set:
Project: https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109913&view=results
Package: https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109914&view=results

@mdaiglemdaigle changed the title Allow sni override for testingAllow sni version override for testingFeb 27, 2025
@mdaigle
mdaigle marked this pull request as ready for review February 27, 2025 16:42
@mdaigle
mdaigle requested a review from a teamFebruary 27, 2025 16:42
@mdaigle
mdaigleforce-pushed the dev/mdaigle/testing-sni-override branch from bf93c4d to 0d228f2CompareFebruary 27, 2025 17:06

@paulmedynskipaulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nitpicks.

Comment threadeng/pipelines/common/templates/steps/override-sni-version.yml Outdated
Comment threadeng/pipelines/common/templates/steps/override-sni-version.yml Outdated
Comment threadeng/pipelines/common/templates/steps/override-sni-version.yml Outdated
@codecov

codecovBot commented Feb 27, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base (17cb0b0) to head (2702322).
Report is 26 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #3184 +/- ##
==========================================
- Coverage 72.96% 72.80% -0.16% 
==========================================
Files 283 285 +2 Lines 58997 59137 +140 ==========================================
+ Hits 43048 43057 +9 - Misses 15949 16080 +131 
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.53% <ø> (-0.20%)⬇️
netfx71.15% <ø> (-0.21%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you and I should have a bit of a conversation about when and how the handful of components need to be tested together (MDS, SNI, AKV, MSS, ETC, WTF, BBQ). I want to get a better idea what depends on what and how the pipelines should be constructed to handle those situations. It's nothing that needs to block this specific PR, but since I think we will want to rebuild this pipeline as part of other engineering goals, I think we'll want to discuss it at some point.

Comment threadeng/pipelines/dotnet-sqlclient-ci-core.yml Outdated
Comment threadeng/pipelines/dotnet-sqlclient-ci-core.yml Outdated
Comment threadeng/pipelines/dotnet-sqlclient-ci-core.yml
@mdaigle
mdaigle merged commit b242b89 into mainMar 10, 2025
@mdaigle
mdaigle deleted the dev/mdaigle/testing-sni-override branch March 10, 2025 16:26
@mdaiglemdaigle added this to the 7.0-preview1 milestone Mar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mdaigle@benrr101@cheenamalhotra@paulmedynski