Skip to content

Merge | TdsParser cosmetic changes - #3222

Merged
mdaigle merged 13 commits into
dotnet:mainfrom
edwardneal:merge/tdsparser-diff-round-1
Apr 3, 2025
Merged

Merge | TdsParser cosmetic changes#3222
mdaigle merged 13 commits into
dotnet:mainfrom
edwardneal:merge/tdsparser-diff-round-1

Conversation

@edwardneal

@edwardnealedwardneal commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

This cleans up the diff of TdsParser. Contributes to #2953.

I recommend disabling whitespace when viewing this, it'll bring the PR size down to +239/-148.

Most of TdsParser is pretty similar. We've refactored a few methods, some of the members are in different orders and there are other cosmetic differences though, so this needs to be aligned before we can see where the true differences lie. This PR is the first of a few which do that. I'm fairly sure that once we've done that, only a few dozen lines of code will truly be different.

This dovetails with #2985, which handles some of the refactoring.

If someone from the SqlClient team can run CI, this should be enough to validate it. I don't expect that anything will have changed in the compiled DLL.

@paulmedynski

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynskipaulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need comment from @benrr101 regarding constrainted regions.

@codecov

codecovBot commented Mar 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.29586% with 84 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base (e0fa87b) to head (05d8a51).
Report is 21 commits behind head on main.

Files with missing linesPatch %Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs34.37%63 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs71.23%21 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e0fa87b) and HEAD (05d8a51). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (e0fa87b)HEAD (05d8a51)
addons10
Additional details and impacted files
@@ Coverage Diff @@## main #3222 +/- ##
==========================================
- Coverage 72.64% 66.02% -6.63% 
==========================================
Files 288 282 -6 Lines 59600 59331 -269 ==========================================
- Hits 43299 39173 -4126 - Misses 16301 20158 +3857 
FlagCoverage Δ
addons?
netcore68.82% <34.37%> (-6.35%)⬇️
netfx65.00% <71.23%> (-6.27%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynskipaulmedynski self-assigned this Mar 21, 2025
@paulmedynskipaulmedynski added this to the 6.1-preview1 milestone Apr 2, 2025
@mdaiglemdaigle self-assigned this Apr 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@edwardneal@paulmedynski@benrr101@mdaigle