Uh oh!
There was an error while loading. Please reload this page.
Tidy up performance tests - #3230
Conversation
paulmedynski
commented
Mar 19, 2025
- Tidied up the existing Performance benchmarks.
- Added environment variables to specify config files.
- Removed Newtonsoft.Json as a dependency.
- Simplified csproj a bit.
- Tidied up the existing Performance benchmarks. - Added environment variables to specify config files. - Removed Newtonsoft.Json as a dependency. - Simplified csproj a bit.
There was a problem hiding this comment.
Pull Request Overview
This PR tidies up the performance tests by refactoring configuration loading, removing the Newtonsoft.Json dependency, and simplifying project files.
- Introduces a new JSON configuration loader using System.Text.Json.
- Updates performance test configuration for benchmarks and data types across several files.
- Revises the BUILDGUIDE to include instructions for setting up the runner configuration and an empty database.
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Loader.cs | Adds a utility to load JSON configs with environment variable overrides. |
| BUILDGUIDE.md | Updates usage instructions for benchmarks and configuration management. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/DataTypes.cs | Introduces a Load() method to load data types configuration. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Config.cs | Adds a Load() method for benchmark configuration. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/Program.cs | Refactors config loading and benchmark execution from a static context to an instance context. |
| src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BaseRunner.cs | Replaces Newtonsoft.Json deserialization with the new Loader API. |
Files not reviewed (2)
- src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj: Language not supported
- tools/props/Versions.props: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3230 +/- ##
==========================================
+ Coverage 72.73% 72.92% +0.18%
==========================================
Files 288 303 +15 Lines 59527 59527 ==========================================
+ Hits 43298 43409 +111 + Misses 16229 16118 -111
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
- Improved benchmark running instructions.