Skip to content

Merge | Port PR 499 to .NET Framework - #3255

Merged
benrr101 merged 1 commit into
dotnet:mainfrom
edwardneal:merge/port-pr499
Apr 7, 2025
Merged

Merge | Port PR 499 to .NET Framework#3255
benrr101 merged 1 commit into
dotnet:mainfrom
edwardneal:merge/port-pr499

Conversation

@edwardneal

@edwardnealedwardneal commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

This ports #499 from netcore to netfx.

Relates to #1261.
Relates to #2965.

Once this PR is finished, the next PR which touches SqlDataReader will be able to merge it.

I'd appreciate a CI run of this please.

@edwardnealedwardneal changed the title Port PR 499 to .NET FrameworkMerge | Port PR 499 to .NET FrameworkApr 2, 2025
@cheenamalhotra

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@codecov

codecovBot commented Apr 3, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.30%. Comparing base (1247ca4) to head (b132943).
Report is 14 commits behind head on main.

Files with missing linesPatch %Lines
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs88.00%3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1247ca4) and HEAD (b132943). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (1247ca4)HEAD (b132943)
addons10
Additional details and impacted files
@@ Coverage Diff @@## main #3255 +/- ##
==========================================
- Coverage 72.69% 66.30% -6.39% 
==========================================
Files 303 292 -11 Lines 59718 59324 -394 ==========================================
- Hits 43414 39337 -4077 - Misses 16304 19987 +3683 
FlagCoverage Δ
addons?
netcore69.02% <ø> (-6.09%)⬇️
netfx65.23% <88.00%> (-6.15%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaiglemdaigle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like basically a 1:1 port and tests pass ✔️

@mdaiglemdaigle self-assigned this Apr 3, 2025
@benrr101
benrr101 merged commit 1690e02 into dotnet:mainApr 7, 2025
@edwardneal
edwardneal deleted the merge/port-pr499 branch April 7, 2025 18:45
This was referenced Jul 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@edwardneal@cheenamalhotra@benrr101@mdaigle