Merge | SqlDataReader

[edwardneal]

Fixes#2965.
Contributes to #1261.

This merges SqlDataReader. It might be worth reviewing each commit individually:

• Commit 1 merges the contents of the files.
• Commit 2 replaces the files and patches the XML documentation paths.
• Commit 3 mops up two debug assertions and a comment.

Could someone run CI please?

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base (1690e02) to head (e83f966).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...ient/src/Microsoft/Data/SqlClient/SqlDataReader.cs	50.00%	3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1690e02) and HEAD (e83f966). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (1690e02)	HEAD (e83f966)
addons	1	0

Additional details and impacted files

@@ Coverage Diff @@## main #3259 +/- ##
==========================================
- Coverage 72.83% 66.19% -6.64% 
==========================================
Files 298 290 -8 Lines 59675 56944 -2731 ==========================================
- Hits 43463 37693 -5770 - Misses 16212 19251 +3039 

Flag	Coverage Δ
addons	?
netcore	68.95% <50.00%> (-6.30%)	⬇️
netfx	65.17% <78.57%> (-6.29%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.