Skip to content

Remove ADP.IsEmpty() - #3277

Merged
cheenamalhotra merged 1 commit into
dotnet:mainfrom
ErikEJ:remove-adp-isempty
Apr 16, 2025
Merged

Remove ADP.IsEmpty()#3277
cheenamalhotra merged 1 commit into
dotnet:mainfrom
ErikEJ:remove-adp-isempty

Conversation

@ErikEJ

Copy link
Copy Markdown
Contributor

No description provided.

@samsharma2700samsharma2700 self-assigned this Apr 15, 2025
@ErikEJ

Copy link
Copy Markdown
ContributorAuthor

@samsharma2700@mdaigle Could some start the CI?

@mdaigle

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynskipaulmedynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing stuff like this is very satisfying :)

@paulmedynski
paulmedynski requested a review from a teamApril 16, 2025 10:54
@paulmedynskipaulmedynski self-assigned this Apr 16, 2025

@apoorvdeshmukhapoorvdeshmukh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cheenamalhotracheenamalhotra added this to the 6.1-preview1 milestone Apr 16, 2025
@cheenamalhotra
cheenamalhotra merged commit c5e3c40 into dotnet:mainApr 16, 2025
@codecov

codecovBot commented Apr 16, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 73.46939% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (aa35edc) to head (ad0b284).
Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
...x/src/Microsoft/Data/SqlClient/SqlDataReaderSmi.cs0.00%6 Missing ⚠️
...fx/src/Microsoft/Data/Common/DBConnectionString.cs25.00%3 Missing ⚠️
...x/src/Microsoft/Data/Common/DbConnectionOptions.cs80.00%1 Missing ⚠️
...rc/Microsoft/Data/SqlClient/SqlClientPermission.cs0.00%1 Missing ⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs87.50%1 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs0.00%1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (aa35edc) and HEAD (ad0b284). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (aa35edc)HEAD (ad0b284)
addons10
Additional details and impacted files
@@ Coverage Diff @@## main #3277 +/- ##
==========================================
- Coverage 72.91% 66.26% -6.66% 
==========================================
Files 296 289 -7 Lines 57257 56901 -356 ==========================================
- Hits 41751 37704 -4047 - Misses 15506 19197 +3691 
FlagCoverage Δ
addons?
netcore68.96% <100.00%> (-6.15%)⬇️
netfx65.26% <73.46%> (-6.19%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jul 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ErikEJ@mdaigle@apoorvdeshmukh@cheenamalhotra@paulmedynski@samsharma2700