fix(cli): npm install under windows (#1539)

Closes#1445

Author: buchslava

lib/cli.js

@@ -18,6 +18,7 @@ var Logging = IonicAppLib.logging;
 varlog=Logging.logger;
 varQ=require('q');
 varhelpUtil=require('./utils/help');
+varEOL=require('os').EOL;
 
 Cli.ALL_TASKS=Tasks;
 Cli.IONIC_DASH='https://apps.ionic.io';
@@ -268,7 +269,7 @@ Cli.loadGulpfile = function loadGulpfile() {
 varnames=['gulpfile.js','Gulpfile.js'];
 for(vari=0,ii=names.length;i<ii;i+=1){
 try{
-require(path.resolve(process.cwd()+'/'+names[i]));
+require(path.resolve(process.cwd(),names[i]));
 log.verbose('Gulpfile found');
 returntrue;
 }catch(e){
@@ -331,7 +332,7 @@ Cli.runNpmHook = function runNpmHook(hook) {
 });
 spawned.stdout.pipe(process.stdout);
 spawned.stdout.on('data',function(data){
-vardataLines=data.toString().split('\n');
+vardataLines=data.toString().split(EOL);
 for(vari=0;i<dataLines.length;i++){
 if(dataLines[i].length){
 if(dataLines[i].indexOf('watch ready')>-1){
@@ -360,7 +361,7 @@ Cli.loadNpmScripts = function loadNpmScripts() {
 varfileName='package.json';
 
 try{
-varpackageFile=require(path.resolve(process.cwd()+'/'+fileName));
+varpackageFile=require(path.resolve(process.cwd(),fileName));
 log.verbose('Package.json found scripts:',packageFile.scripts);
 returnpackageFile.scripts;
 }catch(e){

lib/utils/help.js

@@ -2,6 +2,7 @@
 
 varIonicAppLib=require('ionic-app-lib');
 varlog=IonicAppLib.logging.logger;
+varEOL=require('os').EOL;
 require('colors');
 
 /**
@@ -173,7 +174,7 @@ function printTaskDetails(d) {
 }
 w((indent+' '+arg+' ').bold);
 
-varargDescs=d.args[arg].split('\n');
+varargDescs=d.args[arg].split(EOL);
 varargIndent=indent+' ';
 
 for(x=0;x<arg.length+1;x+=1){
@@ -218,9 +219,9 @@ function printTaskDetails(d) {
 varoptDescs;
 
 if(typeoftaskOpt=='string'){
-optDescs=taskOpt.split('\n');
+optDescs=taskOpt.split(EOL);
 }else{
-optDescs=taskOpt.title.split('\n');
+optDescs=taskOpt.title.split(EOL);
 }
 for(x=0;x<optDescs.length;x+=1){
 if(x===0){

spec/utils/templates.spec.js

@@ -5,6 +5,7 @@ var rewire = require('rewire');
 vartemplateUtils=rewire('../../lib/utils/templates');
 varIonicAppLib=require('ionic-app-lib');
 varlog=IonicAppLib.logging.logger;
+varEOL=require('os').EOL;
 
 describe('listTemplates method',function(){
 it('should should call fetchStarterTemplates pull out templates/sort and send to list',function(done){
@@ -148,7 +149,7 @@ describe('list function', function() {
 varlist=templateUtils.__get__('list');
 
 list(templates);
-expect(log.info.calls[0].args).toEqual(['\n']);
+expect(log.info.calls[0].args).toEqual([EOL]);
 expect(log.info.calls[1].args[0]).toMatch('a-template');// Use match because of colors
 expect(log.info.calls[1].args[1]).toEqual('...........');
 expect(log.info.calls[1].args[2]).toEqual(templates[0].description);