Uh oh!
There was an error while loading. Please reload this page.
Add HTTPTransport and AsyncHTTPTransport - #1399
Conversation
florimondmanca
left a comment
There was a problem hiding this comment.
Looking good! Is it expecting that keepalive changes are also in here, though?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lovelydinosaur
commented
Jan 7, 2021
@florimondmanca Okay, so... I've gone for explicit arguments throughout. (Maxim of: Of two otherwise equally valid design options, choose the more constrained) Note that it highlights the fact that I've also added the |
florimondmanca
left a comment
There was a problem hiding this comment.
Okay, this is looking neat. 👍
remingtonc
commented
Feb 5, 2021
This is an exciting addition - any idea when it will be released? |
Closes #1302
Two points to note here...
httpx.ProxyTransport()/httpx.AsyncProxyTransport()classes.proxyargument to the existing class. Switch whichhttpcoreinstance is used for._pooldepending on that argument.httpx.HTTPTransport(proxy=...),httpx.AsyncHTTPTransport(proxy=...). I think I quite like the way that'd have a lower footprint.kwargsfor the advanced options. I'm kinda thinking to switch these out to nameduds,local_address, etc... options instead, althoughkwargsdoes at least have the benefit of allowing us to add options tohttpcoreand have them be exposed without any changes inhttpx.