Uh oh!
There was an error while loading. Please reload this page.
CertTypes keyfile and password should be Optional types. - #1503
Merged
Conversation
florimondmanca
left a comment
Contributor
There was a problem hiding this comment.
Very nice, thanks. Just a small idea.
Uh oh!
There was an error while loading. Please reload this page.
keyfile and password should be Optional types.lovelydinosaur
approved these changes
Mar 10, 2021
lovelydinosaur
left a comment
Contributor
There was a problem hiding this comment.
Yup, looks decent. Thanks!
florimondmanca
commented
Mar 10, 2021
Contributor
Thanks @decaz! |
Merged
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1502.