feat: set disabled accessibilityState when TouchableHighlight is disabled

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉

[Naturalclar]

#30950

Summary

automatically set disabled to accessibilityState when TouchableHighlight is disabled

Changelog

[General] [Changed] - Set disabled accessibilityState when TouchableHighlight is disabled

Test Plan

Tested on physical android device that pressing disabled TouchableHighlight announces "dim" when talkback is on

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dbf5fa2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,908,986	-23,907
android	hermes	armeabi-v7a	8,408,025	-15,920
android	hermes	x86	9,399,614	-23,460
android	hermes	x86_64	9,343,422	-24,434
android	jsc	arm64-v8a	10,642,521	-23,266
android	jsc	armeabi-v7a	10,124,648	-15,286
android	jsc	x86	10,694,646	-22,819
android	jsc	x86_64	11,278,720	-23,797

Base commit: dbf5fa2

[kacieb]

This is great and those test cases are awesome! 😍 Thank you so much for working on this!

@lunaleaps Do you think the component should also be disabled if accessibilityState.disabled=true, if the disabled prop is not set? Like in this PR: #31001

[lunaleaps]

Yea! I think it'd be good to have this consistent across the components. @Naturalclar can you follow the logic in #31001 where accessibilityState.disabled set to true will also disable the component?

[Naturalclar]

@lunaleaps Sure thing! made the change in 4dc00ba

[facebook-github-bot]

@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kacieb merged this pull request in f69e096.

[amarlette]

Thank you @Naturalclar for this contribution! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? Is your twitter @ the same as your Github?

[Naturalclar]

@amarlette thank you!
My Twitter account is natural_clar 😃

[kacieb]

Thank you so much for this pull request!!!

I made a few small changes to the test cases before landing, and wanted to let you know in case you write any future tests! Thanks so much for including the tests by the way, that will make sure this functionality doesn't break in the future.

I changed the expectRenderMatchingSnapshot calls to use this structure instead:

expect(
ReactTestRenderer.create(<TouchableHighlight ... />)
).toMatchSnapshot();

This is because expectRenderMatchingSnapshot is primarily only needed for checking that the display name works correctly, and that mocking and unmocking the component works as expected. This wasn't necessary in this case, since we're only checking prop values.

Thanks again for helping improve React Native's accessibility! 🎉