Skip to content

fix: remove old command for align packages versions - #38548

Closed
kelset wants to merge 1 commit into
mainfrom
kelset/fix-release-packages-scripts
Closed

fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom
kelset/fix-release-packages-scripts

Conversation

@kelset

@kelsetkelset commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Summary:

While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.

This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927

We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)

So this commit just takes care of that.

Changelog:

[INTERNAL] [REMOVED] - remove old command for align packages versions

Test Plan:

N/A - it's a removal

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Microsoft Partner: Microsoft Partner labels Jul 21, 2023
@github-actions

github-actionsBot commented Jul 21, 2023

Copy link
Copy Markdown
Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e

@facebook-github-botfacebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Jul 21, 2023
@facebook-github-bot

facebook-github-bot commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@hoxyq

hoxyq commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

I guess I've just changed my mind between merging it into 0.72 and main.
This command still can be used, though. There is not so much sense to use it alone now, but still.

Make sure removing this section in docs, if you end up removing this command.

hoxyq referenced this pull request Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot added the Merged This PR has been merged. label Jul 21, 2023
@facebook-github-bot

facebook-github-bot commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

@cortinico merged this pull request in 8f4542d.

@kelset
kelset deleted the kelset/fix-release-packages-scripts branch July 24, 2023 10:14
@cortinico

cortinico commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

I guess I've just changed my mind between merging it into 0.72 and main.
This command still can be used, though. There is not so much sense to use it alone now, but still.

Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq

@kelsetkelset mentioned this pull request Jul 28, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees

No one assigned

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
fix: remove old command for align packages versions by kelset · Pull Request #38548 · react/react-native · GitHub
Skip to content
fix: remove old command for align packages versions - #38548
Closed
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Closed
fix: remove old command for align packages versions#38548
kelset wants to merge 1 commit into
mainfrom 
kelset/fix-release-packages-scripts
Conversation
@kelset
@kelsetkelset
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
Summary:
While working on a couple things, me Riccardo and Nicola noticed that in main for some reason the old align-package-versions command in the root package.json was still there in main branch.
This was "merged into" bump-all-updated-packages by @hoxyq all the way back in March; here's the commit for 0.72 branch -> a469927
We are not sure why, but for some reason the same commit in main was borked in some way, and didn't actually remove the command: PR (#36568) and commit (04df252)
So this commit just takes care of that.
Changelog:
[INTERNAL] [REMOVED] - remove old command for align packages versions
Test Plan:
N/A - it's a removal
@facebook-github-botfacebook-github-bot
added

CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Contributor
A React Native contributor.
p: Microsoft
Partner: Microsoft
Partner

labels
Jul 21, 2023
@github-actions
github-actionsBot
commented
Jul 21, 2023

Copy link


Copy Markdown

Warnings
⚠️🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dc5025e
@facebook-github-botfacebook-github-bot
added
the 
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hoxyq
hoxyq
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Make sure removing this section in docs, if you end up removing this command.
hoxyq referenced
this pull request
Jul 21, 2023
Ruslan Lesiutin@facebook-github-bot
RN [refactor]: bump and realign package versions by running a single …
04df252
…script (#36568)
Summary:
Pull Request resolved: #36568
Changelog: [Internal]
Okay, so before the monorepo migration we had to use two scripts separately:
1. Bumping every package with `npm run bump-all-updated-packages`
2. Aligning other packages versions with `npm run align-package-versions`
The reason for it is that *before the monorepo* in a release branch cutoff process we had a step, which was removing `workspaces` keyword from `react-native` package. Without this keyword all new versions of packages will be resolved from npm (where they will be not available yet, because we have to publish them prior to it)
This is not the case for our current setup, and we can actually bump packages versions and they will be resolved as a workspaces successfully
Reviewed By: cortinico, cipolleschi
Differential Revision: D44261057
fbshipit-source-id: 31c2157be2d3b33bc073651d6045efcef2e8f5c5
@facebook-github-botfacebook-github-bot
added
the 
Merged
This PR has been merged.
label
Jul 21, 2023
@facebook-github-bot
facebook-github-bot
commented
Jul 21, 2023

Copy link


Copy Markdown

Contributor
@cortinico merged this pull request in 8f4542d.
@kelset
kelset
deleted the

kelset/fix-release-packages-scripts

branch
July 24, 2023 10:14
@cortinico
cortinico
commented
Jul 24, 2023

Copy link


Copy Markdown

Contributor
I guess I've just changed my mind between merging it into 0.72 and main.

This command still can be used, though. There is not so much sense to use it alone now, but still.
Actually that command doesn't seems to work anymore (that's what we experienced on Friday last week). That's also what triggered this investigation and removal @hoxyq
@kelsetkelset
mentioned this pull request
Jul 28, 2023
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cortinicocortinicocortinico approved these changes
@cipolleschicipolleschiAwaiting requested review from cipolleschi
@hoxyqhoxyqAwaiting requested review from hoxyq

Assignees


No one assigned


Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.ContributorA React Native contributor.MergedThis PR has been merged.p: MicrosoftPartner: MicrosoftPartnerShared with MetaApplied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kelset@facebook-github-bot@hoxyq@cortinico