[eprh] Remove NoUnusedOptOutDirectives (#34703)

This rule was a leftover from a while ago and doesn't actually lint
anything useful. Specifically, you get a lint error if you try to opt
out a component that isn't already bailing out. If there's a bailout the
compiler already safely skips over it, so adding `'use no memo'` there
is unnecessary.
Fixes#31407
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703).
* __->__ #34703
* #34700

Author: poteto

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

compiler/packages/eslint-plugin-react-compiler/__tests__/NoUnusedDirectivesRule-test.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(

compiler/packages/eslint-plugin-react-compiler/src/rules/ReactCompilerRule.ts

@@ -161,69 +161,21 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
 
-exportconstallRules: RulesConfig=LintRules.reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+exportconstallRules: RulesConfig=LintRules.reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
 rule=>rule.recommended,
-).reduce(
-(acc,rule)=>{
-acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
-returnacc;
-},
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
-);
+).reduce((acc,rule)=>{
+acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
+returnacc;
+},{}asRulesConfig);
 
 exportfunctionmapErrorSeverityToESlint(
 severity: ErrorSeverity,

compiler/packages/eslint-plugin-react-compiler/src/shared/RunReactCompiler.ts

@@ -5,20 +5,18 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import{transformFromAstSync,traverse}from'@babel/core';
+import{transformFromAstSync}from'@babel/core';
 import{parseasbabelParse}from'@babel/parser';
-import{Directive,File}from'@babel/types';
+import{File}from'@babel/types';
 // @ts-expect-error: no types available
 importPluginProposalPrivateMethodsfrom'@babel/plugin-proposal-private-methods';
 importBabelPluginReactCompiler,{
 parsePluginOptions,
 validateEnvironmentConfig,
-OPT_OUT_DIRECTIVES,
 typePluginOptions,
 }from'babel-plugin-react-compiler/src';
 import{Logger,LoggerEvent}from'babel-plugin-react-compiler/src/Entrypoint';
 importtype{SourceCode}from'eslint';
-import{SourceLocation}from'estree';
 // @ts-expect-error: no types available
 import*asHermesParserfrom'hermes-parser';
 import{isDeepStrictEqual}from'util';
@@ -45,17 +43,11 @@ const COMPILER_OPTIONS: PluginOptions = {
 }),
 };
 
-exporttypeUnusedOptOutDirective={
-loc: SourceLocation;
-range: [number,number];
-directive: string;
-};
 exporttypeRunCacheEntry={
 sourceCode: string;
 filename: string;
 userOpts: PluginOptions;
 flowSuppressions: Array<{line: number;code: string}>;
-unusedOptOutDirectives: Array<UnusedOptOutDirective>;
 events: Array<LoggerEvent>;
 };
 
@@ -87,25 +79,6 @@ function getFlowSuppressions(
 returnresults;
 }
 
-functionfilterUnusedOptOutDirectives(
-directives: ReadonlyArray<Directive>,
-): Array<UnusedOptOutDirective>{
-constresults: Array<UnusedOptOutDirective>=[];
-for(constdirectiveofdirectives){
-if(
-OPT_OUT_DIRECTIVES.has(directive.value.value)&&
-directive.loc!=null
-){
-results.push({
-loc: directive.loc,
-directive: directive.value.value,
-range: [directive.start!,directive.end!],
-});
-}
-}
-returnresults;
-}
-
 functionrunReactCompilerImpl({
  sourceCode,
  filename,
@@ -125,7 +98,6 @@ function runReactCompilerImpl({
  filename,
  userOpts,
 flowSuppressions: [],
-unusedOptOutDirectives: [],
 events: [],
 };
 constuserLogger: Logger|null=options.logger;
@@ -181,29 +153,6 @@ function runReactCompilerImpl({
 configFile: false,
 babelrc: false,
 });
-
-if(results.events.filter(e=>e.kind==='CompileError').length===0){
-traverse(babelAST,{
-FunctionDeclaration(path){
-path.node;
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-ArrowFunctionExpression(path){
-if(path.node.body.type==='BlockStatement'){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-}
-},
-FunctionExpression(path){
-results.unusedOptOutDirectives.push(
- ...filterUnusedOptOutDirectives(path.node.body.directives),
-);
-},
-});
-}
 }catch(err){
 /* errors handled by injected logger */
 }

packages/eslint-plugin-react-hooks/src/shared/ReactCompiler.ts

@@ -160,38 +160,6 @@ function makeRule(rule: LintRule): Rule.RuleModule {
 };
 }
 
-exportconstNoUnusedDirectivesRule: Rule.RuleModule={
-meta: {
-type: 'suggestion',
-docs: {
-recommended: true,
-},
-fixable: 'code',
-hasSuggestions: true,
-// validation is done at runtime with zod
-schema: [{type: 'object',additionalProperties: true}],
-},
-create(context: Rule.RuleContext): Rule.RuleListener{
-constresults=getReactCompilerResult(context);
-
-for(constdirectiveofresults.unusedOptOutDirectives){
-context.report({
-message: `Unused '${directive.directive}' directive`,
-loc: directive.loc,
-suggest: [
-{
-desc: 'Remove the directive',
-fix(fixer): Rule.Fix{
-returnfixer.removeRange(directive.range);
-},
-},
-],
-});
-}
-return{};
-},
-};
-
 typeRulesConfig={
 [name: string]: {rule: Rule.RuleModule;severity: ErrorSeverity};
 };
@@ -201,12 +169,7 @@ export const allRules: RulesConfig = LintRules.reduce(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportconstrecommendedRules: RulesConfig=LintRules.filter(
@@ -216,12 +179,7 @@ export const recommendedRules: RulesConfig = LintRules.filter(
 acc[rule.name]={rule: makeRule(rule),severity: rule.severity};
 returnacc;
 },
-{
-'no-unused-directives': {
-rule: NoUnusedDirectivesRule,
-severity: ErrorSeverity.Error,
-},
-}asRulesConfig,
+{}asRulesConfig,
 );
 
 exportfunctionmapErrorSeverityToESlint(