Skip to content

Commit 1be3ce9

Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9

2 files changed

Lines changed: 395 additions & 3 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @emails react-core
8+
* @jest-environment node
9+
*/
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[Fiber] Bail out of diffing wide objects and arrays (#34742) · react/react@1be3ce9 · GitHub
Skip to content
Commit 1be3ce9
Browse files
eps1loneps1lon
authored
[Fiber] Bail out of diffing wide objects and arrays (#34742)
1 parent 3b2a398 commit 1be3ce9
2 files changed
Lines changed: 395 additions & 3 deletions
File tree
‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎
Lines changed: 327 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,327 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @emails react-core
8+
 * @jest-environment node
9+
 */
10+
11+
letReact;
12+
letReactNoop;
13+
letScheduler;
14+
letact;
15+
letuseEffect;
16+
17+
describe('ReactPerformanceTracks',()=>{
18+
beforeEach(()=>{
19+
Object.defineProperty(performance,'measure',{
20+
value: jest.fn(),
21+
configurable: true,
22+
});
23+
console.timeStamp=()=>{};
24+
jest.spyOn(console,'timeStamp').mockImplementation(()=>{});
25+
26+
jest.resetModules();
27+
28+
React=require('react');
29+
ReactNoop=require('react-noop-renderer');
30+
Scheduler=require('scheduler');
31+
act=require('internal-test-utils').act;
32+
useEffect=React.useEffect;
33+
});
34+
35+
// @gate __DEV__ && enableComponentPerformanceTrack
36+
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
37+
constApp=functionApp({items}){
38+
Scheduler.unstable_advanceTime(10);
39+
useEffect(()=>{},[items]);
40+
};
41+
42+
Scheduler.unstable_advanceTime(1);
43+
constitems=['one','two'];
44+
awaitact(()=>{
45+
ReactNoop.render(<Appitems={items}/>);
46+
});
47+
48+
expect(performance.measure.mock.calls).toEqual([
49+
[
50+
'Mount',
51+
{
52+
detail: {
53+
devtools: {
54+
color: 'warning',
55+
properties: null,
56+
tooltipText: 'Mount',
57+
track: 'Components ⚛',
58+
},
59+
},
60+
end: 11,
61+
start: 1,
62+
},
63+
],
64+
]);
65+
performance.measure.mockClear();
66+
67+
Scheduler.unstable_advanceTime(10);
68+
awaitact(()=>{
69+
ReactNoop.render(<Appitems={items.concat('4')}/>);
70+
});
71+
72+
expect(performance.measure.mock.calls).toEqual([
73+
[
74+
'​App',
75+
{
76+
detail: {
77+
devtools: {
78+
color: 'primary-dark',
79+
properties: [
80+
['Changed Props',''],
81+
[' items','Array'],
82+
['+ 2','…'],
83+
],
84+
tooltipText: 'App',
85+
track: 'Components ⚛',
86+
},
87+
},
88+
end: 31,
89+
start: 21,
90+
},
91+
],
92+
]);
93+
});
94+
95+
// @gate __DEV__ && enableComponentPerformanceTrack
96+
it('bails out of diffing wide arrays',async()=>{
97+
constApp=functionApp({items}){
98+
Scheduler.unstable_advanceTime(10);
99+
React.useEffect(()=>{},[items]);
100+
};
101+
102+
Scheduler.unstable_advanceTime(1);
103+
constitems=Array.from({length: 1000},(_,i)=>i);
104+
awaitact(()=>{
105+
ReactNoop.render(<Appitems={items}/>);
106+
});
107+
108+
expect(performance.measure.mock.calls).toEqual([
109+
[
110+
'Mount',
111+
{
112+
detail: {
113+
devtools: {
114+
color: 'warning',
115+
properties: null,
116+
tooltipText: 'Mount',
117+
track: 'Components ⚛',
118+
},
119+
},
120+
end: 11,
121+
start: 1,
122+
},
123+
],
124+
]);
125+
performance.measure.mockClear();
126+
127+
Scheduler.unstable_advanceTime(10);
128+
awaitact(()=>{
129+
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130+
});
131+
132+
expect(performance.measure.mock.calls).toEqual([
133+
[
134+
'​App',
135+
{
136+
detail: {
137+
devtools: {
138+
color: 'primary-dark',
139+
properties: [
140+
['Changed Props',''],
141+
[' items','Array'],
142+
[
143+
'Previous object has more than 100 properties. React will not attempt to diff objects with too many properties.',
144+
'',
145+
],
146+
[
147+
'Next object has more than 100 properties. React will not attempt to diff objects with too many properties.',
148+
'',
149+
],
150+
],
151+
tooltipText: 'App',
152+
track: 'Components ⚛',
153+
},
154+
},
155+
end: 31,
156+
start: 21,
157+
},
158+
],
159+
]);
160+
});
161+
162+
// @gate __DEV__ && enableComponentPerformanceTrack
163+
it('does not show all properties of wide objects',async()=>{
164+
constApp=functionApp({items}){
165+
Scheduler.unstable_advanceTime(10);
166+
React.useEffect(()=>{},[items]);
167+
};
168+
169+
Scheduler.unstable_advanceTime(1);
170+
awaitact(()=>{
171+
ReactNoop.render(<Appdata={{buffer: null}}/>);
172+
});
173+
174+
expect(performance.measure.mock.calls).toEqual([
175+
[
176+
'Mount',
177+
{
178+
detail: {
179+
devtools: {
180+
color: 'warning',
181+
properties: null,
182+
tooltipText: 'Mount',
183+
track: 'Components ⚛',
184+
},
185+
},
186+
end: 11,
187+
start: 1,
188+
},
189+
],
190+
]);
191+
performance.measure.mockClear();
192+
193+
Scheduler.unstable_advanceTime(10);
194+
195+
constbigData=newUint8Array(1000);
196+
awaitact(()=>{
197+
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198+
});
199+
200+
expect(performance.measure.mock.calls).toEqual([
201+
[
202+
'​App',
203+
{
204+
detail: {
205+
devtools: {
206+
color: 'primary-dark',
207+
properties: [
208+
['Changed Props',''],
209+
[' data',''],
210+
['– buffer','null'],
211+
['+ buffer','Uint8Array'],
212+
['+ 0','0'],
213+
['+ 1','0'],
214+
['+ 2','0'],
215+
['+ 3','0'],
216+
['+ 4','0'],
217+
['+ 5','0'],
218+
['+ 6','0'],
219+
['+ 7','0'],
220+
['+ 8','0'],
221+
['+ 9','0'],
222+
['+ 10','0'],
223+
['+ 11','0'],
224+
['+ 12','0'],
225+
['+ 13','0'],
226+
['+ 14','0'],
227+
['+ 15','0'],
228+
['+ 16','0'],
229+
['+ 17','0'],
230+
['+ 18','0'],
231+
['+ 19','0'],
232+
['+ 20','0'],
233+
['+ 21','0'],
234+
['+ 22','0'],
235+
['+ 23','0'],
236+
['+ 24','0'],
237+
['+ 25','0'],
238+
['+ 26','0'],
239+
['+ 27','0'],
240+
['+ 28','0'],
241+
['+ 29','0'],
242+
['+ 30','0'],
243+
['+ 31','0'],
244+
['+ 32','0'],
245+
['+ 33','0'],
246+
['+ 34','0'],
247+
['+ 35','0'],
248+
['+ 36','0'],
249+
['+ 37','0'],
250+
['+ 38','0'],
251+
['+ 39','0'],
252+
['+ 40','0'],
253+
['+ 41','0'],
254+
['+ 42','0'],
255+
['+ 43','0'],
256+
['+ 44','0'],
257+
['+ 45','0'],
258+
['+ 46','0'],
259+
['+ 47','0'],
260+
['+ 48','0'],
261+
['+ 49','0'],
262+
['+ 50','0'],
263+
['+ 51','0'],
264+
['+ 52','0'],
265+
['+ 53','0'],
266+
['+ 54','0'],
267+
['+ 55','0'],
268+
['+ 56','0'],
269+
['+ 57','0'],
270+
['+ 58','0'],
271+
['+ 59','0'],
272+
['+ 60','0'],
273+
['+ 61','0'],
274+
['+ 62','0'],
275+
['+ 63','0'],
276+
['+ 64','0'],
277+
['+ 65','0'],
278+
['+ 66','0'],
279+
['+ 67','0'],
280+
['+ 68','0'],
281+
['+ 69','0'],
282+
['+ 70','0'],
283+
['+ 71','0'],
284+
['+ 72','0'],
285+
['+ 73','0'],
286+
['+ 74','0'],
287+
['+ 75','0'],
288+
['+ 76','0'],
289+
['+ 77','0'],
290+
['+ 78','0'],
291+
['+ 79','0'],
292+
['+ 80','0'],
293+
['+ 81','0'],
294+
['+ 82','0'],
295+
['+ 83','0'],
296+
['+ 84','0'],
297+
['+ 85','0'],
298+
['+ 86','0'],
299+
['+ 87','0'],
300+
['+ 88','0'],
301+
['+ 89','0'],
302+
['+ 90','0'],
303+
['+ 91','0'],
304+
['+ 92','0'],
305+
['+ 93','0'],
306+
['+ 94','0'],
307+
['+ 95','0'],
308+
['+ 96','0'],
309+
['+ 97','0'],
310+
['+ 98','0'],
311+
['+ 99','0'],
312+
[
313+
'+ Only 100 properties are shown. React will not log more properties of this object.',
314+
'',
315+
],
316+
],
317+
tooltipText: 'App',
318+
track: 'Components ⚛',
319+
},
320+
},
321+
end: 31,
322+
start: 21,
323+
},
324+
],
325+
]);
326+
});
327+
});
0 commit comments
Comments
 (0)