Skip to content

Commit 306a01b

Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary The `credentialless` attribute is a boolean HTML attribute for `<iframe>` elements that loads the iframe in a new, ephemeral context without access to the parent's credentials (cookies, client certificates, etc.). This change adds it to all boolean attribute switch/case lists in React DOM so it is properly handled as a boolean (set when true, removed when false) rather than being treated as an unknown string attribute. Per the [Anonymous iframe spec (WICG)](https://wicg.github.io/anonymous-iframe/): > The credentialless attribute enables loading documents hosted by the iframe with a new and ephemeral storage partition. It is a boolean value. The default is false. ``` partial interface HTMLIFrameElement { attribute boolean credentialless; }; ``` Changes: - ReactDOMComponent.js: Added to both `setProp` and `diffHydratedGenericElement` - ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side rendering - ReactDOMUnknownPropertyHook.js: Added to both validation switch/case lists ## Test plan - Added unit test in DOMPropertyOperations-test.js verifying `credentialless={true}` sets the attribute to `''` and `credentialless={false}` removes it - All tests pass in source and www channels (590 tests each) - Flow type checking passes (dom-node renderer) - Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b

5 files changed

Lines changed: 45 additions & 0 deletions

File tree

‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':

‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':

‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':

‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);

‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add credentialless as a recognized boolean attribute for iframes (#36… · react/react@306a01b · GitHub
Skip to content
Commit 306a01b
Browse files
vmx906vmx906
authored
Add credentialless as a recognized boolean attribute for iframes (#36148)
## Summary
The `credentialless` attribute is a boolean HTML attribute for
`<iframe>` elements that loads the iframe in a new, ephemeral context
without access to the parent's credentials (cookies, client
certificates, etc.). This change adds it to all boolean attribute
switch/case lists in React DOM so it is properly handled as a boolean
(set when true, removed when false) rather than being treated as an
unknown string attribute.
Per the [Anonymous iframe spec
(WICG)](https://wicg.github.io/anonymous-iframe/):
> The credentialless attribute enables loading documents hosted by the
iframe with a new and ephemeral storage partition. It is a boolean
value. The default is false.
```
partial interface HTMLIFrameElement {
attribute boolean credentialless; };
```
Changes:
- ReactDOMComponent.js: Added to both `setProp` and
`diffHydratedGenericElement`
- ReactFizzConfigDOM.js: Added to `pushAttribute` for server-side
rendering
- ReactDOMUnknownPropertyHook.js: Added to both validation switch/case
lists
## Test plan
- Added unit test in DOMPropertyOperations-test.js verifying
`credentialless={true}` sets the attribute to `''` and
`credentialless={false}` removes it
- All tests pass in source and www channels (590 tests each)
- Flow type checking passes (dom-node renderer)
- Prettier and lint pass
1 parent 3ee1fe4 commit 306a01b
5 files changed
Lines changed: 45 additions & 0 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactDOMComponent.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -756,6 +756,7 @@ function setProp(
756756
case'async':
757757
case'autoPlay':
758758
case'controls':
759+
case'credentialless':
759760
case'default':
760761
case'defer':
761762
case'disabled':
@@ -2849,6 +2850,7 @@ function diffHydratedGenericElement(
28492850
case'async':
28502851
case'autoPlay':
28512852
case'controls':
2853+
case'credentialless':
28522854
case'default':
28532855
case'defer':
28542856
case'disabled':
‎packages/react-dom-bindings/src/server/ReactFizzConfigDOM.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1695,6 +1695,7 @@ function pushAttribute(
16951695
case 'async':
16961696
case 'autoPlay':
16971697
case 'controls':
1698+
case 'credentialless':
16981699
case 'default':
16991700
case 'defer':
17001701
case 'disabled':
‎packages/react-dom-bindings/src/shared/ReactDOMUnknownPropertyHook.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
208208
case'async':
209209
case'autoPlay':
210210
case'controls':
211+
case'credentialless':
211212
case'default':
212213
case'defer':
213214
case'disabled':
@@ -287,6 +288,7 @@ function validateProperty(tagName, name, value, eventRegistry) {
287288
case'async':
288289
case'autoPlay':
289290
case'controls':
291+
case'credentialless':
290292
case'default':
291293
case'defer':
292294
case'disabled':
‎packages/react-dom/src/__tests__/DOMPropertyOperations-test.js‎
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,34 @@ describe('DOMPropertyOperations', () => {
160160
expect(container.firstChild.hasAttribute('allowFullScreen')).toBe(false);
161161
});
162162

163+
it('should set credentialless boolean attribute on iframes',async()=>{
164+
constcontainer=document.createElement('div');
165+
constroot=ReactDOMClient.createRoot(container);
166+
awaitact(()=>{
167+
root.render(<iframecredentialless={true}/>);
168+
});
169+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
170+
awaitact(()=>{
171+
root.render(<iframecredentialless={false}/>);
172+
});
173+
expect(container.firstChild.hasAttribute('credentialless')).toBe(false);
174+
});
175+
176+
it('should set credentialless attribute when passed a string and warn',async()=>{
177+
constcontainer=document.createElement('div');
178+
constroot=ReactDOMClient.createRoot(container);
179+
awaitact(()=>{
180+
root.render(<iframecredentialless="true"/>);
181+
});
182+
assertConsoleErrorDev([
183+
'Received the string `true` for the boolean attribute `credentialless`. '+
184+
'Although this works, it will not work as expected if you pass the string "false". '+
185+
'Did you mean credentialless={true}?\n'+
186+
' in iframe (at **)',
187+
]);
188+
expect(container.firstChild.getAttribute('credentialless')).toBe('');
189+
});
190+
163191
it('should remove when setting custom attr to null',async()=>{
164192
constcontainer=document.createElement('div');
165193
constroot=ReactDOMClient.createRoot(container);
‎packages/react-dom/src/__tests__/ReactDOMServerIntegrationAttributes-test.js‎
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,18 @@ describe('ReactDOMServerIntegration', () => {
187187
});
188188
});
189189

190+
describe('credentialless property',function(){
191+
itRenders('credentialless prop with true value',asyncrender=>{
192+
conste=awaitrender(<iframecredentialless={true}/>);
193+
expect(e.getAttribute('credentialless')).toBe('');
194+
});
195+
196+
itRenders('credentialless prop with false value',asyncrender=>{
197+
conste=awaitrender(<iframecredentialless={false}/>);
198+
expect(e.hasAttribute('credentialless')).toBe(false);
199+
});
200+
});
201+
190202
describe('download property (combined boolean/string attribute)',function(){
191203
itRenders('download prop with true value',asyncrender=>{
192204
conste=awaitrender(<adownload={true}/>);
0 commit comments
Comments
 (0)