Skip to content

Commit 58bdc0b

Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that creates a new bound AsyncResource which everything runs inside of. https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67 This resource is itself tracked by our async debug tracking as I/O. We can't really distinguish these in general from other AsyncResources which are I/O. However, by default they're given the name `"bound-anonymous-fn"` if you pass it an anonymous function or in the case of a snapshot, that's built-in: https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263 We can at least assume that these are non-I/O. If you want to ensure that a bound resource is not considered I/O, you can ensure your function isn't assigned a name or give it this explicit name. The other issue here is that, the sequencing here is that we track the callsite of the `.snapshot()` or `.bind()` call as the trigger. So if that was outside of render for example, then it would be considered non-I/O. However, this might miss stuff if you resolve promises inside the `.run()` of the snapshot if the `.run()` call itself was spawned by I/O which should be tracked. Time will tell if those patterns appear. However, in cases like nested renders (e.g. Next.js's "use cache") then restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b

1 file changed

Lines changed: 21 additions & 10 deletions

File tree

‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[Flight] Ignore bound-anonymous-fn resources as they're not considere… · react/react@58bdc0b · GitHub
Skip to content
Commit 58bdc0b
Browse files
sebmarkbagesebmarkbage
authored
[Flight] Ignore bound-anonymous-fn resources as they're not considered I/O (#34911)
When you create a snapshot from an AsyncLocalStorage in Node.js, that
creates a new bound AsyncResource which everything runs inside of.
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/internal/async_local_storage/async_hooks.js#L61-L67
This resource is itself tracked by our async debug tracking as I/O. We
can't really distinguish these in general from other AsyncResources
which are I/O.
However, by default they're given the name `"bound-anonymous-fn"` if you
pass it an anonymous function or in the case of a snapshot, that's
built-in:
https://github.com/nodejs/node/blob/3437e1c4bd529e51d96ea581b6435bbeb77ef524/lib/async_hooks.js#L262-L263
We can at least assume that these are non-I/O. If you want to ensure
that a bound resource is not considered I/O, you can ensure your
function isn't assigned a name or give it this explicit name.
The other issue here is that, the sequencing here is that we track the
callsite of the `.snapshot()` or `.bind()` call as the trigger. So if
that was outside of render for example, then it would be considered
non-I/O. However, this might miss stuff if you resolve promises inside
the `.run()` of the snapshot if the `.run()` call itself was spawned by
I/O which should be tracked. Time will tell if those patterns appear.
However, in cases like nested renders (e.g. Next.js's "use cache") then
restoring it as if it was outside the parent render is what you do want.
1 parent bf11d2f commit 58bdc0b
1 file changed
Lines changed: 21 additions & 10 deletions
File tree
‎packages/react-server/src/ReactFlightServerConfigDebugNode.js‎
Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,28 @@ export function initAsyncDebugInfo(): void {
142142
}: UnresolvedPromiseNode);
143143
}
144144
}elseif(
145-
type!== 'Microtask' &&
146-
type!== 'TickObject' &&
147-
type!== 'Immediate'
145+
// bound-anonymous-fn is the default name for snapshots and .bind() without a name.
146+
// This isn't I/O by itself but likely just a continuation. If the bound function
147+
// has a name, we might treat it as I/O but we can't tell the difference.
148+
type==='bound-anonymous-fn'||
149+
// queueMicroTask, process.nextTick and setImmediate aren't considered new I/O
150+
// for our purposes but just continuation of existing I/O.
151+
type==='Microtask'||
152+
type==='TickObject'||
153+
type==='Immediate'
148154
){
155+
// Treat the trigger as the node to carry along the sequence.
156+
// For "bound-anonymous-fn" this will be the callsite of the .bind() which may not
157+
// be the best if the callsite of the .run() call is within I/O which should be
158+
// tracked. It might be better to track the execution context of "before()" as the
159+
// execution context for anything spawned from within the run(). Basically as if
160+
// it wasn't an AsyncResource at all.
161+
if(trigger===undefined){
162+
return;
163+
}
164+
 node =trigger;
165+
}else{
166+
// New I/O
149167
if(trigger===undefined){
150168
// We have begun a new I/O sequence.
151169
constowner=resolveOwner();
@@ -181,13 +199,6 @@ export function initAsyncDebugInfo(): void {
181199
// Otherwise, this is just a continuation of the same I/O sequence.
182200
node=trigger;
183201
}
184-
}else{
185-
// Ignore nextTick and microtasks as they're not considered I/O operations.
186-
// we just treat the trigger as the node to carry along the sequence.
187-
if(trigger===undefined){
188-
return;
189-
}
190-
node=trigger;
191202
}
192203
pendingOperations.set(asyncId,node);
193204
},
0 commit comments
Comments
 (0)