Skip to content

Commit 71753ac

Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only package for our lint plugin. eslint-plugin-react-compiler will remain as a Meta only package as some limitations of our internal infra require us to use packages that aren't widely adopted by the rest of the industry. This PR removes `hermes-parser`, which was meant to support parsing Flow syntax.
1 parent f24d3bb commit 71753ac

3 files changed

Lines changed: 12 additions & 40 deletions

File tree

‎packages/eslint-plugin-react-hooks/package.json‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
},
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",

‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
sourceCode,
8482
filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){

‎yarn.lock‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
hermes-estree "0.32.0"
1019110191
hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
version "0.25.1"
10195-
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
version "0.29.1"
1020010195
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
dependencies:
1022010215
hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
version "0.25.1"
10224-
resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
dependencies:
10227-
hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
version "1.0.3"
1023110219
resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[eprh] Remove hermes-parser (#34719) · react/react@71753ac · GitHub
Skip to content
Commit 71753ac
Browse files
potetopoteto
authored
[eprh] Remove hermes-parser (#34719)
We will be focusing eslint-plugin-react-hooks as the primary OSS-only
package for our lint plugin. eslint-plugin-react-compiler will remain as
a Meta only package as some limitations of our internal infra require us
to use packages that aren't widely adopted by the rest of the industry.
This PR removes `hermes-parser`, which was meant to support parsing Flow
syntax.
1 parent f24d3bb commit 71753ac
3 files changed
Lines changed: 12 additions & 40 deletions
File tree
‎packages/eslint-plugin-react-hooks/package.json‎
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@
4141
"dependencies": {
4242
"@babel/core": "^7.24.4",
4343
"@babel/parser": "^7.24.4",
44-
"hermes-parser": "^0.25.1",
4544
"zod": "^3.22.4",
4645
"zod-validation-error": "^3.0.3"
4746
 },
@@ -50,14 +49,14 @@
5049
"@babel/preset-typescript": "^7.26.0",
5150
"@babel/types": "^7.19.0",
5251
"@tsconfig/strictest": "^2.0.5",
53-
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
54-
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
55-
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
56-
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
5752
"@types/eslint": "^8.56.12",
5853
"@types/estree": "^1.0.6",
5954
"@types/estree-jsx": "^1.0.5",
6055
"@types/node": "^20.2.5",
56+
"@typescript-eslint/parser-v2": "npm:@typescript-eslint/parser@^2.26.0",
57+
"@typescript-eslint/parser-v3": "npm:@typescript-eslint/parser@^3.10.0",
58+
"@typescript-eslint/parser-v4": "npm:@typescript-eslint/parser@^4.1.0",
59+
"@typescript-eslint/parser-v5": "npm:@typescript-eslint/parser@^5.62.0",
6160
"babel-eslint": "^10.0.3",
6261
"eslint-v7": "npm:eslint@^7.7.0",
6362
"eslint-v8": "npm:eslint@^8.57.1",
‎packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts‎
Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ import BabelPluginReactCompiler, {
1717
LoggerEvent,
1818
}from'babel-plugin-react-compiler';
1919
importtype{SourceCode}from'eslint';
20-
import*asHermesParserfrom'hermes-parser';
2120
import{isDeepStrictEqual}from'util';
2221
importtype{ParseResult}from'@babel/parser';
2322

@@ -78,7 +77,6 @@ function getFlowSuppressions(
7877
returnresults;
7978
}
8079

81-
8280
functionrunReactCompilerImpl({
8381
 sourceCode,
8482
 filename,
@@ -115,27 +113,14 @@ function runReactCompilerImpl({
115113
}
116114

117115
letbabelAST: ParseResult<File>|null=null;
118-
if(filename.endsWith('.tsx')||filename.endsWith('.ts')){
119-
try{
120-
babelAST=babelParse(sourceCode.text,{
121-
sourceFilename: filename,
122-
sourceType: 'unambiguous',
123-
plugins: ['typescript','jsx'],
124-
});
125-
}catch{
126-
/* empty */
127-
}
128-
}else{
129-
try{
130-
babelAST=HermesParser.parse(sourceCode.text,{
131-
babel: true,
132-
enableExperimentalComponentSyntax: true,
133-
sourceFilename: filename,
134-
sourceType: 'module',
135-
});
136-
}catch{
137-
/* empty */
138-
}
116+
try{
117+
babelAST=babelParse(sourceCode.text,{
118+
sourceFilename: filename,
119+
sourceType: 'unambiguous',
120+
plugins: ['typescript','jsx'],
121+
});
122+
}catch(err: unknown){
123+
/* empty */
139124
}
140125

141126
if(babelAST!=null){
‎yarn.lock‎
Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10190,11 +10190,6 @@ hermes-eslint@^0.32.0:
1019010190
 hermes-estree "0.32.0"
1019110191
 hermes-parser "0.32.0"
1019210192

10193-
hermes-estree@0.25.1:
10194-
 version "0.25.1"
10195-
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.25.1.tgz#6aeec17d1983b4eabf69721f3aa3eb705b17f480"
10196-
 integrity sha512-0wUoCcLp+5Ev5pDW2OriHC2MJCbwLwuRx+gAqMTOkGKJJiBCLjtrvy4PWUGn6MIVefecRpzoOZ/UV6iGdOr+Cw==
10197-
1019810193
hermes-estree@0.29.1:
1019910194
 version "0.29.1"
1020010195
 resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.29.1.tgz#043c7db076e0e8ef8c5f6ed23828d1ba463ebcc5"
@@ -10219,13 +10214,6 @@ hermes-parser@0.32.0, hermes-parser@^0.32.0:
1021910214
 dependencies:
1022010215
 hermes-estree "0.32.0"
1022110216

10222-
hermes-parser@^0.25.1:
10223-
 version "0.25.1"
10224-
 resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.25.1.tgz#5be0e487b2090886c62bd8a11724cd766d5f54d1"
10225-
 integrity sha512-6pEjquH3rqaI6cYAXYPcz9MS4rY6R4ngRgrgfDshRptUZIc3lw0MCIJIGDj9++mfySOuPTHB4nrSW99BCvOPIA==
10226-
 dependencies:
10227-
 hermes-estree "0.25.1"
10228-
1022910217
homedir-polyfill@^1.0.0, homedir-polyfill@^1.0.1:
1023010218
 version "1.0.3"
1023110219
 resolved "https://registry.yarnpkg.com/homedir-polyfill/-/homedir-polyfill-1.0.3.tgz#743298cef4e5af3e194161fbadcc2151d3a058e8"
0 commit comments
Comments
 (0)