Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [FlightReply] Type hardening and performance improvements · react/react@795203e · GitHub
Skip to content

Commit 795203e

Browse files
eps1lonunstubbable
andcommitted
[FlightReply] Type hardening and performance improvements
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 23f4f9f commit 795203e

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -580,6 +580,8 @@ module.exports = {
580580
CopyInspectedElementPath: 'readonly',
581581
DOMHighResTimeStamp: 'readonly',
582582
EventListener: 'readonly',
583+
// Flow type
584+
FormDataEntryValue: 'readonly',
583585
Iterable: 'readonly',
584586
AsyncIterable: 'readonly',
585587
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,9 @@ export function processReply(
579579
// Copy all the form fields with a prefix for this reference.
580580
// These must come first in the form order because we assume that all the
581581
// fields are available before this is referenced.
582-
const prefix = formFieldPrefix + refId + '_';
582+
// We include a special marker so that the Server can detect FormData entries
583+
// that are values in referenced FormData objects.
584+
const prefix = formFieldPrefix + '_' + refId + '_';
583585
// $FlowFixMe[prop-missing]: FormData has forEach.
584586
value.forEach((originalValue: string | File, originalKey: string) =>{
585587
// $FlowFixMe[incompatible-call]
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)