Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Current behavior for excluding Component render with unchanged props … · react/react@7b971c0 · GitHub
Skip to content

Commit 7b971c0

Browse files
authored
Current behavior for excluding Component render with unchanged props from Components track (#34822)
If we rerender with the same props, the render time will not be accounted for in the Components track. The attached test reproduces the behavior observed in https://codesandbox.io/p/sandbox/patient-fast-j94f2g: <img width="1118" height="354" alt="CleanShot 2025-10-13 at 00 13 41@2x" src="https://github.com/user-attachments/assets/4be10ee9-d529-4d98-9035-4f26f9587f52" />
1 parent 83ea655 commit 7b971c0

1 file changed

Lines changed: 125 additions & 10 deletions

File tree

‎packages/react-reconciler/src/__tests__/ReactPerformanceTrack-test.js‎

Lines changed: 125 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,20 @@ let act;
1515
letuseEffect;
1616

1717
describe('ReactPerformanceTracks',()=>{
18+
constperformanceMeasureCalls=[];
19+
1820
beforeEach(()=>{
21+
performanceMeasureCalls.length=0;
1922
Object.defineProperty(performance,'measure',{
20-
value: jest.fn(),
23+
value: jest.fn((measureName,reusableOptions)=>{
24+
performanceMeasureCalls.push([
25+
measureName,
26+
{
27+
// React will mutate the options it passes to performance.measure.
28+
...reusableOptions,
29+
},
30+
]);
31+
}),
2132
configurable: true,
2233
});
2334
console.timeStamp=()=>{};
@@ -32,6 +43,19 @@ describe('ReactPerformanceTracks', () => {
3243
useEffect=React.useEffect;
3344
});
3445

46+
functiongetConsoleTimestampEntries(){
47+
try{
48+
returnconsole.timeStamp.mock.calls.filter(call=>{
49+
const[,startTime,endTime]=call;
50+
51+
constisRegisterTrackCall=startTime!==0.003&&endTime!==0.003;
52+
returnisRegisterTrackCall;
53+
});
54+
}finally{
55+
console.timeStamp.mockClear();
56+
}
57+
}
58+
3559
// @gate __DEV__ && enableComponentPerformanceTrack
3660
it('shows a hint if an update is triggered by a deeply equal object',async()=>{
3761
constApp=functionApp({items}){
@@ -45,7 +69,7 @@ describe('ReactPerformanceTracks', () => {
4569
ReactNoop.render(<Appitems={items}/>);
4670
});
4771

48-
expect(performance.measure.mock.calls).toEqual([
72+
expect(performanceMeasureCalls).toEqual([
4973
[
5074
'Mount',
5175
{
@@ -62,14 +86,14 @@ describe('ReactPerformanceTracks', () => {
6286
},
6387
],
6488
]);
65-
performance.measure.mockClear();
89+
performanceMeasureCalls.length=0;
6690

6791
Scheduler.unstable_advanceTime(10);
6892
awaitact(()=>{
6993
ReactNoop.render(<Appitems={items.concat('4')}/>);
7094
});
7195

72-
expect(performance.measure.mock.calls).toEqual([
96+
expect(performanceMeasureCalls).toEqual([
7397
[
7498
'​App',
7599
{
@@ -105,7 +129,7 @@ describe('ReactPerformanceTracks', () => {
105129
ReactNoop.render(<Appitems={items}/>);
106130
});
107131

108-
expect(performance.measure.mock.calls).toEqual([
132+
expect(performanceMeasureCalls).toEqual([
109133
[
110134
'Mount',
111135
{
@@ -122,14 +146,14 @@ describe('ReactPerformanceTracks', () => {
122146
},
123147
],
124148
]);
125-
performance.measure.mockClear();
149+
performanceMeasureCalls.length=0;
126150

127151
Scheduler.unstable_advanceTime(10);
128152
awaitact(()=>{
129153
ReactNoop.render(<Appitems={items.concat('-1')}/>);
130154
});
131155

132-
expect(performance.measure.mock.calls).toEqual([
156+
expect(performanceMeasureCalls).toEqual([
133157
[
134158
'​App',
135159
{
@@ -171,7 +195,7 @@ describe('ReactPerformanceTracks', () => {
171195
ReactNoop.render(<Appdata={{buffer: null}}/>);
172196
});
173197

174-
expect(performance.measure.mock.calls).toEqual([
198+
expect(performanceMeasureCalls).toEqual([
175199
[
176200
'Mount',
177201
{
@@ -188,7 +212,7 @@ describe('ReactPerformanceTracks', () => {
188212
},
189213
],
190214
]);
191-
performance.measure.mockClear();
215+
performanceMeasureCalls.length=0;
192216

193217
Scheduler.unstable_advanceTime(10);
194218

@@ -197,7 +221,7 @@ describe('ReactPerformanceTracks', () => {
197221
ReactNoop.render(<Appdata={{buffer: bigData}}/>);
198222
});
199223

200-
expect(performance.measure.mock.calls).toEqual([
224+
expect(performanceMeasureCalls).toEqual([
201225
[
202226
'​App',
203227
{
@@ -324,4 +348,95 @@ describe('ReactPerformanceTracks', () => {
324348
],
325349
]);
326350
});
351+
352+
// @gate __DEV__ && enableComponentPerformanceTrack
353+
it('includes spans for Components with no prop changes',async()=>{
354+
functionLeft({value}){
355+
Scheduler.unstable_advanceTime(5000);
356+
}
357+
functionRight(){
358+
Scheduler.unstable_advanceTime(10000);
359+
}
360+
361+
awaitact(()=>{
362+
ReactNoop.render(
363+
<>
364+
<Leftvalue={1}/>
365+
<Right/>
366+
</>,
367+
);
368+
});
369+
370+
expect(performanceMeasureCalls).toEqual([
371+
[
372+
'Mount',
373+
{
374+
detail: {
375+
devtools: {
376+
color: 'warning',
377+
properties: null,
378+
tooltipText: 'Mount',
379+
track: 'Components ⚛',
380+
},
381+
},
382+
end: 5000,
383+
start: 0,
384+
},
385+
],
386+
[
387+
'Mount',
388+
{
389+
detail: {
390+
devtools: {
391+
color: 'warning',
392+
properties: null,
393+
tooltipText: 'Mount',
394+
track: 'Components ⚛',
395+
},
396+
},
397+
end: 15000,
398+
start: 5000,
399+
},
400+
],
401+
]);
402+
performanceMeasureCalls.length=0;
403+
getConsoleTimestampEntries();
404+
405+
Scheduler.unstable_advanceTime(1000);
406+
407+
awaitact(()=>{
408+
ReactNoop.render(
409+
<>
410+
<Leftvalue={2}/>
411+
<Right/>
412+
</>,
413+
);
414+
});
415+
416+
expect(performanceMeasureCalls).toEqual([
417+
[
418+
'​Left',
419+
{
420+
detail: {
421+
devtools: {
422+
color: 'error',
423+
properties: [
424+
['Changed Props',''],
425+
['– value','1'],
426+
['+ value','2'],
427+
],
428+
tooltipText: 'Left',
429+
track: 'Components ⚛',
430+
},
431+
},
432+
end: 21000,
433+
start: 16000,
434+
},
435+
],
436+
]);
437+
expect(getConsoleTimestampEntries()).toEqual([
438+
['Render',16000,31000,'Blocking','Scheduler ⚛','primary-dark'],
439+
]);
440+
performanceMeasureCalls.length=0;
441+
});
327442
});

0 commit comments

Comments
 (0)