Skip to content

Commit 90817f8

Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing the legacy React Native renderers. In this diff, I just stop syncing them. In a follow up I'll delete the code for them so only Fabric is left. This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8

5 files changed

Lines changed: 8 additions & 39 deletions

File tree

‎.github/workflows/runtime_commit_artifacts.yml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
# Delete OSS renderer. OSS renderer is synced through internal script.
165+
# Delete the OSS renderers, these are sync'd to RN separately.
166166
RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
# Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
rm $SHIM_FOLDER/ReactNative.js
169172
170173
# Copy eslint-plugin-react-hooks
171174
# NOTE: This is different from www, here we include the full package

‎packages/react-native-renderer/index.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';

‎packages/react-reconciler/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎

Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
? []
826-
: [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__

‎scripts/rollup/shims/react-native/ReactNative.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[rn] delete the legacy renderers from the sync (#34946) · react/react@90817f8 · GitHub
Skip to content
Commit 90817f8
Browse files
rickhanloniirickhanlonii
authored
[rn] delete the legacy renderers from the sync (#34946)
Now that RN is only on the New Architecture, we can stop stop syncing
the legacy React Native renderers.
In this diff, I just stop syncing them. In a follow up I'll delete the
code for them so only Fabric is left.
This will also allow us to remove the `enableLegacyMode` feature flag.
1 parent 0d721b6 commit 90817f8
5 files changed
Lines changed: 8 additions & 39 deletions
File tree
‎.github/workflows/runtime_commit_artifacts.yml‎
Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,10 +162,13 @@ jobs:
162162
 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
163163
 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
164164
165-
 # Delete OSS renderer. OSS renderer is synced through internal script.
165+
 # Delete the OSS renderers, these are sync'd to RN separately.
166166
 RENDERER_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/implementations/
167+
 SHIM_FOLDER=$BASE_FOLDER/react-native-github/Libraries/Renderer/shims/
167168
 rm $RENDERER_FOLDER/ReactFabric-{dev,prod,profiling}.js
168-
 rm $RENDERER_FOLDER/ReactNativeRenderer-{dev,prod,profiling}.js
169+
170+
 # Delete the legacy renderer shim, this is not sync'd and will get deleted in the future.
171+
 rm $SHIM_FOLDER/ReactNative.js
169172
170173
 # Copy eslint-plugin-react-hooks
171174
 # NOTE: This is different from www, here we include the full package
‎packages/react-native-renderer/index.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,5 @@ import * as ReactNative from './src/ReactNativeRenderer';
1212
// Assert that the exports line up with the type we're going to expose.
1313
(ReactNative: ReactNativeType);
1414

15+
// TODO: Delete the legacy renderer, only Fabric is used now.
1516
export*from'./src/ReactNativeRenderer';
‎packages/react-reconciler/README.md‎
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The examples in the React repository are declared a bit differently than a third
5959

6060
*[React ART](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactART.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-art/src/ReactFiberConfigART.js)
6161
*[React DOM](https://github.com/facebook/react/blob/main/packages/react-dom/src/client/ReactDOM.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js)
62-
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactNativeRenderer.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigNative.js)
62+
*[React Native](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFabric.js) and its [host config](https://github.com/facebook/react/blob/main/packages/react-native-renderer/src/ReactFiberConfigFabric.js)
6363

6464
If these links break please file an issue and we’ll fix them. They intentionally link to the latest versions since the API is still evolving. If you have more questions please file an issue and we’ll try to help!
6565

‎scripts/rollup/bundles.js‎
Lines changed: 0 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -819,42 +819,6 @@ const bundles = [
819819
}),
820820
},
821821

822-
/******* React Native *******/
823-
{
824-
bundleTypes: __EXPERIMENTAL__
825-
 ? []
826-
 : [RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING],
827-
moduleType: RENDERER,
828-
entry: 'react-native-renderer',
829-
global: 'ReactNativeRenderer',
830-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
831-
minifyWithProdErrorCodes: false,
832-
wrapWithModuleBoundaries: true,
833-
babel: opts=>
834-
Object.assign({},opts,{
835-
plugins: opts.plugins.concat([
836-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
837-
]),
838-
}),
839-
},
840-
{
841-
bundleTypes: [RN_OSS_DEV,RN_OSS_PROD,RN_OSS_PROFILING],
842-
moduleType: RENDERER,
843-
entry: 'react-native-renderer',
844-
global: 'ReactNativeRenderer',
845-
// ReactNativeInternalFeatureFlags temporary until we land enableRemoveConsolePatches.
846-
// Needs to be done before the next RN OSS release.
847-
externals: ['react-native','ReactNativeInternalFeatureFlags'],
848-
minifyWithProdErrorCodes: false,
849-
wrapWithModuleBoundaries: true,
850-
babel: opts=>
851-
Object.assign({},opts,{
852-
plugins: opts.plugins.concat([
853-
[require.resolve('@babel/plugin-transform-classes'),{loose: true}],
854-
]),
855-
}),
856-
},
857-
858822
/******* React Native Fabric *******/
859823
{
860824
bundleTypes: __EXPERIMENTAL__
‎scripts/rollup/shims/react-native/ReactNative.js‎
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import type {ReactNativeType} from './ReactNativeTypes';
1414

1515
let ReactNative: ReactNativeType;
1616

17+
// TODO: Delete the legacy renderer. Only ReactFabric is used now.
1718
if(__DEV__){
1819
ReactNative=require('../implementations/ReactNativeRenderer-dev');
1920
}else{
0 commit comments
Comments
 (0)