Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [flags] cleanup renameElementSymbol (#35600) · react/react@94913cb · GitHub
Skip to content

Commit 94913cb

Browse files
authored
[flags] cleanup renameElementSymbol (#35600)
Removed the feature flag completely, enabled by default. Will land once I have everything ready on xplat side.
1 parent 2d8e7f1 commit 94913cb

14 files changed

Lines changed: 4 additions & 22 deletions

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1085,7 +1085,6 @@ describe('ReactFlight', () => {
10851085
});
10861086
});
10871087

1088-
// @gate renameElementSymbol
10891088
it('should emit descriptions of errors in dev',async()=>{
10901089
constClientErrorBoundary=clientReference(ErrorBoundary);
10911090

‎packages/react-dom/src/__tests__/ReactComponent-test.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -498,7 +498,6 @@ describe('ReactComponent', () => {
498498
);
499499
});
500500

501-
// @gate renameElementSymbol
502501
it('throws if a legacy element is used as a child',async()=>{
503502
constinlinedElement={
504503
$$typeof: Symbol.for('react.element'),

‎packages/react-dom/src/__tests__/ReactDOMOption-test.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,12 +138,11 @@ describe('ReactDOMOption', () => {
138138
}).rejects.toThrow('Objects are not valid as a React child');
139139
});
140140

141-
// @gate www && !renameElementSymbol
142141
it('should support element-ish child',async()=>{
143142
// This is similar to <fbt>.
144143
// We don't toString it because you must instead provide a value prop.
145144
constobj={
146-
$$typeof: Symbol.for('react.element'),
145+
$$typeof: Symbol.for('react.transitional.element'),
147146
type: props=>props.content,
148147
ref: null,
149148
key: null,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,6 @@ export const enableInternalInstanceMap: boolean = false;
159159

160160
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
161161

162-
// Renames the internal symbol for elements since they have changed signature/constructor
163-
exportconstrenameElementSymbol: boolean=true;
164-
165162
/**
166163
* Enables a fix to run insertion effect cleanup on hidden subtrees.
167164
*/

‎packages/shared/ReactSymbols.js‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,15 @@
77
* @flow
88
*/
99

10-
import{renameElementSymbol}from'shared/ReactFeatureFlags';
11-
1210
// ATTENTION
1311
// When adding new symbols to this file,
1412
// Please consider also adding to 'react-devtools-shared/src/backend/ReactSymbols'
1513

1614
// The Symbol used to tag the ReactElement-like types.
1715
exportconstREACT_LEGACY_ELEMENT_TYPE: symbol=Symbol.for('react.element');
18-
exportconstREACT_ELEMENT_TYPE: symbol=renameElementSymbol
19-
? Symbol.for('react.transitional.element')
20-
: REACT_LEGACY_ELEMENT_TYPE;
16+
exportconstREACT_ELEMENT_TYPE: symbol=Symbol.for(
17+
'react.transitional.element',
18+
);
2119
exportconstREACT_PORTAL_TYPE: symbol=Symbol.for('react.portal');
2220
exportconstREACT_FRAGMENT_TYPE: symbol=Symbol.for('react.fragment');
2321
exportconstREACT_STRICT_MODE_TYPE: symbol=Symbol.for('react.strict_mode');

‎packages/shared/__tests__/ReactSymbols-test.internal.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ describe('ReactSymbols', () => {
2323
});
2424
};
2525

26-
// @gate renameElementSymbol
2726
it('Symbol values should be unique',()=>{
2827
expectToBeUnique(Object.entries(require('shared/ReactSymbols')));
2928
});

‎packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ export const enableObjectFiber = __VARIANT__;
2222
exportconstenableHiddenSubtreeInsertionEffectCleanup=__VARIANT__;
2323
exportconstenableEagerAlternateStateNodeCleanup=__VARIANT__;
2424
exportconstpassChildrenWhenCloningPersistedNodes=__VARIANT__;
25-
exportconstrenameElementSymbol=__VARIANT__;
2625
exportconstenableFragmentRefs=__VARIANT__;
2726
exportconstenableFragmentRefsScrollIntoView=__VARIANT__;
2827
exportconstenableFragmentRefsInstanceHandles=__VARIANT__;

‎packages/shared/forks/ReactFeatureFlags.native-fb.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export const {
2424
enableObjectFiber,
2525
enableEagerAlternateStateNodeCleanup,
2626
passChildrenWhenCloningPersistedNodes,
27-
renameElementSymbol,
2827
enableFragmentRefs,
2928
enableFragmentRefsScrollIntoView,
3029
enableFragmentRefsInstanceHandles,

‎packages/shared/forks/ReactFeatureFlags.native-oss.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const enableTaint: boolean = true;
5252
exportconstenableTransitionTracing: boolean=false;
5353
exportconstenableTrustedTypesIntegration: boolean=false;
5454
exportconstpassChildrenWhenCloningPersistedNodes: boolean=false;
55-
exportconstrenameElementSymbol: boolean=true;
5655
exportconstretryLaneExpirationMs=5000;
5756
exportconstsyncLaneExpirationMs=250;
5857
exportconsttransitionLaneExpirationMs=5000;

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ export const disableClientCache: boolean = true;
5555

5656
exportconstenableInfiniteRenderLoopDetection: boolean=false;
5757

58-
exportconstrenameElementSymbol: boolean=true;
5958
exportconstenableEagerAlternateStateNodeCleanup: boolean=true;
6059

6160
exportconstenableYieldingBeforePassive: boolean=true;

0 commit comments

Comments
 (0)