Skip to content

Commit 9c0323e

Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced `unstable_reactFragments` handle on DOM nodes to enable caching of Observers. This has been tested in production and is stable so it can be rolled out with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e

3 files changed

Lines changed: 21 additions & 29 deletions

File tree

‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}

‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];

‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
instance.unstable_reactFragments.add(fragmentInstance);
862+
instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
instance,
925925
): any): PublicInstanceWithFragmentHandles);
926926
if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Stabilize reactFragments host node handle (#35642) · react/react@9c0323e · GitHub
Skip to content
Commit 9c0323e
Browse files
jackpopejackpope
authored
Stabilize reactFragments host node handle (#35642)
#34935 Introduced
`unstable_reactFragments` handle on DOM nodes to enable caching of
Observers.
This has been tested in production and is stable so it can be rolled out
with the Fragment Refs feature.
1 parent e6f1c33 commit 9c0323e
3 files changed
Lines changed: 21 additions & 29 deletions
File tree
‎packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ export type Instance = Element;
218218
exporttypeTextInstance=Text;
219219

220220
typeInstanceWithFragmentHandles=Instance&{
221-
unstable_reactFragments?: Set<FragmentInstanceType>,
221+
reactFragments?: Set<FragmentInstanceType>,
222222
};
223223

224224
declareclassActivityInterfaceextendsComment{}
@@ -3578,10 +3578,10 @@ function addFragmentHandleToInstance(
35783578
fragmentInstance: FragmentInstanceType,
35793579
): void{
35803580
if(enableFragmentRefsInstanceHandles){
3581-
if(instance.unstable_reactFragments==null){
3582-
instance.unstable_reactFragments=newSet();
3581+
if(instance.reactFragments==null){
3582+
instance.reactFragments=newSet();
35833583
}
3584-
instance.unstable_reactFragments.add(fragmentInstance);
3584+
instance.reactFragments.add(fragmentInstance);
35853585
}
35863586
}
35873587

@@ -3647,8 +3647,8 @@ export function deleteChildFromFragmentInstance(
36473647
}
36483648
}
36493649
if(enableFragmentRefsInstanceHandles){
3650-
if(instance.unstable_reactFragments!=null){
3651-
instance.unstable_reactFragments.delete(fragmentInstance);
3650+
if(instance.reactFragments!=null){
3651+
instance.reactFragments.delete(fragmentInstance);
36523652
}
36533653
}
36543654
}
‎packages/react-dom/src/__tests__/ReactDOMFragmentRefs-test.js‎
Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,18 @@ describe('FragmentRefs', () => {
137137
constchildB=document.querySelector('#childB');
138138
constchildC=document.querySelector('#childC');
139139

140-
expect(childA.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
141-
expect(childB.unstable_reactFragments.has(fragmentRef.current)).toBe(true);
142-
expect(childC.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
143-
expect(childA.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
144-
true,
145-
);
146-
expect(childB.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
147-
true,
148-
);
149-
expect(childC.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
150-
true,
151-
);
140+
expect(childA.reactFragments.has(fragmentRef.current)).toBe(true);
141+
expect(childB.reactFragments.has(fragmentRef.current)).toBe(true);
142+
expect(childC.reactFragments.has(fragmentRef.current)).toBe(false);
143+
expect(childA.reactFragments.has(fragmentParentRef.current)).toBe(true);
144+
expect(childB.reactFragments.has(fragmentParentRef.current)).toBe(true);
145+
expect(childC.reactFragments.has(fragmentParentRef.current)).toBe(true);
152146

153147
awaitact(()=>root.render(<Testshow={true}/>));
154148

155149
constchildD=document.querySelector('#childD');
156-
expect(childD.unstable_reactFragments.has(fragmentRef.current)).toBe(false);
157-
expect(childD.unstable_reactFragments.has(fragmentParentRef.current)).toBe(
158-
true,
159-
);
150+
expect(childD.reactFragments.has(fragmentRef.current)).toBe(false);
151+
expect(childD.reactFragments.has(fragmentParentRef.current)).toBe(true);
160152
});
161153

162154
describe('focus methods',()=>{
@@ -1104,7 +1096,7 @@ describe('FragmentRefs', () => {
11041096
}
11051097
constobserver=newIntersectionObserver(entries=>{
11061098
entries.forEach(entry=>{
1107-
constfragmentInstances=entry.target.unstable_reactFragments;
1099+
constfragmentInstances=entry.target.reactFragments;
11081100
if(fragmentInstances){
11091101
Array.from(fragmentInstances).forEach(fInstance=>{
11101102
constcbs=targetToCallbackMap.get(fInstance)||[];
‎packages/react-native-renderer/src/ReactFiberConfigFabric.js‎
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export type TextInstance = {
124124
exporttypeHydratableInstance=Instance|TextInstance;
125125
exporttypePublicInstance=ReactNativePublicInstance;
126126
typePublicInstanceWithFragmentHandles=PublicInstance&{
127-
unstable_reactFragments?: Set<FragmentInstanceType>,
127+
reactFragments?: Set<FragmentInstanceType>,
128128
};
129129
exporttypeContainer={
130130
containerTag: number,
@@ -856,10 +856,10 @@ function addFragmentHandleToInstance(
856856
fragmentInstance: FragmentInstanceType,
857857
): void{
858858
if(enableFragmentRefsInstanceHandles){
859-
if(instance.unstable_reactFragments==null){
860-
instance.unstable_reactFragments=newSet();
859+
if(instance.reactFragments==null){
860+
instance.reactFragments=newSet();
861861
}
862-
 instance.unstable_reactFragments.add(fragmentInstance);
862+
 instance.reactFragments.add(fragmentInstance);
863863
}
864864
}
865865

@@ -924,8 +924,8 @@ export function deleteChildFromFragmentInstance(
924924
 instance,
925925
 ): any): PublicInstanceWithFragmentHandles);
926926
 if (enableFragmentRefsInstanceHandles) {
927-
if(publicInstance.unstable_reactFragments!=null){
928-
publicInstance.unstable_reactFragments.delete(fragmentInstance);
927+
if(publicInstance.reactFragments!=null){
928+
publicInstance.reactFragments.delete(fragmentInstance);
929929
}
930930
}
931931
}
0 commit comments
Comments
 (0)