Skip to content

Commit a48e9e3

Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary This fixes the semantics of the `timeStamp` property of events in React Native. Currently, most events just assign `Date.now()` (at the time of creating the event object in JavaScript) as the `timeStamp` property. This is a divergence with Web and most native platforms, that use a monotonic timestamp for the value (on Web, the same timestamp provided by `performance.now()`). Additionally, many native events specify a timestamp in the event data object as `timestamp` and gets ignored by the logic in JS as it only looks at properties named `timeStamp` specifically (camel case). This PR fixes both issues by: 1. Using `performance.now()` instead of `Date.now()` by default (if available). 2. Checking for a `timestamp` property before falling back to the default (apart from `timeStamp`). ## How did you test this change? Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3

2 files changed

Lines changed: 148 additions & 1 deletion

File tree

‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎

Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},

‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
* @interface Event
1631
* @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912) · react/react@a48e9e3 · GitHub
Skip to content
Commit a48e9e3
Browse files
rubennorterubennorte
authored
[RN] Fix timeStamp property of SyntheticEvent in React Native (#35912)
## Summary
This fixes the semantics of the `timeStamp` property of events in React
Native.
Currently, most events just assign `Date.now()` (at the time of creating
the event object in JavaScript) as the `timeStamp` property. This is a
divergence with Web and most native platforms, that use a monotonic
timestamp for the value (on Web, the same timestamp provided by
`performance.now()`).
Additionally, many native events specify a timestamp in the event data
object as `timestamp` and gets ignored by the logic in JS as it only
looks at properties named `timeStamp` specifically (camel case).
This PR fixes both issues by:
1. Using `performance.now()` instead of `Date.now()` by default (if
available).
2. Checking for a `timestamp` property before falling back to the
default (apart from `timeStamp`).
## How did you test this change?
Added unit tests for verify the new behavior.
1 parent 074d96b commit a48e9e3
2 files changed
Lines changed: 148 additions & 1 deletion
File tree
‎packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js‎
Lines changed: 132 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,6 +1153,138 @@ describe('ReactFabric', () => {
11531153
expect.assertions(6);
11541154
});
11551155

1156+
it('propagates timeStamps from native events and sets defaults',async()=>{
1157+
constView=createReactNativeComponentClass('RCTView',()=>({
1158+
validAttributes: {
1159+
id: true,
1160+
},
1161+
uiViewClassName: 'RCTView',
1162+
directEventTypes: {
1163+
topTouchStart: {
1164+
registrationName: 'onTouchStart',
1165+
},
1166+
topTouchEnd: {
1167+
registrationName: 'onTouchEnd',
1168+
},
1169+
},
1170+
}));
1171+
1172+
functiongetViewById(id){
1173+
const[reactTag,,,,instanceHandle]=
1174+
nativeFabricUIManager.createNode.mock.calls.find(
1175+
args=>args[3]&&args[3].id===id,
1176+
);
1177+
1178+
return{reactTag, instanceHandle};
1179+
}
1180+
1181+
constref1=React.createRef();
1182+
constref2=React.createRef();
1183+
constref3=React.createRef();
1184+
1185+
constexplicitTimeStampCamelCase='explicit-timestamp-camelcase';
1186+
constexplicitTimeStampLowerCase='explicit-timestamp-lowercase';
1187+
constperformanceNowValue='performance-now-timestamp';
1188+
1189+
jest.spyOn(performance,'now').mockReturnValue(performanceNowValue);
1190+
1191+
awaitact(()=>{
1192+
ReactFabric.render(
1193+
<>
1194+
<View
1195+
ref={ref1}
1196+
id="default"
1197+
onTouchEnd={event=>{
1198+
expect(event.timeStamp).toBe(performanceNowValue);
1199+
}}
1200+
/>
1201+
<View
1202+
ref={ref2}
1203+
id="explicitTimeStampCamelCase"
1204+
onTouchEnd={event=>{
1205+
expect(event.timeStamp).toBe(explicitTimeStampCamelCase);
1206+
}}
1207+
/>
1208+
<View
1209+
ref={ref2}
1210+
id="explicitTimeStampLowerCase"
1211+
onTouchEnd={event=>{
1212+
expect(event.timeStamp).toBe(explicitTimeStampLowerCase);
1213+
}}
1214+
/>
1215+
</>,
1216+
1,
1217+
null,
1218+
true,
1219+
);
1220+
});
1221+
1222+
const[dispatchEvent]=
1223+
nativeFabricUIManager.registerEventHandler.mock.calls[0];
1224+
1225+
dispatchEvent(getViewById('default').instanceHandle,'topTouchStart',{
1226+
target: getViewById('default').reactTag,
1227+
identifier: 17,
1228+
touches: [],
1229+
changedTouches: [],
1230+
});
1231+
dispatchEvent(getViewById('default').instanceHandle,'topTouchEnd',{
1232+
target: getViewById('default').reactTag,
1233+
identifier: 17,
1234+
touches: [],
1235+
changedTouches: [],
1236+
// No timeStamp property
1237+
});
1238+
1239+
dispatchEvent(
1240+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1241+
'topTouchStart',
1242+
{
1243+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1244+
identifier: 17,
1245+
touches: [],
1246+
changedTouches: [],
1247+
},
1248+
);
1249+
1250+
dispatchEvent(
1251+
getViewById('explicitTimeStampCamelCase').instanceHandle,
1252+
'topTouchEnd',
1253+
{
1254+
target: getViewById('explicitTimeStampCamelCase').reactTag,
1255+
identifier: 17,
1256+
touches: [],
1257+
changedTouches: [],
1258+
timeStamp: explicitTimeStampCamelCase,
1259+
},
1260+
);
1261+
1262+
dispatchEvent(
1263+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1264+
'topTouchStart',
1265+
{
1266+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1267+
identifier: 17,
1268+
touches: [],
1269+
changedTouches: [],
1270+
},
1271+
);
1272+
1273+
dispatchEvent(
1274+
getViewById('explicitTimeStampLowerCase').instanceHandle,
1275+
'topTouchEnd',
1276+
{
1277+
target: getViewById('explicitTimeStampLowerCase').reactTag,
1278+
identifier: 17,
1279+
touches: [],
1280+
changedTouches: [],
1281+
timestamp: explicitTimeStampLowerCase,
1282+
},
1283+
);
1284+
1285+
expect.assertions(3);
1286+
});
1287+
11561288
it('findHostInstance_DEPRECATED should warn if used to find a host component inside StrictMode',async()=>{
11571289
constView=createReactNativeComponentClass('RCTView',()=>({
11581290
validAttributes: {foo: true},
‎packages/react-native-renderer/src/legacy-events/SyntheticEvent.js‎
Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,21 @@ import assign from 'shared/assign';
1111

1212
constEVENT_POOL_SIZE=10;
1313

14+
letcurrentTimeStamp=()=>{
15+
// Lazily define the function based on the existence of performance.now()
16+
if(
17+
typeofperformance==='object'&&
18+
performance!==null&&
19+
typeofperformance.now==='function'
20+
){
21+
currentTimeStamp=()=>performance.now();
22+
}else{
23+
currentTimeStamp=()=>Date.now();
24+
}
25+
26+
returncurrentTimeStamp();
27+
};
28+
1429
/**
1530
 * @interface Event
1631
 * @see http://www.w3.org/TR/DOM-Level-3-Events/
@@ -26,7 +41,7 @@ const EventInterface = {
2641
bubbles: null,
2742
cancelable: null,
2843
timeStamp: function(event){
29-
returnevent.timeStamp||Date.now();
44+
returnevent.timeStamp||event.timestamp||currentTimeStamp();
3045
},
3146
defaultPrevented: null,
3247
isTrusted: null,
0 commit comments
Comments
 (0)