Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Disable enablePostpone flag in experimental (#31042) · react/react@c308cb5 · GitHub
Skip to content

Commit c308cb5

Browse files
authored
Disable enablePostpone flag in experimental (#31042)
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage. The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and `use()` because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's `use()` and not just throwing a Promise. This might also affect the Catch proposal. The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the `React.postpone()` API for creating the holes.
1 parent 986323f commit c308cb5

7 files changed

Lines changed: 1 addition & 75 deletions

File tree

‎packages/react-dom/src/__tests__/ReactDOMFizzStatic-test.js‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -400,72 +400,6 @@ describe('ReactDOMFizzStatic', () => {
400400
);
401401
});
402402

403-
// @gate enablePostpone
404-
it('does not fatally error when aborting with a postpone during a prerender',async()=>{
405-
letpostponedValue;
406-
try{
407-
React.unstable_postpone('aborting with postpone');
408-
}catch(e){
409-
postponedValue=e;
410-
}
411-
412-
constcontroller=newAbortController();
413-
constinfinitePromise=newPromise(()=>{});
414-
functionApp(){
415-
React.use(infinitePromise);
416-
return<div>aborted</div>;
417-
}
418-
419-
consterrors=[];
420-
constpendingResult=ReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
421-
onError: error=>{
422-
errors.push(error);
423-
},
424-
signal: controller.signal,
425-
});
426-
pendingResult.catch(()=>{});
427-
428-
awaitPromise.resolve();
429-
controller.abort(postponedValue);
430-
431-
constresult=awaitpendingResult;
432-
433-
awaitact(async()=>{
434-
result.prelude.pipe(writable);
435-
});
436-
expect(getVisibleChildren(container)).toEqual(undefined);
437-
expect(errors).toEqual([]);
438-
});
439-
440-
// @gate enablePostpone
441-
it('does not fatally error when aborting with a postpone during a prerender from within',async()=>{
442-
letpostponedValue;
443-
try{
444-
React.unstable_postpone('aborting with postpone');
445-
}catch(e){
446-
postponedValue=e;
447-
}
448-
449-
constcontroller=newAbortController();
450-
functionApp(){
451-
controller.abort(postponedValue);
452-
return<div>aborted</div>;
453-
}
454-
455-
consterrors=[];
456-
constresult=awaitReactDOMFizzStatic.prerenderToNodeStream(<App/>,{
457-
onError: error=>{
458-
errors.push(error);
459-
},
460-
signal: controller.signal,
461-
});
462-
awaitact(async()=>{
463-
result.prelude.pipe(writable);
464-
});
465-
expect(getVisibleChildren(container)).toEqual(undefined);
466-
expect(errors).toEqual([]);
467-
});
468-
469403
// @gate enableHalt
470404
it('will halt a prerender when aborting with an error during a render',async()=>{
471405
constcontroller=newAbortController();

‎packages/react/index.experimental.development.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ export {
3030
cacheSignal,
3131
startTransition,
3232
Activity,
33-
unstable_postpone,
3433
unstable_getCacheForType,
3534
unstable_SuspenseList,
3635
ViewTransition,

‎packages/react/index.experimental.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export {
3131
startTransition,
3232
Activity,
3333
Activityasunstable_Activity,
34-
unstable_postpone,
3534
unstable_getCacheForType,
3635
unstable_SuspenseList,
3736
ViewTransition,

‎packages/react/src/ReactClient.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ import {lazy} from './ReactLazy';
3434
import{forwardRef}from'./ReactForwardRef';
3535
import{memo}from'./ReactMemo';
3636
import{cache,cacheSignal}from'./ReactCacheClient';
37-
import{postpone}from'./ReactPostpone';
3837
import{
3938
getCacheForType,
4039
useCallback,
@@ -84,7 +83,6 @@ export {
8483
memo,
8584
cache,
8685
cacheSignal,
87-
postponeasunstable_postpone,
8886
useCallback,
8987
useContext,
9088
useEffect,

‎packages/react/src/ReactServer.experimental.development.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
import{captureOwnerStack}from'./ReactOwnerStack';
4342
importversionfrom'shared/ReactVersion';
4443

@@ -76,7 +75,6 @@ export {
7675
cacheSignal,
7776
startTransition,
7877
getCacheForTypeasunstable_getCacheForType,
79-
postponeasunstable_postpone,
8078
useId,
8179
useCallback,
8280
useDebugValue,

‎packages/react/src/ReactServer.experimental.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ import {lazy} from './ReactLazy';
3838
import{memo}from'./ReactMemo';
3939
import{cache,cacheSignal}from'./ReactCacheServer';
4040
import{startTransition}from'./ReactStartTransition';
41-
import{postpone}from'./ReactPostpone';
4241
importversionfrom'shared/ReactVersion';
4342

4443
constChildren={
@@ -75,7 +74,6 @@ export {
7574
cacheSignal,
7675
startTransition,
7776
getCacheForTypeasunstable_getCacheForType,
78-
postponeasunstable_postpone,
7977
useId,
8078
useCallback,
8179
useDebugValue,

‎packages/shared/ReactFeatureFlags.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableAsyncIterableChildren = __EXPERIMENTAL__;
8080

8181
exportconstenableTaint=__EXPERIMENTAL__;
8282

83-
exportconstenablePostpone=__EXPERIMENTAL__;
83+
exportconstenablePostpone: boolean=false;// Probably won't ship in this form.
8484

8585
exportconstenableHalt: boolean=true;
8686

0 commit comments

Comments
 (0)