Commit dd45307

Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307

6 files changed

Lines changed: 214 additions & 42 deletions

File tree

‎.eslintrc.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',

‎flow-typed/environments/bom.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
// Copy all the form fields with a prefix for this reference.
599599
// These must come first in the form order because we assume that all the
600600
// fields are available before this is referenced.
601-
const prefix = formFieldPrefix + refId + '_';
601+
// We include a special marker so that the Server can detect FormData entries
602+
// that are values in referenced FormData objects.
603+
const prefix = formFieldPrefix + '_' + refId + '_';
602604
// $FlowFixMe[prop-missing]: FormData has forEach.
603605
value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]

‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎

Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
/**
11+
* Backing FormData is a wrapper around FormData that allows iterating over the
12+
* keys while allowing to evict values from the FormData without affecting the iteration.
13+
* Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
* ```js
15+
* const formData = new FormData();
16+
* formData.append('a', new Blob());
17+
* formData.append('b', 2);
18+
* const keys = formData.keys();
19+
* keys.next().value; // 'a'
20+
* formData.delete('a');
21+
* keys.next().value; // undefined, but we expect 'b'
22+
* ```
23+
*/
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Commit dd45307
Browse files
eps1lonunstubbable
eps1lon
and
unstubbable
authored
[FlightReply] Type hardening and performance improvements (#36425)
Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de>
1 parent 9635257 commit dd45307
6 files changed
Lines changed: 214 additions & 42 deletions
File tree
‎.eslintrc.js‎
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,8 @@ module.exports = {
582582
CopyInspectedElementPath: 'readonly',
583583
DOMHighResTimeStamp: 'readonly',
584584
EventListener: 'readonly',
585+
// Flow type
586+
FormDataEntryValue: 'readonly',
585587
Iterable: 'readonly',
586588
AsyncIterable: 'readonly',
587589
$AsyncIterable: 'readonly',
‎flow-typed/environments/bom.js‎
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,11 +682,11 @@ declare class FormData {
682682
get(name: string): ?FormDataEntryValue;
683683
getAll(name: string): Array<FormDataEntryValue>;
684684

685-
set(name: string,value: string): void;
685+
set(name: string,value: FormDataEntryValue): void;
686686
set(name: string,value: Blob,filename?: string): void;
687687
set(name: string,value: File,filename?: string): void;
688688

689-
append(name: string,value: string): void;
689+
append(name: string,value: FormDataEntryValue): void;
690690
append(name: string,value: Blob,filename?: string): void;
691691
append(name: string,value: File,filename?: string): void;
692692

‎packages/react-client/src/ReactFlightReplyClient.js‎
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,9 @@ export function processReply(
598598
 // Copy all the form fields with a prefix for this reference.
599599
 // These must come first in the form order because we assume that all the
600600
 // fields are available before this is referenced.
601-
 const prefix = formFieldPrefix + refId + '_';
601+
 // We include a special marker so that the Server can detect FormData entries
602+
 // that are values in referenced FormData objects.
603+
 const prefix = formFieldPrefix + '_' + refId + '_';
602604
 // $FlowFixMe[prop-missing]: FormData has forEach.
603605
 value.forEach((originalValue: string | File, originalKey: string) =>{
604606
// $FlowFixMe[incompatible-call]
‎packages/react-server/src/ReactFlightReplyBackingFormData.js‎
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
/**
2+
 * Copyright (c) Meta Platforms, Inc. and affiliates.
3+
 *
4+
 * This source code is licensed under the MIT license found in the
5+
 * LICENSE file in the root directory of this source tree.
6+
 *
7+
 * @flow
8+
 */
9+
10+
/**
11+
 * Backing FormData is a wrapper around FormData that allows iterating over the
12+
 * keys while allowing to evict values from the FormData without affecting the iteration.
13+
 * Native FormData.keys() will skip keys if entries with Blob are deleted e.g.
14+
 * ```js
15+
 * const formData = new FormData();
16+
 * formData.append('a', new Blob());
17+
 * formData.append('b', 2);
18+
 * const keys = formData.keys();
19+
 * keys.next().value; // 'a'
20+
 * formData.delete('a');
21+
 * keys.next().value; // undefined, but we expect 'b'
22+
 * ```
23+
 */
24+
exportopaquetypeBackingFormData={
25+
data: FormData,
26+
keyPointer: number,
27+
// Lazily initialized array of keys. We only need this at the moment
28+
// for referenced FormData.
29+
keys: null|Array<string>,
30+
};
31+
32+
export functionpeekBackingEntry(backingStore: BackingFormData): string|void{
33+
let keys =backingStore.keys;
34+
if(keys===null){
35+
 keys =backingStore.keys=Array.from(backingStore.data.keys());
36+
backingStore.keyPointer=0;
37+
}
38+
39+
returnkeys[backingStore.keyPointer];
40+
}
41+
42+
exportfunctionadvanceBackingEntryIterator(
43+
backingStore: BackingFormData,
44+
): void{
45+
backingStore.keyPointer++;
46+
}
47+
48+
exportfunctionconsumeBackingEntry(
49+
backingStore: BackingFormData,
50+
key: string,
51+
): void{
52+
backingStore.data.delete(key);
53+
backingStore.keyPointer++;
54+
}
55+
56+
exportfunctionappendBackingEntry(
57+
backingStore: BackingFormData,
58+
key: string,
59+
value: FormDataEntryValue,
60+
): void{
61+
backingStore.data.append(key,value);
62+
letkeys=backingStore.keys;
63+
if(keys===null){
64+
keys=backingStore.keys=Array.from(backingStore.data.keys());
65+
backingStore.keyPointer=0;
66+
}else{
67+
keys.push(key);
68+
}
69+
}
70+
71+
exportfunctionappendBackingFile(
72+
backingStore: BackingFormData,
73+
key: string,
74+
value: Blob,
75+
filename: string,
76+
): void{
77+
backingStore.data.append(key,value,filename);
78+
letkeys=backingStore.keys;
79+
if(keys===null){
80+
keys=backingStore.keys=Array.from(backingStore.data.keys());
81+
backingStore.keyPointer=0;
82+
}else{
83+
keys.push(key);
84+
}
85+
}
86+
87+
exportfunctiongetBackingEntry(
88+
backingStore: BackingFormData,
89+
key: string,
90+
): ?FormDataEntryValue{
91+
returnbackingStore.data.get(key);
92+
}
93+
94+
export functiongetAllBackingEntries(
95+
backingStore: BackingFormData,
96+
key: string,
97+
): Array<FormDataEntryValue>{
98+
returnbackingStore.data.getAll(key);
99+
}
100+
101+
exportfunctioncreateBackingFormData(formData: FormData): BackingFormData{
102+
return{
103+
data: formData,
104+
keyPointer: -1,
105+
keys: null,
106+
};
107+
}
0 commit comments
Comments
 (0)