Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [Flight] Warn once if `eval` is disabled in dev environment (#35661) · react/react@ed4bd54 · GitHub
Skip to content

Commit ed4bd54

Browse files
authored
[Flight] Warn once if eval is disabled in dev environment (#35661)
1 parent 64b4605 commit ed4bd54

26 files changed

Lines changed: 289 additions & 11 deletions
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'If this page was served with a `Content-Security-Policy` header, '+
22+
'make sure that `unsafe-eval` is included. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'This can happen if you started the Node.js process with --disallow-code-generation-from-strings, '+
22+
'or if `eval` was patched by other means. '+
23+
'React requires eval() in development mode for various debugging features '+
24+
'like reconstructing callstacks from a different environment.\n'+
25+
'React will never use eval() in production mode',
26+
);
27+
}
28+
}
29+
}else{
30+
// These errors should never make it into a build so we don't need to encode them in codes.json
31+
// eslint-disable-next-line react-internal/prod-error-codes
32+
thrownewError(
33+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
34+
);
35+
}
36+
}
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
/**
2+
* Copyright (c) Meta Platforms, Inc. and affiliates.
3+
*
4+
* This source code is licensed under the MIT license found in the
5+
* LICENSE file in the root directory of this source tree.
6+
*
7+
* @flow
8+
*/
9+
10+
lethasConfirmedEval=false;
11+
exportfunctioncheckEvalAvailabilityOnceDev(): void{
12+
if(__DEV__){
13+
if(!hasConfirmedEval){
14+
hasConfirmedEval=true;
15+
try{
16+
// eslint-disable-next-line no-eval
17+
(0,eval)('null');
18+
}catch{
19+
console.error(
20+
'eval() is not supported in this environment. '+
21+
'React requires eval() in development mode for various debugging features '+
22+
'like reconstructing callstacks from a different environment.\n'+
23+
'React will never use eval() in production mode',
24+
);
25+
}
26+
}
27+
}else{
28+
// These errors should never make it into a build so we don't need to encode them in codes.json
29+
// eslint-disable-next-line react-internal/prod-error-codes
30+
thrownewError(
31+
'checkEvalAvailabilityOnceDev should never be called in production mode. This is a bug in React.',
32+
);
33+
}
34+
}

‎packages/react-client/src/ReactFlightClient.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ import {
6161
bindToConsole,
6262
rendererVersion,
6363
rendererPackageName,
64+
checkEvalAvailabilityOnceDev,
6465
}from'./ReactFlightClientConfig';
6566

6667
import{
@@ -2768,6 +2769,14 @@ export function createResponse(
27682769
debugEndTime: void|number,// DEV-only
27692770
debugChannel: void|DebugChannel,// DEV-only
27702771
): WeakResponse{
2772+
if(__DEV__){
2773+
// We use eval to create fake function stacks which includes Component stacks.
2774+
// A warning would be noise if you used Flight without Components and don't encounter
2775+
// errors. We're warning eagerly so that you configure your environment accordingly
2776+
// before you encounter an error.
2777+
checkEvalAvailabilityOnceDev();
2778+
}
2779+
27712780
returngetWeakResponse(
27722781
// $FlowFixMe[invalid-constructor]: the shapes are exact here but Flow doesn't like constructors
27732782
newResponseInstance(

‎packages/react-client/src/ReactFlightReplyClient.js‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,10 @@ import getPrototypeOf from 'shared/getPrototypeOf';
3939

4040
constObjectPrototype=Object.prototype;
4141

42-
import{usedWithSSR}from'./ReactFlightClientConfig';
42+
import{
43+
usedWithSSR,
44+
checkEvalAvailabilityOnceDev,
45+
}from'./ReactFlightClientConfig';
4346

4447
typeReactJSONValue=
4548
|string
@@ -190,6 +193,14 @@ export function processReply(
190193
constwrittenObjects: WeakMap<Reference,string>=newWeakMap();
191194
letmodelRoot: null|ReactServerValue=root;
192195

196+
if(__DEV__){
197+
// We use eval to create fake function stacks which includes Component stacks.
198+
// A warning would be noise if you used Flight without Components and don't encounter
199+
// errors. We're warning eagerly so that you configure your environment accordingly
200+
// before you encounter an error.
201+
checkEvalAvailabilityOnceDev();
202+
}
203+
193204
functionserializeTypedArray(
194205
tag: string,
195206
typedArray: $ArrayBufferView,

‎packages/react-client/src/__tests__/ReactFlight-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3715,6 +3715,12 @@ describe('ReactFlight', () => {
37153715
'\n in b (at **)'+
37163716
'\n in a (at **)',
37173717
);
3718+
assertConsoleErrorDev([
3719+
'eval() is not supported in this environment. '+
3720+
'React requires eval() in development mode for various debugging features '+
3721+
'like reconstructing callstacks from a different environment.\n'+
3722+
'React will never use eval() in production mode',
3723+
]);
37183724
}else{
37193725
expect(receivedError.message).toEqual(
37203726
'An error occurred in the Server Components render. The specific message is omitted in production builds to avoid leaking sensitive details. A digest property is included on this error instance which may provide additional details about the nature of the error.',

‎packages/react-client/src/forks/ReactFlightClientConfig.custom.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,6 @@ export const bindToConsole = $$$config.bindToConsole;
5353

5454
exportconstrendererVersion=$$$config.rendererVersion;
5555
exportconstrendererPackageName=$$$config.rendererPackageName;
56+
57+
exportconstcheckEvalAvailabilityOnceDev=
58+
$$$config.checkEvalAvailabilityOnceDev;

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-esm.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-esm';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigBundlerESM';
1617
export*from'react-server-dom-esm/src/client/ReactFlightClientConfigTargetESMBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-parcel.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-parcel';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigBundlerParcel';
1617
export*from'react-server-dom-parcel/src/client/ReactFlightClientConfigTargetParcelBrowser';
1718
export*from'react-dom-bindings/src/shared/ReactFlightClientConfigDOM';

‎packages/react-client/src/forks/ReactFlightClientConfig.dom-browser-turbopack.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export const rendererPackageName = 'react-server-dom-turbopack';
1212

1313
export*from'react-client/src/ReactFlightClientStreamConfigWeb';
1414
export*from'react-client/src/ReactClientConsoleConfigBrowser';
15+
export*from'react-client/src/ReactClientDebugConfigBrowser';
1516
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopack';
1617
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigBundlerTurbopackBrowser';
1718
export*from'react-server-dom-turbopack/src/client/ReactFlightClientConfigTargetTurbopackBrowser';

0 commit comments

Comments
 (0)