Skip to content

Commit ee4699f

Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f

4 files changed

Lines changed: 34 additions & 7 deletions

File tree

‎packages/react-noop-renderer/src/createReactNoop.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});

‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[noop] Fail tests on unasserted recoverable errors (#35948) · react/react@ee4699f · GitHub
Skip to content
Commit ee4699f
Browse files
eps1loneps1lon
authored
[noop] Fail tests on unasserted recoverable errors (#35948)
1 parent 23b2d85 commit ee4699f
4 files changed
Lines changed: 34 additions & 7 deletions
File tree
‎packages/react-noop-renderer/src/createReactNoop.js‎
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,9 +1151,9 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
11511151
}
11521152
}
11531153

1154-
functiononRecoverableError(error){
1155-
// TODO: Turn this on once tests are fixed
1156-
// console.error(error);
1154+
functiononRecoverableError(error: mixed): void{
1155+
// eslint-disable-next-line react-internal/warning-args, react-internal/no-production-logging -- renderer is only used for testing.
1156+
console.error(error);
11571157
}
11581158
functiononDefaultTransitionIndicator(): void|(()=>void){}
11591159

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorHandling-test.internal.js‎
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,10 @@ describe('ReactIncrementalErrorHandling', () => {
287287
'commit',
288288
'commit',
289289
]);
290+
assertConsoleErrorDev([
291+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
292+
'\n in <stack>',
293+
]);
290294
expect(ReactNoop).toMatchRenderedOutput(
291295
<spanprop="Everything is fine."/>,
292296
);
@@ -339,6 +343,10 @@ describe('ReactIncrementalErrorHandling', () => {
339343
'commit',
340344
'commit',
341345
]);
346+
assertConsoleErrorDev([
347+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
348+
'\n in <stack>',
349+
]);
342350
// This should not include the offscreen content
343351
expect(ReactNoop).toMatchRenderedOutput(
344352
<>
@@ -1786,6 +1794,10 @@ describe('ReactIncrementalErrorHandling', () => {
17861794
});
17871795

17881796
// Should finish without throwing.
1797+
assertConsoleErrorDev([
1798+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1799+
'\n in <stack>',
1800+
]);
17891801
expect(root).toMatchRenderedOutput('Everything is fine.');
17901802
});
17911803

@@ -1832,6 +1844,10 @@ describe('ReactIncrementalErrorHandling', () => {
18321844
});
18331845
// Should render the final state without throwing the error.
18341846
assertLog(['Everything is fine.']);
1847+
assertConsoleErrorDev([
1848+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
1849+
'\n in <stack>',
1850+
]);
18351851
expect(root).toMatchRenderedOutput('Everything is fine.');
18361852
});
18371853

‎packages/react-reconciler/src/__tests__/ReactIncrementalErrorReplay-test.js‎
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
letReact;
1414
letReactNoop;
15+
letassertConsoleErrorDev;
1516
letwaitForAll;
1617
letwaitForThrow;
1718

@@ -22,6 +23,7 @@ describe('ReactIncrementalErrorReplay', () => {
2223
ReactNoop=require('react-noop-renderer');
2324

2425
constInternalTestUtils=require('internal-test-utils');
26+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
2527
waitForAll=InternalTestUtils.waitForAll;
2628
waitForThrow=InternalTestUtils.waitForThrow;
2729
});
@@ -50,5 +52,9 @@ describe('ReactIncrementalErrorReplay', () => {
5052
}
5153
ReactNoop.render(<App/>);
5254
awaitwaitForAll([]);
55+
assertConsoleErrorDev([
56+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
57+
'\n in <stack>',
58+
]);
5359
});
5460
});
‎packages/react-reconciler/src/__tests__/useMemoCache-test.js‎
Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ let React;
1212
letReactNoop;
1313
letScheduler;
1414
letact;
15+
letassertConsoleErrorDev;
1516
letassertLog;
1617
letuseMemo;
1718
letuseState;
@@ -26,8 +27,10 @@ describe('useMemoCache()', () => {
2627
React=require('react');
2728
ReactNoop=require('react-noop-renderer');
2829
Scheduler=require('scheduler');
29-
act=require('internal-test-utils').act;
30-
assertLog=require('internal-test-utils').assertLog;
30+
constInternalTestUtils=require('internal-test-utils');
31+
act=InternalTestUtils.act;
32+
assertConsoleErrorDev=InternalTestUtils.assertConsoleErrorDev;
33+
assertLog=InternalTestUtils.assertLog;
3134
useMemo=React.useMemo;
3235
useMemoCache=require('react/compiler-runtime').c;
3336
useState=React.useState;
@@ -256,8 +259,6 @@ describe('useMemoCache()', () => {
256259
return`${data.text} (n=${props.n})`;
257260
});
258261

259-
spyOnDev(console,'error');
260-
261262
constroot=ReactNoop.createRoot();
262263
awaitact(()=>{
263264
root.render(
@@ -274,6 +275,10 @@ describe('useMemoCache()', () => {
274275
// this triggers a throw.
275276
setN(1);
276277
});
278+
assertConsoleErrorDev([
279+
'Error: There was an error during concurrent rendering but React was able to recover by instead synchronously rendering the entire root.'+
280+
'\n in <stack>',
281+
]);
277282
expect(root).toMatchRenderedOutput('Count 0 (n=1)');
278283
expect(Text).toBeCalledTimes(2);
279284
expect(data).toBe(data0);
0 commit comments
Comments
 (0)