Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); [Fizz] Unify preamble only fields to save a field (#35068) · react/react@fa50caf · GitHub
Skip to content

Commit fa50caf

Browse files
authored
[Fizz] Unify preamble only fields to save a field (#35068)
Stacked on #35067. Same idea of saving a field on the SuspenseBoundary in the common case. The case where they can have a preamble is rare.
1 parent 1e986f5 commit fa50caf

1 file changed

Lines changed: 31 additions & 29 deletions

File tree

‎packages/react-server/src/ReactFizzServer.js‎

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,7 @@ type SuspenseBoundary = {
255255
fallbackAbortableTasks: Set<Task>,// used to cancel task on the fallback if the boundary completes or gets canceled.
256256
contentState: HoistableState,
257257
fallbackState: HoistableState,
258-
contentPreamble: null|Preamble,
259-
fallbackPreamble: null|Preamble,
258+
preamble: null|Preamble,
260259
tracked: null|{
261260
contentKeyPath: null|KeyNode,// used to track the path for replay nodes
262261
fallbackNode: null|ReplayNode,// used to track the fallback for replay nodes
@@ -275,7 +274,7 @@ type RenderTask = {
275274
ping: ()=>void,
276275
blockedBoundary: Root|SuspenseBoundary,
277276
blockedSegment: Segment,// the segment we'll write to
278-
blockedPreamble: null|Preamble,
277+
blockedPreamble: null|PreambleState,
279278
hoistableState: null|HoistableState,// Boundary state we'll mutate while rendering. This may not equal the state of the blockedBoundary
280279
abortSet: Set<Task>,// the abortable set that this task belongs to
281280
keyPath: Root|KeyNode,// the path of all parent keys currently rendering
@@ -398,7 +397,17 @@ export opaque type Request = {
398397
didWarnForKey?: null|WeakSet<ComponentStackNode>,
399398
};
400399

401-
typePreamble=PreambleState;
400+
typePreamble={
401+
content: PreambleState,
402+
fallback: PreambleState,
403+
};
404+
405+
functioncreatePreamble(): Preamble{
406+
return{
407+
content: createPreambleState(),
408+
fallback: createPreambleState(),
409+
};
410+
}
402411

403412
// This is a default heuristic for how to split up the HTML content into progressive
404413
// loading. Our goal is to be able to display additional new content about every 500ms.
@@ -466,7 +475,7 @@ function isEligibleForOutlining(
466475
// For boundaries that can possibly contribute to the preamble we don't want to outline
467476
// them regardless of their size since the fallbacks should only be emitted if we've
468477
// errored the boundary.
469-
boundary.contentPreamble===null
478+
boundary.preamble===null
470479
);
471480
}
472481

@@ -786,8 +795,7 @@ function createSuspenseBoundary(
786795
request: Request,
787796
row: null|SuspenseListRow,
788797
fallbackAbortableTasks: Set<Task>,
789-
contentPreamble: null | Preamble,
790-
fallbackPreamble: null | Preamble,
798+
preamble: null | Preamble,
791799
defer: boolean,
792800
): SuspenseBoundary {
793801
constboundary: SuspenseBoundary={
@@ -803,8 +811,7 @@ function createSuspenseBoundary(
803811
errorDigest: null,
804812
contentState: createHoistableState(),
805813
fallbackState: createHoistableState(),
806-
contentPreamble,
807-
fallbackPreamble,
814+
preamble,
808815
tracked: null,
809816
};
810817
if(__DEV__){
@@ -838,7 +845,7 @@ function createRenderTask(
838845
childIndex: number,
839846
blockedBoundary: Root|SuspenseBoundary,
840847
blockedSegment: Segment,
841-
blockedPreamble: null|Preamble,
848+
blockedPreamble: null|PreambleState,
842849
hoistableState: null|HoistableState,
843850
abortSet: Set<Task>,
844851
keyPath: Root | KeyNode,
@@ -1290,8 +1297,7 @@ function renderSuspenseBoundary(
12901297
request,
12911298
task.row,
12921299
fallbackAbortSet,
1293-
createPreambleState(),
1294-
createPreambleState(),
1300+
createPreamble(),
12951301
defer,
12961302
);
12971303
}else{
@@ -1300,7 +1306,6 @@ function renderSuspenseBoundary(
13001306
task.row,
13011307
fallbackAbortSet,
13021308
null,
1303-
null,
13041309
defer,
13051310
);
13061311
}
@@ -1365,7 +1370,8 @@ function renderSuspenseBoundary(
13651370
}
13661371

13671372
task.blockedSegment=boundarySegment;
1368-
task.blockedPreamble=newBoundary.fallbackPreamble;
1373+
task.blockedPreamble=
1374+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback;
13691375
task.keyPath=fallbackKeyPath;
13701376
task.formatContext=getSuspenseFallbackFormatContext(
13711377
request.resumableState,
@@ -1409,7 +1415,7 @@ function renderSuspenseBoundary(
14091415
-1,
14101416
newBoundary,
14111417
contentRootSegment,
1412-
newBoundary.contentPreamble,
1418+
newBoundary.preamble===null ? null : newBoundary.preamble.content,
14131419
newBoundary.contentState,
14141420
task.abortSet,
14151421
keyPath,
@@ -1440,7 +1446,8 @@ function renderSuspenseBoundary(
14401446
// context switching. We just need to temporarily switch which boundary and which segment
14411447
// we're writing to. If something suspends, it'll spawn new suspended task with that context.
14421448
task.blockedBoundary=newBoundary;
1443-
task.blockedPreamble=newBoundary.contentPreamble;
1449+
task.blockedPreamble=
1450+
newBoundary.preamble===null ? null : newBoundary.preamble.content;
14441451
task.hoistableState=newBoundary.contentState;
14451452
task.blockedSegment=contentRootSegment;
14461453
task.keyPath=keyPath;
@@ -1548,7 +1555,7 @@ function renderSuspenseBoundary(
15481555
-1,
15491556
parentBoundary,
15501557
boundarySegment,
1551-
newBoundary.fallbackPreamble,
1558+
newBoundary.preamble===null ? null : newBoundary.preamble.fallback,
15521559
newBoundary.fallbackState,
15531560
fallbackAbortSet,
15541561
fallbackKeyPath,
@@ -1602,8 +1609,7 @@ function replaySuspenseBoundary(
16021609
request,
16031610
task.row,
16041611
fallbackAbortSet,
1605-
createPreambleState(),
1606-
createPreambleState(),
1612+
createPreamble(),
16071613
defer,
16081614
);
16091615
}else{
@@ -1612,7 +1618,6 @@ function replaySuspenseBoundary(
16121618
task.row,
16131619
fallbackAbortSet,
16141620
null,
1615-
null,
16161621
defer,
16171622
);
16181623
}
@@ -4372,7 +4377,7 @@ function erroredTask(
43724377
if(
43734378
request.pendingRootTasks===0&&
43744379
request.trackedPostpones===null&&
4375-
boundary.contentPreamble!==null
4380+
boundary.preamble!==null
43764381
){
43774382
// The root is complete and this boundary may contribute part of the preamble.
43784383
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -4414,7 +4419,6 @@ function abortRemainingSuspenseBoundary(
44144419
null,
44154420
newSet(),
44164421
null,
4417-
null,
44184422
false,
44194423
);
44204424
resumedBoundary.parentFlushed=true;
@@ -4894,7 +4898,7 @@ function finishedTask(
48944898
if(
48954899
request.pendingRootTasks===0&&
48964900
request.trackedPostpones===null&&
4897-
boundary.contentPreamble!==null
4901+
boundary.preamble!==null
48984902
){
48994903
// The root is complete and this boundary may contribute part of the preamble.
49004904
// We eagerly attempt to prepare the preamble here because we expect most requests
@@ -5271,10 +5275,8 @@ function preparePreambleFromSegment(
52715275
);
52725276
}
52735277

5274-
constpreamble=boundary.contentPreamble;
5275-
constfallbackPreamble=boundary.fallbackPreamble;
5276-
5277-
if(preamble===null||fallbackPreamble===null){
5278+
constpreamble=boundary.preamble;
5279+
if(preamble===null){
52785280
// This boundary cannot have a preamble so it can't block the flushing of
52795281
// the preamble.
52805282
return false;
@@ -5286,7 +5288,7 @@ function preparePreambleFromSegment(
52865288
caseCOMPLETED: {
52875289
// This boundary is complete. It might have inner boundaries which are pending
52885290
// and able to provide a preamble so we have to check it's children
5289-
hoistPreambleState(request.renderState,preamble);
5291+
hoistPreambleState(request.renderState,preamble.content);
52905292
// We track this boundary's byteSize on the request since it will always flush with
52915293
// the request since it may contribute to the preamble
52925294
request.byteSize+=boundary.byteSize;
@@ -5315,7 +5317,7 @@ function preparePreambleFromSegment(
53155317
caseCLIENT_RENDERED: {
53165318
if(segment.status===COMPLETED){
53175319
// This boundary is errored so if it contains a preamble we should include it
5318-
hoistPreambleState(request.renderState,fallbackPreamble);
5320+
hoistPreambleState(request.renderState,preamble.fallback);
53195321
returnpreparePreambleFromSubtree(
53205322
request,
53215323
segment,

0 commit comments

Comments
 (0)