Bug: eslint-plugin-react-hooks has wrong d.ts after upgrade from 5 to 6/7

[krutoo]

React version:

Steps To Reproduce

1. Use module: nodenext in TypeScript config
2. create eslint.config.ts with using eslint-plugin-react-hooks
3. See TypeScript errors about default field in

Link to code example:

Not provided

The current behavior

Errors in TypeScript

The expected behavior

Suitable declaration files

[haines]

https://arethetypeswrong.github.io/?p=eslint-plugin-react-hooks%407.0.0

❗️Incorrect default export

The resolved types use export default where the JavaScript file appears to use module.exports =. This will cause TypeScript under the node16 module mode to think an extra .default property access is required, but that will likely fail at runtime. These types should use export = instead of export default.

[stevenvachon]

For now this works:

// @ts-expect-error -- https://github.com/facebook/react/issues/34801
(reactHooksPlugin as { configs: { flat: { recommended: unknown } } }).configs.flat.recommended

[karlhorky]

cc @poteto @eps1lon @michaelfaith the types do seem like a problem (also reported by another user in #34845), you can see it in a simpler example with "moduleResolution": "node16" and "type": "module" when using this CodeSandbox reproduction:

CodeSandbox: https://codesandbox.io/p/devbox/zx9zhd?file=%2Feslint.config.js

$ yarn tsc
yarn run v1.22.19
$ /project/workspace/node_modules/.bin/tsc
eslint.config.js:11:7 - error TS2559: Type 'typeof import("/project/workspace/node_modules/eslint-plugin-react-hooks/index")' has no properties in common with type 'Omit<Plugin, "configs">'.

11 "react-hooks": reactHooks,
 ~~~~~~~~~~~~~


Found 1 error in eslint.config.js:11

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Suggested solution

Looking at the emitted file eslint-plugin-react-hooks@7.0.0/index.d.ts, it appears to be using ESM syntax, even though the package is CommonJS:

node_modules/eslint-plugin-react-hooks/index.d.ts

/**
 * Copyright (c) Meta Platforms, Inc. and affiliates.
 *
 * This source code is licensed under the MIT license found in the
 * LICENSE file in the root directory of this source tree.
 */

export {default} from './cjs/eslint-plugin-react-hooks';

Switching the export line to use export = instead (as suggested on Are the types wrong?) appears to resolve the problem:

-export {default} from './cjs/eslint-plugin-react-hooks';
+import reactHooks from './cjs/eslint-plugin-react-hooks';
+export = reactHooks;

Since index.d.ts appears to be a generated file, I was thinking of doing a PR to change "module": "ES2015" to "module": "CommonJS" in packages/eslint-plugin-react-hooks/tsconfig.json to generate this index.d.ts, but it appears that this isn't compatible with "moduleResolution": "Bundler"... 🤔

Edit: found the index.d.ts file, here's a PR:

• Switch to export = to fix eslint-plugin-react-hooks types #34949