Add event plugins to addons

[petehunt]

I did this in the most API-constrained way possible. Will write docs.

[zpao]

Aw, we lost ABC order

[zpao]

Anything else need to be done here @petehunt?

[ryanseddon]

Just did a custom build with these changes and setup a demo but the onTouchTap event doesn't trigger in iOS but it does on desktop Chrome?

[sophiebits]

Try adding React.initializeTouchEvents(true) before any of your app code, if you don't have it already.

[ryanseddon]

No that doesn't seem to work either, see updated test case.

[tmcw]

The updated test case works for me in Mobile Safari on an iPhone 5S & in an emulator.

[jbrantly]

👍 I would love to see this merged

[zpao]

Nah. Let's hold off because supporting this is going to suck. We should figure something out for 1.0, so we can come back around to it then.

[slorber]

+1

[micky2be]

+1

[dzannotti]

+1

[sathify]

+1

[alancmclean]

+1

[zpao]

Please don't add any more "+1" comments. If you don't have anything constructive, don't comment at all.

[mhart]

@zpao is there a discussion happening around this somewhere? Your last comment was:

We should figure something out for 1.0, so we can come back around to it then.

[zpao]

No, not that I know of.

[mhart]

So what's the status of it do you think?

[mhart]

@zpao So this issue, along with #436 are both referenced from https://github.com/zilverline/react-tap-event-plugin – where it says "When Facebook solves #436 and #1170, this repo will disappear". And http://react-components.com/component/material-ui#react-tap-event-plugin where it says "This dependency is temporary and will go away once react v1.0 is released"

I believe that's why there's still interest in this issue/PR – really I think everyone's just interested in what the story is for tap events for React.

So is there anywhere better to follow the status of this in React, or is this PR (or #436) the best place?

[sophiebits]

Let's go with #436.

[mhart]

Cool, thanks @spicyj !

[c0b41]

+1

[anaibol]

+1