Uh oh!
There was an error while loading. Please reload this page.
using the wrong renderer's act() should warn - #15756
Merged
threepointone merged 6 commits intoMay 29, 2019
Merged
Conversation
…dates like it says. it uses a real object as the sigil (instead of just a boolean). specifically, it uses a renderer's flushPassiveEffects as the sigil. We also run tests for this separate from our main suite (which doesn't allow loading multiple renderers in a suite), but makes sure to run this in CI as well.
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: 401065f...c0dc398 react-dom
react-art
react-native-renderer
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
acdlite
reviewed
May 29, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
acdlite
approved these changes
May 29, 2019
threepointone
commented
May 29, 2019
ContributorAuthor
updated the PR to use an explicit export (from |
gaearon
reviewed
May 29, 2019
| if (__DEV__) { | ||
| if ( | ||
| ReactCurrentActingRendererSigil.current !== null && | ||
| // use the function flushPassiveEffects directly as the sigil |
| // so this comparison is expected here | ||
| ReactCurrentActingRendererSigil.current !== ReactActingRendererSigil | ||
| ) { | ||
| // it looks like we're using the wrong matching act(), so log a warning |
Collaborator
There was a problem hiding this comment.
This comment kinda repeats the warning?
| "It looks like you're using the wrong act() around your test interactions.\n" + | ||
| 'Be sure to use the matching version of act() corresponding to your renderer:\n\n' + | ||
| '// for react-dom:\n' + | ||
| "import {act} from 'react-test-utils';\n" + |
ContributorAuthor
There was a problem hiding this comment.
there's no such package either 🤦♂️
Merged
This was referenced Aug 17, 2019
This was referenced Mar 10, 2020
This was referenced Mar 18, 2020
mrizwanashiq pushed a commit
to mrizwanashiq/react
that referenced
this pull request
Jun 25, 2026
* warn when using the wrong renderer's act around another renderer's updates like it says. it uses a real object as the sigil (instead of just a boolean). specifically, it uses a renderer's flushPassiveEffects as the sigil. We also run tests for this separate from our main suite (which doesn't allow loading multiple renderers in a suite), but makes sure to run this in CI as well. * unneeded (and wrong) comment * run the dom fixture on CI * update the sigil only in __DEV__ * remove the obnoxious comment * use an explicit export for the sigil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
via #15319
(redid #15399, removed the changes that didn't even belong in it.)
So tl;dr this PR -
This solves 2 specific problems -
(Please see #15399 for the long spiel on the mechanics for this.)