add jsx-runtime and jsx-dev-runtime modules by lunaruan · Pull Request #18299 · react/react

lunaruan · 2020-03-13T01:49:28Z

This PR adds the jsx-runtime and jsx-dev-runtime modules for the JSX Babel Plugin. WWW still relies on jsx/jsxs/jsxDEV from the "react" module, so once we refactor the code to point to the runtime modules we will remove jsx/jsxs/jsxDEV from the "react" module.

codesandbox-ci · 2020-03-13T01:52:00Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ded98d8:

Sandbox	Source
quirky-tdd-dws4b	Configuration

sizebot · 2020-03-13T01:54:23Z

Details of bundled changes.

Comparing: 2666642...ded98d8

react

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react.development.js	-4.9%	-3.0%	108.97 KB	103.65 KB	26.03 KB	25.24 KB	UMD_DEV
react-jsx-runtime.profiling.min.js	n/a	n/a	0 B	943 B	0 B	592 B	NODE_PROFILING
react.production.min.js	-3.5%	-2.6%	12.66 KB	12.22 KB	4.87 KB	4.75 KB	UMD_PROD
JSXRuntime-dev.js	n/a	n/a	0 B	29.41 KB	0 B	8.64 KB	FB_WWW_DEV
react-jsx-dev-runtime.development.js	n/a	n/a	0 B	26.33 KB	0 B	8.08 KB	NODE_DEV
react-jsx-dev-runtime.production.min.js	n/a	n/a	0 B	433 B	0 B	313 B	NODE_PROD
react-jsx-dev-runtime.profiling.min.js	n/a	n/a	0 B	432 B	0 B	312 B	NODE_PROFILING
JSXDEVRuntime-dev.js	n/a	n/a	0 B	28.82 KB	0 B	8.46 KB	FB_WWW_DEV
JSXDEVRuntime-prod.js	n/a	n/a	0 B	510 B	0 B	343 B	FB_WWW_PROD
react-jsx-runtime.development.js	n/a	n/a	0 B	26.91 KB	0 B	8.26 KB	NODE_DEV
JSXDEVRuntime-profiling.js	n/a	n/a	0 B	510 B	0 B	343 B	FB_WWW_PROFILING
react-jsx-runtime.production.min.js	n/a	n/a	0 B	944 B	0 B	593 B	NODE_PROD
react.profiling.min.js	-2.7%	-1.6%	16.2 KB	15.76 KB	5.95 KB	5.85 KB	UMD_PROFILING
JSXRuntime-prod.js	n/a	n/a	0 B	1.54 KB	0 B	742 B	FB_WWW_PROD
react.development.js	-7.2%	-4.1%	70.39 KB	65.33 KB	18.27 KB	17.53 KB	NODE_DEV
JSXRuntime-profiling.js	n/a	n/a	0 B	1.54 KB	0 B	742 B	FB_WWW_PROFILING
react.production.min.js	-5.9%	-3.3%	7.73 KB	7.27 KB	2.97 KB	2.88 KB	NODE_PROD
React-dev.js	+17.6%	+13.0%	75.59 KB	88.91 KB	19.11 KB	21.59 KB	FB_WWW_DEV
React-prod.js	-0.5%	-1.3%	18.02 KB	17.92 KB	4.66 KB	4.6 KB	FB_WWW_PROD
React-profiling.js	-0.5%	-1.3%	18.02 KB	17.92 KB	4.66 KB	4.6 KB	FB_WWW_PROFILING

React: size: -3.5%, gzip: -2.6%

Size changes (experimental)

Generated by 🚫 dangerJS against ded98d8

sizebot · 2020-03-13T01:54:36Z

Details of bundled changes.

Comparing: 2666642...ded98d8

react

File	Filesize Diff	Gzip Diff	Prev Size	Current Size	Prev Gzip	Current Gzip	ENV
react.development.js	+0.1%	+0.1%	100.31 KB	100.45 KB	24.65 KB	24.66 KB	UMD_DEV
JSXRuntime-profiling.js	n/a	n/a	0 B	1.54 KB	0 B	742 B	FB_WWW_PROFILING
JSXDEVRuntime-dev.js	n/a	n/a	0 B	28.83 KB	0 B	8.46 KB	FB_WWW_DEV
JSXDEVRuntime-prod.js	n/a	n/a	0 B	510 B	0 B	343 B	FB_WWW_PROD
JSXDEVRuntime-profiling.js	n/a	n/a	0 B	510 B	0 B	343 B	FB_WWW_PROFILING
react-jsx-runtime.development.js	n/a	n/a	0 B	26.9 KB	0 B	8.25 KB	NODE_DEV
react-jsx-runtime.production.min.js	n/a	n/a	0 B	931 B	0 B	585 B	NODE_PROD
react-jsx-runtime.profiling.min.js	n/a	n/a	0 B	930 B	0 B	584 B	NODE_PROFILING
JSXRuntime-dev.js	n/a	n/a	0 B	29.41 KB	0 B	8.64 KB	FB_WWW_DEV
JSXRuntime-prod.js	n/a	n/a	0 B	1.54 KB	0 B	742 B	FB_WWW_PROD
react.development.js	+0.2%	+0.1%	62.14 KB	62.28 KB	16.92 KB	16.94 KB	NODE_DEV
React-dev.js	+17.5%	+12.7%	76.26 KB	89.58 KB	19.28 KB	21.73 KB	FB_WWW_DEV
React-prod.js	-0.5%	-1.0%	18.08 KB	17.98 KB	4.67 KB	4.62 KB	FB_WWW_PROD
react-jsx-dev-runtime.development.js	n/a	n/a	0 B	26.32 KB	0 B	8.08 KB	NODE_DEV
React-profiling.js	-0.5%	-1.0%	18.08 KB	17.98 KB	4.67 KB	4.62 KB	FB_WWW_PROFILING
react-jsx-dev-runtime.production.min.js	n/a	n/a	0 B	420 B	0 B	304 B	NODE_PROD
react-jsx-dev-runtime.profiling.min.js	n/a	n/a	0 B	419 B	0 B	304 B	NODE_PROFILING

Size changes (stable)

Generated by 🚫 dangerJS against ded98d8

gaearon · 2020-03-13T03:00:31Z

@@ -34,6 +35,7 @@ describe('ReactElement.jsx', () => {
 ReactFeatureFlags.warnAboutSpreadingKeyToJSX = true;


If this test wasn't marked as "internal", it would fail on bundles as it should — because we haven't exposed these entry points on npm. To do that, check out how files in npm/ folders in different packages work. ~~Also note "files" array in package.json of each package.~~ (Oops, you have that part — but still need npm entry points.)

gaearon

Need to add npm entry points.

gaearon · 2020-03-13T03:14:05Z

You'll also need to add them to bundles.js to actually build the bundles. See similar entry points (e.g. react-dom/server and its config) for expiration. Hit me up for any questions!

gaearon · 2020-03-13T12:07:47Z

Pls rebase :-) I think this should fail now.

gaearon

lg, pending CI, nits and a decision on UMD bundles.

Note that if we merge this now, the next release will go out with these entry points. Are we ready in terms of final naming, bundles, etc?

gaearon · 2020-03-13T23:29:54Z

 global.Symbol = undefined;

 React = require('react');
+ jsxRuntime = require('react/jsx-runtime');


Super nit: JSXRuntime in tests for capitalization consistency? I don't care tho

gaearon

Okay as we figured out, we still have an issue with duplication of bundle content.

What we need to do is to remove jsx from the React object completely, and to create separate entry points for both runtimes. Like src/jsx/JSXRuntime. There you can put the jsx() implementation with the minimal copy paste it needs (ReactElement) and an import of the current owner from React. Note you can’t just import it from parent folder. You need to get it from require(“react”) like all other packages do. Because otherwise we’ll get a copy of it in our bundle.

Then for FB bundle if we want to keep React.jsx working for a bit you could do this in the FB index file I think. Just re export from both React and Runtime.

gaearon · 2020-03-17T00:08:25Z

 "loose-envify": "^1.1.0",
 "object-assign": "^4.1.1"
 },
+ "peerDependencies": {


A package can't be its own peer. This isn't needed. If our scripts complain it's our scripts that should be fixed.

This PR adds the jsx-runtime and jsx-dev-runtime modules for the JSX Babel Plugin. WWW still relies on jsx/jsxs/jsxDEV from the "react" module, so once we refactor the code to point to the runtime modules we will remove jsx/jsxs/jsxDEV from the "react" module.

![snyk-top-banner](https://redirect.github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123) <h3>Snyk has created this PR to upgrade react-dom from 16.8.4 to 16.14.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **13 versions** ahead of your current version. - The recommended version was released on **4 years ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>react-dom</b></summary> <ul> <li> <b>16.14.0</b> - <a href="https://redirect.github.com/facebook/react/releases/tag/v16.14.0">2020-10-14</a></br><h3>React</h3> <ul> <li>Add support for the <a href="https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html" rel="nofollow">new JSX transform</a>. (<a href="https://redirect.github.com/lunaruan">@ lunaruan</a> in <a href="https://redirect.github.com/facebook/react/pull/18299" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/18299/hovercard">#18299</a>)</li> </ul> </li> <li> <b>16.13.1</b> - <a href="https://redirect.github.com/facebook/react/releases/tag/v16.13.1">2020-03-19</a></br><h3>React DOM</h3> <ul> <li>Fix bug in legacy mode Suspense where effect clean-up functions are not fired. This only affects users who use Suspense for data fetching in legacy mode, which is not technically supported. (<a href="https://redirect.github.com/acdlite">@ acdlite</a> in <a href="https://redirect.github.com/facebook/react/pull/18238" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/18238/hovercard">#18238</a>)</li> <li>Revert warning for cross-component updates that happen inside class render lifecycles (<code>componentWillReceiveProps</code>, <code>shouldComponentUpdate</code>, and so on). (<a href="https://redirect.github.com/gaearon">@ gaearon</a> in <a href="https://redirect.github.com/facebook/react/pull/18330" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/18330/hovercard">#18330</a>)</li> </ul> <h2>Artifacts</h2> <ul> <li>react: <a href="https://unpkg.com/react@16.13.1/umd/" rel="nofollow">https://unpkg.com/react@16.13.1/umd/</a></li> <li>react-art: <a href="https://unpkg.com/react-art@16.13.1/umd/" rel="nofollow">https://unpkg.com/react-art@16.13.1/umd/</a></li> <li>react-dom: <a href="https://unpkg.com/react-dom@16.13.1/umd/" rel="nofollow">https://unpkg.com/react-dom@16.13.1/umd/</a></li> <li>react-is: <a href="https://unpkg.com/react-is@16.13.1/umd/" rel="nofollow">https://unpkg.com/react-is@16.13.1/umd/</a></li> <li>react-test-renderer: <a href="https://unpkg.com/react-test-renderer@16.13.1/umd/" rel="nofollow">https://unpkg.com/react-test-renderer@16.13.1/umd/</a></li> <li>scheduler: <a href="https://unpkg.com/scheduler@0.19.1/umd/" rel="nofollow">https://unpkg.com/scheduler@0.19.1/umd/</a></li> </ul> </li> <li> <b>16.13.0</b> - <a href="https://redirect.github.com/facebook/react/releases/tag/v16.13.0">2020-02-26</a></br><h3>React</h3> <ul> <li>Warn when a string ref is used in a manner that's not amenable to a future codemod (<a href="https://redirect.github.com/lunaruan">@ lunaruan</a> in <a href="https://redirect.github.com/facebook/react/pull/17864" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17864/hovercard">#17864</a>)</li> <li>Deprecate <code>React.createFactory()</code> (<a href="https://redirect.github.com/trueadm">@ trueadm</a> in <a href="https://redirect.github.com/facebook/react/pull/17878" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17878/hovercard">#17878</a>)</li> </ul> <h3>React DOM</h3> <ul> <li>Warn when changes in <code>style</code> may cause an unexpected collision (<a href="https://redirect.github.com/sophiebits">@ sophiebits</a> in <a href="https://redirect.github.com/facebook/react/pull/14181" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/14181/hovercard">#14181</a>, <a href="https://redirect.github.com/facebook/react/pull/18002" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/18002/hovercard">#18002</a>)</li> <li>Warn when a function component is updated during another component's render phase (<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/acdlite/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/acdlite">@ acdlite</a> in <a href="https://redirect.github.com/facebook/react/pull/17099" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17099/hovercard">#17099</a>)</li> <li>Deprecate <code>unstable_createPortal</code> (<a href="https://redirect.github.com/trueadm">@ trueadm</a> in <a href="https://redirect.github.com/facebook/react/pull/17880" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17880/hovercard">#17880</a>)</li> <li>Fix <code>onMouseEnter</code> being fired on disabled buttons (<a href="https://redirect.github.com/AlfredoGJ">@ AlfredoGJ</a> in <a href="https://redirect.github.com/facebook/react/pull/17675" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17675/hovercard">#17675</a>)</li> <li>Call <code>shouldComponentUpdate</code> twice when developing in <code>StrictMode</code> (<a href="https://redirect.github.com/bvaughn">@ bvaughn</a> in <a href="https://redirect.github.com/facebook/react/pull/17942" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17942/hovercard">#17942</a>)</li> <li>Add <code>version</code> property to ReactDOM (<a href="https://redirect.github.com/ealush">@ ealush</a> in <a href="https://redirect.github.com/facebook/react/pull/15780" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/15780/hovercard">#15780</a>)</li> <li>Don't call <code>toString()</code> of <code>dangerouslySetInnerHTML</code> (<a href="https://redirect.github.com/sebmarkbage">@ sebmarkbage</a> in <a href="https://redirect.github.com/facebook/react/pull/17773" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17773/hovercard">#17773</a>)</li> <li>Show component stacks in more warnings (<a href="https://redirect.github.com/gaearon">@ gaearon</a> in <a href="https://redirect.github.com/facebook/react/pull/17922" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17922/hovercard">#17922</a>, <a href="https://redirect.github.com/facebook/react/pull/17586" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17586/hovercard">#17586</a>)</li> </ul> <h3>Concurrent Mode (Experimental)</h3> <ul> <li>Warn for problematic usages of <code>ReactDOM.createRoot()</code> (<a href="https://redirect.github.com/trueadm">@ trueadm</a> in <a href="https://redirect.github.com/facebook/react/pull/17937" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17937/hovercard">#17937</a>)</li> <li>Remove <code>ReactDOM.createRoot()</code> callback params and added warnings on usage (<a href="https://redirect.github.com/bvaughn">@ bvaughn</a> in <a href="https://redirect.github.com/facebook/react/pull/17916" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17916/hovercard">#17916</a>)</li> <li>Don't group Idle/Offscreen work with other work (<a href="https://redirect.github.com/sebmarkbage">@ sebmarkbage</a> in <a href="https://redirect.github.com/facebook/react/pull/17456" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17456/hovercard">#17456</a>)</li> <li>Adjust <code>SuspenseList</code> CPU bound heuristic (<a href="https://redirect.github.com/sebmarkbage">@ sebmarkbage</a> in <a href="https://redirect.github.com/facebook/react/pull/17455" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17455/hovercard">#17455</a>)</li> <li>Add missing event plugin priorities (<a href="https://redirect.github.com/trueadm">@ trueadm</a> in <a href="https://redirect.github.com/facebook/react/pull/17914" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17914/hovercard">#17914</a>)</li> <li>Fix <code>isPending</code> only being true when transitioning from inside an input event (<a href="https://redirect.github.com/acdlite">@ acdlite</a> in <a href="https://redirect.github.com/facebook/react/pull/17382" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17382/hovercard">#17382</a>)</li> <li>Fix <code>React.memo</code> components dropping updates when interrupted by a higher priority update (<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/acdlite/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/acdlite">@ acdlite</a> in <a href="https://redirect.github.com/facebook/react/pull/18091" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/18091/hovercard">#18091</a>)</li> <li>Don't warn when suspending at the wrong priority (<a href="https://redirect.github.com/gaearon">@ gaearon</a> in <a href="https://redirect.github.com/facebook/react/pull/17971" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17971/hovercard">#17971</a>)</li> <li>Fix a bug with rebasing updates (<a href="https://redirect.github.com/acdlite">@ acdlite</a> and <a href="https://redirect.github.com/sebmarkbage">@ sebmarkbage</a> in <a href="https://redirect.github.com/facebook/react/pull/17560" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17560/hovercard">#17560</a>, <a href="https://redirect.github.com/facebook/react/pull/17510" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17510/hovercard">#17510</a>, <a href="https://redirect.github.com/facebook/react/pull/17483" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17483/hovercard">#17483</a>, <a href="https://redirect.github.com/facebook/react/pull/17480" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17480/hovercard">#17480</a>)</li> </ul> <h2>Artifacts</h2> <ul> <li>react: <a href="https://unpkg.com/react@16.13.0/umd/" rel="nofollow">https://unpkg.com/react@16.13.0/umd/</a></li> <li>react-art: <a href="https://unpkg.com/react-art@16.13.0/umd/" rel="nofollow">https://unpkg.com/react-art@16.13.0/umd/</a></li> <li>react-dom: <a href="https://unpkg.com/react-dom@16.13.0/umd/" rel="nofollow">https://unpkg.com/react-dom@16.13.0/umd/</a></li> <li>react-is: <a href="https://unpkg.com/react-is@16.13.0/umd/" rel="nofollow">https://unpkg.com/react-is@16.13.0/umd/</a></li> <li>react-test-renderer: <a href="https://unpkg.com/react-test-renderer@16.13.0/umd/" rel="nofollow">https://unpkg.com/react-test-renderer@16.13.0/umd/</a></li> <li>scheduler: <a href="https://unpkg.com/scheduler@0.19.0/umd/" rel="nofollow">https://unpkg.com/scheduler@0.19.0/umd/</a></li> </ul> </li> <li> <b>16.12.0</b> - <a href="https://redirect.github.com/facebook/react/releases/tag/v16.12.0">2019-11-14</a></br><h3>React DOM</h3> <ul> <li>Fix passive effects (<code>useEffect</code>) not being fired in a multi-root app. (<a href="https://redirect.github.com/acdlite">@ acdlite</a> in <a href="https://redirect.github.com/facebook/react/pull/17347" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17347/hovercard">#17347</a>)</li> </ul> <h3>React Is</h3> <ul> <li>Fix <code>lazy</code> and <code>memo</code> types considered elements instead of components (<a href="https://redirect.github.com/bvaughn">@ bvaughn</a> in <a href="https://redirect.github.com/facebook/react/pull/17278" data-hovercard-type="pull_request" data-hovercard-url="/react/react/pull/17278/hovercard">#17278</a>)</li> </ul> <h2>Artifacts</h2> <p>• react: <a href="https://unpkg.com/react@16.12.0/umd/" rel="nofollow">https://unpkg.com/react@16.12.0/umd/</a><br> • react-art: <a href="https://unpkg.com/react-art@16.12.0/umd/" rel="nofollow">https://unpkg.com/react-art@16.12.0/umd/</a><br> • react-dom: <a href="https://unpkg.com/react-dom@16.12.0/umd/" rel="nofollow">https://unpkg.com/react-dom@16.12.0/umd/</a><br> • react-is: <a href="https://unpkg.com/react-is@16.12.0/umd/" rel="nofollow">https://unpkg.com/react-is@16.12.0/umd/</a><br> • react-test-renderer: <a href="https://unpkg.com/react-test-renderer@16.12.0/umd/" rel="nofollow">https://unpkg.com/react-test-renderer@16.12.0/umd/</a><br> • scheduler: <a href="https://unpkg.com/scheduler@0.18.0/umd/" rel="nofollow">https://unpkg.com/scheduler@0.18.0/umd/</a></p> </li> <li> <b>16.11.0</b> - 2019-10-22 </li> <li> <b>16.10.2</b> - 2019-10-03 </li> <li> <b>16.10.1</b> - 2019-09-28 </li> <li> <b>16.10.0</b> - 2019-09-27 </li> <li> <b>16.9.0</b> - 2019-08-08 </li> <li> <b>16.9.0-rc.0</b> - 2019-08-05 </li> <li> <b>16.9.0-alpha.0</b> - 2019-04-03 </li> <li> <b>16.8.6</b> - 2019-03-28 </li> <li> <b>16.8.5</b> - 2019-03-22 </li> <li> <b>16.8.4</b> - 2019-03-05 </li> </ul> from <a href="https://redirect.github.com/facebook/react/releases">react-dom GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI4NTdmYmVkYy1hZTE3LTQ3ZGYtODhkYy03MTcyMWYxNThjZTkiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6Ijg1N2ZiZWRjLWFlMTctNDdkZi04OGRjLTcxNzIxZjE1OGNlOSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/newkdr/project/12a8a5f5-3e19-438c-8280-eb8f4ee06d17?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/newkdr/project/12a8a5f5-3e19-438c-8280-eb8f4ee06d17/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/newkdr/project/12a8a5f5-3e19-438c-8280-eb8f4ee06d17/settings/integration?pkg=react-dom&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"react-dom","from":"16.8.4","to":"16.14.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"857fbedc-ae17-47df-88dc-71721f158ce9","prPublicId":"857fbedc-ae17-47df-88dc-71721f158ce9","packageManager":"npm","priorityScoreList":[],"projectPublicId":"12a8a5f5-3e19-438c-8280-eb8f4ee06d17","projectUrl":"https://app.snyk.io/org/newkdr/project/12a8a5f5-3e19-438c-8280-eb8f4ee06d17?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":13,"publishedDate":"2020-10-14T19:38:26.085Z"},"vulns":[]}'

This PR adds the jsx-runtime and jsx-dev-runtime modules for the JSX Babel Plugin. WWW still relies on jsx/jsxs/jsxDEV from the "react" module, so once we refactor the code to point to the runtime modules we will remove jsx/jsxs/jsxDEV from the "react" module.

lunaruan requested review from gaearon and sebmarkbage March 13, 2020 01:49

facebook-github-bot added React Core Team Opened by a member of the React Core Team CLA Signed labels Mar 13, 2020

gaearon reviewed Mar 13, 2020
View reviewed changes

gaearon mentioned this pull request Mar 13, 2020
Run ReactElementJSX-test against bundles #18301
Merged

gaearon requested changes Mar 13, 2020
View reviewed changes

lunaruan force-pushed the jsx-runtime branch 3 times, most recently from 88ea8d9 to 9565d1bCompare March 13, 2020 23:05

gaearon approved these changes Mar 13, 2020
View reviewed changes

Comment threadscripts/rollup/bundles.js Outdated
Comment threadscripts/rollup/bundles.js Outdated
Comment threadscripts/rollup/bundles.js Outdated
Comment threadscripts/rollup/forks.js Outdated
Comment threadscripts/rollup/forks.js Outdated

gaearon reviewed Mar 13, 2020
View reviewed changes

Comment threadpackages/react/npm/jsx-runtime.js Outdated

lunaruan force-pushed the jsx-runtime branch 2 times, most recently from ef6fb14 to a5aa16eCompare March 13, 2020 23:25

gaearon reviewed Mar 13, 2020
View reviewed changes

gaearon requested changes Mar 14, 2020
View reviewed changes

Comment threadscripts/rollup/forks.js Outdated

lunaruan force-pushed the jsx-runtime branch from a5aa16e to 4dbbbcbCompare March 17, 2020 00:04

gaearon reviewed Mar 17, 2020
View reviewed changes

lunaruan force-pushed the jsx-runtime branch 3 times, most recently from 249203e to 2b03ad8Compare March 17, 2020 00:59

sebmarkbage approved these changes Mar 17, 2020
View reviewed changes

gaearon requested changes Mar 17, 2020
View reviewed changes

Comment threadpackages/react/src/React.js Outdated

lunaruan force-pushed the jsx-runtime branch from 2b03ad8 to c076560Compare March 17, 2020 17:29

gaearon reviewed Mar 17, 2020
View reviewed changes

Comment threadpackages/react/index.experimental.js Outdated

github-anis-snoussi mentioned this pull request Oct 5, 2024
[Snyk] Upgrade react from 16.13.1 to 16.14.0 github-anis-snoussi/CutCat#362
Open

This was referenced Oct 5, 2024
[Snyk] Upgrade react-dom from 16.0.0 to 16.14.0 CASABECI/stellarexplorer#1
Open
[Snyk] Upgrade react from 16.0.0 to 16.14.0 CASABECI/stellarexplorer#2
Open

github-anis-snoussi mentioned this pull request Oct 6, 2024
[Snyk] Upgrade react from 16.13.1 to 16.14.0 github-anis-snoussi/CutCat#367
Open

This was referenced Oct 12, 2024
[Snyk] Upgrade react from 16.4.1 to 16.14.0 shinehs/cli#3
Open
[Snyk] Upgrade react-dom from 16.4.1 to 16.14.0 shinehs/cli#4
Open

This was referenced Oct 15, 2024
[Snyk] Upgrade react from 15.4.2 to 15.7.0 iamsuganthi/jest#2
Open
[Snyk] Upgrade react-dom from 15.4.2 to 15.7.0 iamsuganthi/jest#3
Open

This was referenced Oct 26, 2024
[Snyk] Upgrade react from 16.13.0 to 16.14.0 rahul-jethva/cloudflare-worker-cra#3
Open
[Snyk] Upgrade react-dom from 16.13.0 to 16.14.0 rahul-jethva/cloudflare-worker-cra#4
Open

This was referenced Oct 27, 2024
[Snyk] Upgrade react from 16.12.0 to 16.14.0 Vishesh7797/personal-website#2
Open
[Snyk] Upgrade react-dom from 16.12.0 to 16.14.0 Vishesh7797/personal-website#3
Open

topolik mentioned this pull request Oct 30, 2024
[Snyk] Upgrade react from 16.12.0 to 16.14.0 topolik/liferay-portal#862
Closed

github-anis-snoussi mentioned this pull request Oct 31, 2024
[Snyk] Upgrade react from 16.13.1 to 16.14.0 github-anis-snoussi/CutCat#382
Open

storskegg mentioned this pull request Oct 31, 2024
[Snyk] Upgrade react-dom from 16.13.1 to 16.14.0 storskegg/gotutf#41
Open

This was referenced Nov 2, 2024
[Snyk] Upgrade react from 16.13.1 to 16.14.0 dulki/Firefox#4
Open
[Snyk] Upgrade react-dom from 16.13.1 to 16.14.0 dulki/Firefox#5
Open

This was referenced Nov 4, 2024
[Snyk] Upgrade react from 16.8.4 to 16.14.0 Vishesh7797/full-stack-with-react-and-spring-boot#3
Open
[Snyk] Upgrade react-dom from 16.8.4 to 16.14.0 Vishesh7797/full-stack-with-react-and-spring-boot#4
Open

github-anis-snoussi mentioned this pull request Nov 7, 2024
[Snyk] Upgrade react from 16.13.1 to 16.14.0 github-anis-snoussi/CutCat#387
Open

coderabbitaiBot mentioned this pull request Mar 18, 2026
feat: add fetch cache tags support and refactor for cognitive complexity rari-build/rari#154
Merged

		@@ -34,6 +35,7 @@ describe('ReactElement.jsx', () => {
		ReactFeatureFlags.warnAboutSpreadingKeyToJSX = true;

Uh oh!

Conversation

lunaruan commented Mar 13, 2020

Uh oh!

codesandbox-ciBot commented Mar 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sizebot commented Mar 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

react

Size changes (experimental)

Uh oh!

sizebot commented Mar 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

react

Size changes (stable)

Uh oh!

gaearonMar 13, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaearonMar 13, 2020

Choose a reason for hiding this comment

Uh oh!

gaearon left a comment

Choose a reason for hiding this comment

Uh oh!

gaearon commented Mar 13, 2020

Uh oh!

gaearon commented Mar 13, 2020

Uh oh!

gaearon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gaearonMar 13, 2020

Choose a reason for hiding this comment

Uh oh!

gaearon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gaearonMar 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codesandbox-ciBot commented Mar 13, 2020•
edited
Loading

sizebot commented Mar 13, 2020•
edited
Loading

sizebot commented Mar 13, 2020•
edited
Loading

gaearonMar 13, 2020•
edited
Loading

gaearon left a comment •
edited
Loading