Uh oh!
There was an error while loading. Please reload this page.
Disable enablePostpone flag in experimental - #31042
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebmarkbage
marked this pull request as draft
December 29, 2024 00:56
sebmarkbageforce-pushed
the
disablepostpone
branch
4 times, most recently
from
May 13, 2025 14:42
2220993 to
dd4b91fComparesebmarkbage
marked this pull request as ready for review
May 13, 2025 14:49
sebmarkbageforce-pushed
the
disablepostpone
branch
from
November 3, 2025 14:34
dd4b91f to
a90020dComparesebmarkbageforce-pushed
the
disablepostpone
branch
from
November 5, 2025 04:19
2404d77 to
0c92ae0CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage.
The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and
use()because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there'suse()and not just throwing a Promise. This might also affect the Catch proposal.The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the
React.postpone()API for creating the holes.