Skip to content

[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193

Merged
eps1lon merged 12 commits into
react:mainfrom
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged

[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom
The-Fiery-Fire:riskymh/upd-bun-react-dom

Conversation

@RiskyMH

@RiskyMHRiskyMH commented Aug 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

fixesremix-run/react-router#12568, fixes#33612

The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.

How did you test this change?

used the built output and verified the functions are now present in the bun bundles

@meta-cla

meta-claBot commented Aug 13, 2025

Copy link
Copy Markdown

Hi @RiskyMH!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@react-sizebot

react-sizebot commented Aug 13, 2025•
edited
Loading

Copy link
Copy Markdown

Comparing: 1d68bce...f4fe9ed

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed

eps1lon
eps1lon reviewed Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js Outdated
RiskyMH
RiskyMH commented Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js Outdated
@eps1loneps1lon mentioned this pull request Aug 21, 2025
Merged
@RiskyMH

RiskyMH commented Sep 12, 2025

Copy link
Copy Markdown
ContributorAuthor

https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210

i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).

@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH requested a review from eps1lonOctober 7, 2025 19:44
@eps1lon

eps1lon commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).

These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.

eps1lon
eps1lon reviewed Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js Outdated
@janhesters

janhesters commented Oct 23, 2025

Copy link
Copy Markdown

Thanks @RiskyMH for creating this!

@eps1loneps1lon changed the title Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon approved these changes Oct 27, 2025
View reviewed changes

@eps1loneps1lon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eps1lon
eps1lon merged commit b4455a6 into react:mainOct 27, 2025
240 of 241 checks passed
@RiskyMH
RiskyMH deleted the riskymh/upd-bun-react-dom branch October 28, 2025 00:26
github-actionsBot pushed a commit to rickhanlonii/react that referenced this pull request Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot pushed a commit to rickhanlonii/react that referenced this pull request Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot mentioned this pull request Oct 28, 2025
Merged
@rubennorterubennorte mentioned this pull request Jun 5, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[react-dom] Include all Node.js APIs in Bun entrypoint for `/server` by RiskyMH · Pull Request #34193 · react/react · GitHub
Skip to content
[react-dom] Include all Node.js APIs in Bun entrypoint for /server - #34193
Merged
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Oct 27, 2025
Merged
[react-dom] Include all Node.js APIs in Bun entrypoint for /server#34193
eps1lon merged 12 commits into
react:mainfrom 
The-Fiery-Fire:riskymh/upd-bun-react-dom
Conversation
@RiskyMH
@RiskyMHRiskyMH
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
fixesremix-run/react-router#12568, fixes#33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles
@meta-cla
meta-claBot
commented
Aug 13, 2025

Copy link


Copy Markdown

Hi @RiskyMH!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
@react-sizebot
react-sizebot
commented
Aug 13, 2025•

edited

Loading

Copy link


Copy Markdown

Comparing: 1d68bce...f4fe9ed
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.68 kB6.68 kB=1.83 kB1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=605.42 kB605.42 kB=107.21 kB107.21 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.69 kB6.69 kB=1.83 kB1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=664.39 kB664.39 kB=117.09 kB117.09 kB
facebook-www/ReactDOM-prod.classic.js=688.26 kB688.26 kB=121.13 kB121.13 kB
facebook-www/ReactDOM-prod.modern.js=678.69 kB678.69 kB=119.48 kB119.48 kB
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-experimental/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable/react-dom/server.bun.js+21.11%0.56 kB0.68 kB+5.28%0.25 kB0.26 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.62 kB278.56 kB+3.82%47.14 kB48.94 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js+7.29%259.70 kB278.64 kB+3.82%47.17 kB48.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js+6.85%276.52 kB295.45 kB+3.64%49.57 kB51.37 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.32 kB383.34 kB+2.47%70.80 kB72.55 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js+5.22%364.39 kB383.41 kB+2.46%70.83 kB72.58 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js+4.94%385.15 kB404.17 kB+2.39%73.76 kB75.52 kB

Generated by 🚫 dangerJS against f4fe9ed
eps1lon
eps1lon
reviewed
Aug 13, 2025
View reviewed changes
Comment threadscripts/rollup/bundles.js
Outdated

RiskyMH
RiskyMH
commented
Aug 13, 2025
View reviewed changes
Comment threadpackages/react-dom/src/server/react-dom-server.bun.js
Outdated

@eps1loneps1lon
mentioned this pull request
Aug 21, 2025
 Merged

@RiskyMH
RiskyMH
commented
Sep 12, 2025

Copy link


Copy Markdown

ContributorAuthor
https://github.com/facebook/react/blob/8a8e9a7edf16fabc1335c9910bddfef66737ee4e/scripts/error-codes/codes.json#L209-L210
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
@RiskyMH
Merge remote-tracking branch 'upstream/main' into riskymh/upd-bun-rea…
768c88f
…ct-dom
# Conflicts:
#	packages/react-dom/npm/server.bun.js
@RiskyMH
merge
0a91645
@RiskyMH
RiskyMH
requested a review
from eps1lonOctober 7, 2025 19:44
@eps1lon
eps1lon
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases).
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds.
eps1lon
eps1lon
reviewed
Oct 13, 2025
View reviewed changes
Comment threadpackages/react-dom/npm/server.bun.js
Outdated

@janhesters
janhesters
commented
Oct 23, 2025

Copy link


Copy Markdown

Thanks @RiskyMH for creating this!
@eps1loneps1lon
changed the title
Update bun's condition of react-dom/server to have latest normal node functions[react-dom] Include all Node.js APIs in Bun entrypoint for /serverOct 27, 2025
eps1lon
eps1lon
approved these changes
Oct 27, 2025
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@eps1lon
eps1lon
merged commit b4455a6
into
react:mainOct 27, 2025

240 of 241 checks passed

@RiskyMH
RiskyMH
deleted the

riskymh/upd-bun-react-dom

branch
October 28, 2025 00:26
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
12a01bd
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
github-actionsBot
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Oct 28, 2025
@rickhanlonii
[react-dom] Include all Node.js APIs in Bun entrypoint for/server(r…
dfe8551
…eact#34193)
DiffTrain build for [b4455a6](react@b4455a6)
@nextjs-botnextjs-bot
mentioned this pull request
Oct 28, 2025
 Merged

@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


4 participants

@RiskyMH@react-sizebot@eps1lon@janhesters