Uh oh!
There was an error while loading. Please reload this page.
Conversation
This was referenced Oct 2, 2025
josephsavona
approved these changes
Oct 2, 2025
josephsavona
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the thorough debugging on this. It's incredibly frustrating that we were following ESLint's docs, and this worked in 9.20 or so, and seems to break in more recent minors of ESLint. The new setup here is more tedious, but from your/our investigation seems to be the only reasonable compromise. Other plugins (eslint-plugin-react for example) also define separate sets of configs for legacy and flat mode too.
poteto
marked this pull request as ready for review
October 2, 2025 21:37
hernan-yadiel
commented
Oct 2, 2025
Hi! I know working with ESLint is messier than it should be. Quick naming idea: |
Comparing: 056a586...846e132 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto added a commit
that referenced
this pull request
Oct 2, 2025
Adds back the compiler rules to the recommended preset, intended for the next release. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34675). * #34703 * #34700 * #34699 * __->__ #34675
poteto added a commit
that referenced
this pull request
Oct 2, 2025
Updates the eslint fixture lockfiles. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34699). * #34703 * #34700 * __->__ #34699 * #34675
poteto
commented
Oct 2, 2025
CollaboratorAuthor
@hernan-yadiel the
|
Previously, the `recommended` config used the legacy ESLint format (plugins as an array of strings). This causes errors when used with ESLint v9's `defineConfig()` helper. This was following [eslint's own docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs): > With this approach, both configuration systems recognize "recommended". The old config system uses the recommended key while the current config system uses the flat/recommended key. The defineConfig() helper first looks at the recommended key, and if that is not in the correct format, it looks for the flat/recommended key. This allows you an upgrade path if you’d later like to rename flat/recommended to recommended when you no longer need to support the old config system. However, [`isLegacyConfig()`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L73-L81) (also see [`eslintrcKeys`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L24-L35)) function doesn't check for the `plugins` key, so our config was incorrectly treated as flat config despite being in legacy format. This PR fixes the issue, along with a few other fixes combined: 1. Convert `recommended` to flat config format 2. Separate basic rules (exhaustive-deps, rules-of-hooks) from compiler rules 3. Add `recommended-latest-legacy` config for non-flat config users who want all recommended rules (including compiler rules) 4. Adding more types for the exported config Our shipped presets in 6.x.x will essentially be: - `recommended-legacy`: legacy (non-flat), with basic rules only - `recommended-latest-legacy`: legacy (non-flat), all rules (basic + compiler) - `flat/recommended`: flat, basic rules only (now the same as recommended, but to avoid making a breaking change we'll just keep it around in 6.x.x) - `recommended-latest`: flat, all rules (basic + compiler) - `recommended`: flat, basic rules only In the next breaking release 7.x.x, we will collapse down the presets into three: - `recommended-legacy`: all recommended rules - `recommended`: all recommended rules - `recommended-experimental`: all recommended rules + new bleeding edge experimental rules Closes#34679
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Updates the eslint fixture lockfiles. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34699). * #34703 * #34700 * __->__ #34699 * #34675 DiffTrain build for [056a586](056a586)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Updates the eslint fixture lockfiles. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34699). * #34703 * #34700 * __->__ #34699 * #34675 DiffTrain build for [056a586](056a586)
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Previously, the `recommended` config used the legacy ESLint format (plugins as an array of strings). This causes errors when used with ESLint v9's `defineConfig()` helper. This was following [eslint's own docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs): > With this approach, both configuration systems recognize "recommended". The old config system uses the recommended key while the current config system uses the flat/recommended key. The defineConfig() helper first looks at the recommended key, and if that is not in the correct format, it looks for the flat/recommended key. This allows you an upgrade path if you’d later like to rename flat/recommended to recommended when you no longer need to support the old config system. However, [`isLegacyConfig()`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L73-L81) (also see [`eslintrcKeys`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L24-L35)) function doesn't check for the `plugins` key, so our config was incorrectly treated as flat config despite being in legacy format. This PR fixes the issue, along with a few other fixes combined: 1. Convert `recommended` to flat config format 2. Separate basic rules (exhaustive-deps, rules-of-hooks) from compiler rules 3. Add `recommended-latest-legacy` config for non-flat config users who want all recommended rules (including compiler rules) 4. Adding more types for the exported config Our shipped presets in 6.x.x will essentially be: - `recommended-legacy`: legacy (non-flat), with basic rules only - `recommended-latest-legacy`: legacy (non-flat), all rules (basic + compiler) - `flat/recommended`: flat, basic rules only (now the same as recommended, but to avoid making a breaking change we'll just keep it around in 6.x.x) - `recommended-latest`: flat, all rules (basic + compiler) - `recommended`: flat, basic rules only In the next breaking release 7.x.x, we will collapse down the presets into three: - `recommended-legacy`: all recommended rules - `recommended`: all recommended rules - `recommended-experimental`: all recommended rules + new bleeding edge experimental rules Closes#34679 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34700). * #34703 * __->__ #34700 DiffTrain build for [26b177b](26b177b)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
Previously, the `recommended` config used the legacy ESLint format (plugins as an array of strings). This causes errors when used with ESLint v9's `defineConfig()` helper. This was following [eslint's own docs](https://eslint.org/docs/latest/extend/plugins#backwards-compatibility-for-legacy-configs): > With this approach, both configuration systems recognize "recommended". The old config system uses the recommended key while the current config system uses the flat/recommended key. The defineConfig() helper first looks at the recommended key, and if that is not in the correct format, it looks for the flat/recommended key. This allows you an upgrade path if you’d later like to rename flat/recommended to recommended when you no longer need to support the old config system. However, [`isLegacyConfig()`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L73-L81) (also see [`eslintrcKeys`](https://github.com/eslint/rewrite/blob/main/packages/config-helpers/src/define-config.js#L24-L35)) function doesn't check for the `plugins` key, so our config was incorrectly treated as flat config despite being in legacy format. This PR fixes the issue, along with a few other fixes combined: 1. Convert `recommended` to flat config format 2. Separate basic rules (exhaustive-deps, rules-of-hooks) from compiler rules 3. Add `recommended-latest-legacy` config for non-flat config users who want all recommended rules (including compiler rules) 4. Adding more types for the exported config Our shipped presets in 6.x.x will essentially be: - `recommended-legacy`: legacy (non-flat), with basic rules only - `recommended-latest-legacy`: legacy (non-flat), all rules (basic + compiler) - `flat/recommended`: flat, basic rules only (now the same as recommended, but to avoid making a breaking change we'll just keep it around in 6.x.x) - `recommended-latest`: flat, all rules (basic + compiler) - `recommended`: flat, basic rules only In the next breaking release 7.x.x, we will collapse down the presets into three: - `recommended-legacy`: all recommended rules - `recommended`: all recommended rules - `recommended-experimental`: all recommended rules + new bleeding edge experimental rules Closes#34679 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34700). * #34703 * __->__ #34700 DiffTrain build for [26b177b](26b177b)
poteto added a commit
that referenced
this pull request
Oct 2, 2025
This rule was a leftover from a while ago and doesn't actually lint anything useful. Specifically, you get a lint error if you try to opt out a component that isn't already bailing out. If there's a bailout the compiler already safely skips over it, so adding `'use no memo'` there is unnecessary. Fixes#31407 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703). * __->__ #34703 * #34700
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
This rule was a leftover from a while ago and doesn't actually lint anything useful. Specifically, you get a lint error if you try to opt out a component that isn't already bailing out. If there's a bailout the compiler already safely skips over it, so adding `'use no memo'` there is unnecessary. Fixes#31407 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703). * __->__ #34703 * #34700 DiffTrain build for [19f65ff](19f65ff)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 2, 2025
This rule was a leftover from a while ago and doesn't actually lint anything useful. Specifically, you get a lint error if you try to opt out a component that isn't already bailing out. If there's a bailout the compiler already safely skips over it, so adding `'use no memo'` there is unnecessary. Fixes#31407 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703). * __->__ #34703 * #34700 DiffTrain build for [19f65ff](19f65ff)
This was referenced Oct 3, 2025
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 5, 2025
This rule was a leftover from a while ago and doesn't actually lint anything useful. Specifically, you get a lint error if you try to opt out a component that isn't already bailing out. If there's a bailout the compiler already safely skips over it, so adding `'use no memo'` there is unnecessary. Fixesreact#31407 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703). * __->__ react#34703 * react#34700 DiffTrain build for [19f65ff](react@19f65ff)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Oct 5, 2025
This rule was a leftover from a while ago and doesn't actually lint anything useful. Specifically, you get a lint error if you try to opt out a component that isn't already bailing out. If there's a bailout the compiler already safely skips over it, so adding `'use no memo'` there is unnecessary. Fixesreact#31407 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/34703). * __->__ react#34703 * react#34700 DiffTrain build for [19f65ff](react@19f65ff)
736-c41-2c1-e464fc974 added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^5.2.0` → `^6.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/5.2.0/6.1.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v6.1.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#611) [Compare Source](react/react@8618113...a2329c1) **Note:** 6.1.0 accidentally allowed use of `recommended` without flat config, causing errors when used with ESLint v9's `defineConfig()` helper. This has been fixed in 6.1.1. - Fix `recommended` config for flat config compatibility. The `recommended` config has been converted to flat config format. Non-flat config users should use `recommended-legacy` instead. ([@​poteto](https://github.com/poteto) in [#​34700](react/react#34700)) - Add `recommended-latest` and `recommended-latest-legacy` configs that include React Compiler rules. ([@​poteto](https://github.com/poteto) in [#​34675](react/react#34675)) - Remove unused `NoUnusedOptOutDirectives` rule. ([@​poteto](https://github.com/poteto) in [#​34703](react/react#34703)) - Remove `hermes-parser` and dependency. ([@​poteto](https://github.com/poteto) in [#​34719](react/react#34719)) - Remove `@babel/plugin-proposal-private-methods` dependency. ([@​ArnaudBarre](https://github.com/ArnaudBarre) and [@​josephsavona](https://github.com/josephsavona) in [#​34715](react/react#34715)) - Update for Zod v3/v4 compatibility. ([@​kolian](https://github.com/kolvian) and [@​josephsavona](https://github.com/josephsavona) in [#​34717](react/react#34717)) ### [`v6.1.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#610) [Compare Source](react/react@fea92d8...8618113) **Note:** Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes. - **Breaking:** Require Node.js 18 or newer. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32458](react/react#32458)) - **Breaking:** Flat config is now the default `recommended` preset. Legacy config moved to `recommended-legacy`. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32457](react/react#32457)) - **New Violations:** Disallow calling `use` within try/catch blocks. ([@​poteto](https://github.com/poteto) in [#​34040](react/react#34040)) - **New Violations:** Disallow calling `useEffectEvent` functions in arbitrary closures. ([@​jbrown215](https://github.com/jbrown215) in [#​33544](react/react#33544)) - Handle `React.useEffect` in addition to `useEffect` in rules-of-hooks. ([@​Ayc0](https://github.com/Ayc0) in [#​34076](react/react#34076)) - Added `react-hooks` settings config option that to accept `additionalEffectHooks` that are used across exhaustive-deps and rules-of-hooks rules. ([@​jbrown215](https://github.com/jbrown215)) in [#​34497](react/react#34497) ### [`v6.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#600) [Compare Source](react/react@3607f48...fea92d8) Accidentally released. See 6.1.0 for the actual changes. </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!241 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: shrewd-laidback palace <shrewd-laidback-palace-736-c41-2c1-e464fc974@swiss-armed-forces-open-source.ch>
736-c41-2c1-e464fc974 added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
chore(deps): update eslint-plugin-react-hooks (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^5.2.0` → `^6.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/5.2.0/6.1.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v6.1.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#611) [Compare Source](react/react@8618113...a2329c1) **Note:** 6.1.0 accidentally allowed use of `recommended` without flat config, causing errors when used with ESLint v9's `defineConfig()` helper. This has been fixed in 6.1.1. - Fix `recommended` config for flat config compatibility. The `recommended` config has been converted to flat config format. Non-flat config users should use `recommended-legacy` instead. ([@​poteto](https://github.com/poteto) in [#​34700](react/react#34700)) - Add `recommended-latest` and `recommended-latest-legacy` configs that include React Compiler rules. ([@​poteto](https://github.com/poteto) in [#​34675](react/react#34675)) - Remove unused `NoUnusedOptOutDirectives` rule. ([@​poteto](https://github.com/poteto) in [#​34703](react/react#34703)) - Remove `hermes-parser` and dependency. ([@​poteto](https://github.com/poteto) in [#​34719](react/react#34719)) - Remove `@babel/plugin-proposal-private-methods` dependency. ([@​ArnaudBarre](https://github.com/ArnaudBarre) and [@​josephsavona](https://github.com/josephsavona) in [#​34715](react/react#34715)) - Update for Zod v3/v4 compatibility. ([@​kolian](https://github.com/kolvian) and [@​josephsavona](https://github.com/josephsavona) in [#​34717](react/react#34717)) ### [`v6.1.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#610) [Compare Source](react/react@fea92d8...8618113) **Note:** Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes. - **Breaking:** Require Node.js 18 or newer. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32458](react/react#32458)) - **Breaking:** Flat config is now the default `recommended` preset. Legacy config moved to `recommended-legacy`. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32457](react/react#32457)) - **New Violations:** Disallow calling `use` within try/catch blocks. ([@​poteto](https://github.com/poteto) in [#​34040](react/react#34040)) - **New Violations:** Disallow calling `useEffectEvent` functions in arbitrary closures. ([@​jbrown215](https://github.com/jbrown215) in [#​33544](react/react#33544)) - Handle `React.useEffect` in addition to `useEffect` in rules-of-hooks. ([@​Ayc0](https://github.com/Ayc0) in [#​34076](react/react#34076)) - Added `react-hooks` settings config option that to accept `additionalEffectHooks` that are used across exhaustive-deps and rules-of-hooks rules. ([@​jbrown215](https://github.com/jbrown215)) in [#​34497](react/react#34497) ### [`v6.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#600) [Compare Source](react/react@3607f48...fea92d8) Accidentally released. See 6.1.0 for the actual changes. </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!241 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
recommendedconfig used the legacy ESLint format (plugins as an array of strings). This causes errors when used with ESLint v9'sdefineConfig()helper. This was following eslint's own docs:However,
isLegacyConfig()(also seeeslintrcKeys) function doesn't check for thepluginskey, so our config was incorrectly treated as flat config despite being in legacy format.This PR fixes the issue, along with a few other fixes combined:
recommendedto flat config formatrecommended-latest-legacyconfig for non-flat config users who want all recommended rules (including compiler rules)Our shipped presets in 6.x.x will essentially be:
recommended-legacy: legacy (non-flat), with basic rules onlyrecommended-latest-legacy: legacy (non-flat), all rules (basic + compiler)flat/recommended: flat, basic rules only (now the same as recommended, but to avoid making a breaking change we'll just keep it around in 6.x.x)recommended-latest: flat, all rules (basic + compiler)recommended: flat, basic rules onlyIn the next breaking release 7.x.x, we will collapse down the presets into three:
recommended-legacy: all recommended rulesrecommended: all recommended rulesrecommended-experimental: all recommended rules + new bleeding edge experimental rulesCloses#34679
Stack created with Sapling. Best reviewed with ReviewStack.
recommendedconfig for flat config compatibility #34700