Uh oh!
There was an error while loading. Please reload this page.
[compiler] Update for Zod v3/v4 compatibility - #34717
Merged
Merged
Conversation
josephsavona
commented
Oct 3, 2025
ContributorAuthor
Note: this is a redo of #34710 w fixes |
josephsavonaforce-pushed
the
pr34717
branch
2 times, most recently
from
October 3, 2025 16:44
45c2375 to
69fbdeaComparez.function(args, return) to be compatible across Zod v3 and v4,z.function(args, return) to be compatible across Zod v3 and v4,Comparing: 71753ac...8335312 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
approved these changes
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod).
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod). Co-authored-by: kolvian <eliot@pontarelli.com> DiffTrain build for [d6eb735](d6eb735)
github-actionsBot
pushed a commit
that referenced
this pull request
Oct 3, 2025
Partial redo of #34710. The changes there tried to use `z.function(args, return)` to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just use `z.any()` where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod). Co-authored-by: kolvian <eliot@pontarelli.com> DiffTrain build for [d6eb735](d6eb735)
736-c41-2c1-e464fc974 added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^5.2.0` → `^6.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/5.2.0/6.1.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v6.1.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#611) [Compare Source](react/react@8618113...a2329c1) **Note:** 6.1.0 accidentally allowed use of `recommended` without flat config, causing errors when used with ESLint v9's `defineConfig()` helper. This has been fixed in 6.1.1. - Fix `recommended` config for flat config compatibility. The `recommended` config has been converted to flat config format. Non-flat config users should use `recommended-legacy` instead. ([@​poteto](https://github.com/poteto) in [#​34700](react/react#34700)) - Add `recommended-latest` and `recommended-latest-legacy` configs that include React Compiler rules. ([@​poteto](https://github.com/poteto) in [#​34675](react/react#34675)) - Remove unused `NoUnusedOptOutDirectives` rule. ([@​poteto](https://github.com/poteto) in [#​34703](react/react#34703)) - Remove `hermes-parser` and dependency. ([@​poteto](https://github.com/poteto) in [#​34719](react/react#34719)) - Remove `@babel/plugin-proposal-private-methods` dependency. ([@​ArnaudBarre](https://github.com/ArnaudBarre) and [@​josephsavona](https://github.com/josephsavona) in [#​34715](react/react#34715)) - Update for Zod v3/v4 compatibility. ([@​kolian](https://github.com/kolvian) and [@​josephsavona](https://github.com/josephsavona) in [#​34717](react/react#34717)) ### [`v6.1.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#610) [Compare Source](react/react@fea92d8...8618113) **Note:** Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes. - **Breaking:** Require Node.js 18 or newer. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32458](react/react#32458)) - **Breaking:** Flat config is now the default `recommended` preset. Legacy config moved to `recommended-legacy`. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32457](react/react#32457)) - **New Violations:** Disallow calling `use` within try/catch blocks. ([@​poteto](https://github.com/poteto) in [#​34040](react/react#34040)) - **New Violations:** Disallow calling `useEffectEvent` functions in arbitrary closures. ([@​jbrown215](https://github.com/jbrown215) in [#​33544](react/react#33544)) - Handle `React.useEffect` in addition to `useEffect` in rules-of-hooks. ([@​Ayc0](https://github.com/Ayc0) in [#​34076](react/react#34076)) - Added `react-hooks` settings config option that to accept `additionalEffectHooks` that are used across exhaustive-deps and rules-of-hooks rules. ([@​jbrown215](https://github.com/jbrown215)) in [#​34497](react/react#34497) ### [`v6.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#600) [Compare Source](react/react@3607f48...fea92d8) Accidentally released. See 6.1.0 for the actual changes. </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!241 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: shrewd-laidback palace <shrewd-laidback-palace-736-c41-2c1-e464fc974@swiss-armed-forces-open-source.ch>
736-c41-2c1-e464fc974 added a commit
to Swiss-Armed-Forces/Loom
that referenced
this pull request
Jan 14, 2026
chore(deps): update eslint-plugin-react-hooks (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [eslint-plugin-react-hooks](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks)) | devDependencies | major | [`^5.2.0` → `^6.0.0`](https://renovatebot.com/diffs/npm/eslint-plugin-react-hooks/5.2.0/6.1.1) | [](https://securityscorecards.dev/viewer/?uri=github.com/facebook/react) | --- ### Release Notes <details> <summary>facebook/react (eslint-plugin-react-hooks)</summary> ### [`v6.1.1`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#611) [Compare Source](react/react@8618113...a2329c1) **Note:** 6.1.0 accidentally allowed use of `recommended` without flat config, causing errors when used with ESLint v9's `defineConfig()` helper. This has been fixed in 6.1.1. - Fix `recommended` config for flat config compatibility. The `recommended` config has been converted to flat config format. Non-flat config users should use `recommended-legacy` instead. ([@​poteto](https://github.com/poteto) in [#​34700](react/react#34700)) - Add `recommended-latest` and `recommended-latest-legacy` configs that include React Compiler rules. ([@​poteto](https://github.com/poteto) in [#​34675](react/react#34675)) - Remove unused `NoUnusedOptOutDirectives` rule. ([@​poteto](https://github.com/poteto) in [#​34703](react/react#34703)) - Remove `hermes-parser` and dependency. ([@​poteto](https://github.com/poteto) in [#​34719](react/react#34719)) - Remove `@babel/plugin-proposal-private-methods` dependency. ([@​ArnaudBarre](https://github.com/ArnaudBarre) and [@​josephsavona](https://github.com/josephsavona) in [#​34715](react/react#34715)) - Update for Zod v3/v4 compatibility. ([@​kolian](https://github.com/kolvian) and [@​josephsavona](https://github.com/josephsavona) in [#​34717](react/react#34717)) ### [`v6.1.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#610) [Compare Source](react/react@fea92d8...8618113) **Note:** Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes. - **Breaking:** Require Node.js 18 or newer. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32458](react/react#32458)) - **Breaking:** Flat config is now the default `recommended` preset. Legacy config moved to `recommended-legacy`. ([@​michaelfaith](https://github.com/michaelfaith) in [#​32457](react/react#32457)) - **New Violations:** Disallow calling `use` within try/catch blocks. ([@​poteto](https://github.com/poteto) in [#​34040](react/react#34040)) - **New Violations:** Disallow calling `useEffectEvent` functions in arbitrary closures. ([@​jbrown215](https://github.com/jbrown215) in [#​33544](react/react#33544)) - Handle `React.useEffect` in addition to `useEffect` in rules-of-hooks. ([@​Ayc0](https://github.com/Ayc0) in [#​34076](react/react#34076)) - Added `react-hooks` settings config option that to accept `additionalEffectHooks` that are used across exhaustive-deps and rules-of-hooks rules. ([@​jbrown215](https://github.com/jbrown215)) in [#​34497](react/react#34497) ### [`v6.0.0`](https://github.com/facebook/react/blob/HEAD/packages/eslint-plugin-react-hooks/CHANGELOG.md#600) [Compare Source](react/react@3607f48...fea92d8) Accidentally released. See 6.1.0 for the actual changes. </details> --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi42OS4yIiwidXBkYXRlZEluVmVyIjoiNDIuNjkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGUiXX0=--> See merge request swiss-armed-forces/cyber-command/cea/loom!241 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial redo of #34710. The changes there tried to use
z.function(args, return)to be compatible across Zod v3 and v4, but Zod 4's function API has completely changed. Instead, I've updated to just usez.any()where we expect a function, and manually validate that it's a function before we call the value. We already have validation of the return type (also using Zod).