Uh oh!
There was an error while loading. Please reload this page.
[Fizz] Push a stalled use() to the ownerStack/debugTask - #35226
Merged
Conversation
eps1lonforce-pushed
the
sebbie/fizz-thenable-abort
branch
4 times, most recently
from
November 29, 2025 15:57
b2a0edf to
7c6ae2eCompareeps1lon
marked this pull request as ready for review
November 29, 2025 16:04
eps1lonforce-pushed
the
sebbie/fizz-thenable-abort
branch
3 times, most recently
from
December 2, 2025 17:20
c364caf to
b617d13Compareeps1lon
marked this pull request as draft
December 4, 2025 06:56
eps1lonforce-pushed
the
sebbie/fizz-thenable-abort
branch
5 times, most recently
from
December 4, 2025 10:05
22689b0 to
3c7b53fCompareeps1lon
marked this pull request as ready for review
December 4, 2025 10:09
…chance to process the ping
would be too disruptive
eps1lonforce-pushed
the
sebbie/fizz-thenable-abort
branch
from
January 12, 2026 20:41
3c7b53f to
cbfb89eComparegnoff
reviewed
Jan 13, 2026
Comment on lines
+2814
to
+2821
| if ( | ||
| request.status === ABORTING && | ||
| // If we already started rendering the Lazy Componentn in an aborting state | ||
| // and reach this point, the lazy was already resolved. | ||
| // We don't bail here again since this is most likely a discarded rerender | ||
| // to get the stack where we suspended in dev. | ||
| (!__DEV__ || !previouslyAbortingDEV) | ||
| ) { |
Collaborator
There was a problem hiding this comment.
I think we should be more explicit about when we are in a stalled retry render rather than inferring too much. I wonder if multiple aborts could lead to this getting through here in dev when it wouldn't otherwise. You could make a new dev only status for the task that is checked instead
eps1lonforce-pushed
the
sebbie/fizz-thenable-abort
branch
from
January 14, 2026 10:21
6c79426 to
27f2043Comparegnoff
approved these changes
Jan 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
lubieowoce added a commit
to lubieowoce/react
that referenced
this pull request
Jan 19, 2026
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Jan 22, 2026
DiffTrain build for [41b3e9a](react@41b3e9a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #33634 but for
useand promise-as-a-child.An alternative to re-rendering would've been to eagerly collect
use()calls but we knowError()is slow in v8.The danger with lazily collecting
use()is that the Thenable may be resolved when we abort.In those cases we remove instrumentation on the last thenable to ensure we suspend again. To ensure Thenable subclasses can't observe the corrupted state, we noop
.then.The shown stack relies on sourcemaps with
ignoreList. Otherwise it'll point into React internals. From the dispatcher we wouldn't know how many stacks we have to cut without a circular dependency to theReact.usefunction.