Uh oh!
There was an error while loading. Please reload this page.
Improve cyclic thenable detection in ReactFlightReplyServer - #35369
Conversation
Hi @cvan20191! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
react-sizebot
commented
Dec 17, 2025
Comparing: 88ee1f5...50c5c98 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Uh oh!
There was an error while loading. Please reload this page.
) ## Summary This PR improves cyclic thenable detection in `ReactFlightReplyServer.js`. Fixesreact#35368. The previous fix only detected direct self-references (`inspectedValue === chunk`) and relied on the `cycleProtection` counter to eventually bail out of longer cycles. This change keeps the existing MAX_THENABLE_CYCLE_DEPTH ($1000$) `cycleProtection` cap as a hard guardrail and adds a visited set so that we can detect self-cycles and multi-node cycles as soon as any `ReactPromise` is revisited and while still bounding the amount of work we do for deep acyclic chains via `cycleProtection`. ## How did you test this change? - Ran the existing test suite for the server renderer: ```bash yarn test react-server yarn test --prod react-server yarn flow dom-node yarn linc ``` --------- Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de> DiffTrain build for [b731fe2](react@b731fe2)
) ## Summary This PR improves cyclic thenable detection in `ReactFlightReplyServer.js`. Fixesreact#35368. The previous fix only detected direct self-references (`inspectedValue === chunk`) and relied on the `cycleProtection` counter to eventually bail out of longer cycles. This change keeps the existing MAX_THENABLE_CYCLE_DEPTH ($1000$) `cycleProtection` cap as a hard guardrail and adds a visited set so that we can detect self-cycles and multi-node cycles as soon as any `ReactPromise` is revisited and while still bounding the amount of work we do for deep acyclic chains via `cycleProtection`. ## How did you test this change? - Ran the existing test suite for the server renderer: ```bash yarn test react-server yarn test --prod react-server yarn flow dom-node yarn linc ``` --------- Co-authored-by: Hendrik Liebau <mail@hendrik-liebau.de> DiffTrain build for [b731fe2](react@b731fe2)
Summary
This PR improves cyclic thenable detection in$1000$ )
ReactFlightReplyServer.js. Fixes#35368.The previous fix only detected direct self-references (
inspectedValue === chunk) and relied on thecycleProtectioncounter to eventually bail out of longer cycles. This change keeps the existing MAX_THENABLE_CYCLE_DEPTH (cycleProtectioncap as a hard guardrail and adds a visited set so that we can detect self-cycles and multi-node cycles as soon as anyReactPromiseis revisited and while still bounding the amount of work we do for deep acyclic chains viacycleProtection.How did you test this change?
Ran the existing test suite for the server renderer: