Uh oh!
There was an error while loading. Please reload this page.
Support onGestureEnter/Exit/Share/Update events - #35556
Merged
Merged
Conversation
Comparing: 195fd22...d3e4329 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This is like the onEnter/Exit/Share/Update events but for gestures. It allows manually controlling the animation using the passed timeline.
This was referenced Jan 19, 2026
acdlite
reviewed
Jan 20, 2026
| } | ||
| for (let i = 0; i < pendingEvents.length; i++) { | ||
| const viewTransitionEvent = pendingEvents[i]; | ||
| viewTransitionEvent(pendingTypes); |
Collaborator
There was a problem hiding this comment.
This calls user code. Does it need to be wrapped in error handling? Didn't see where else that might be happening.
ContributorAuthor
There was a problem hiding this comment.
I think these are similar to onRecoverableError. I don't think they're handled properly in the existing one in flushSpawnedWork is right neither.
The way these phases flush is that they keep mutable state so that they can pick up and flush remaining phases if one is missed. So if this errors, then it errors the view transition which then flushes the remaining work which flushes the previous work but it doesn't flush this again so it probably misses anything after this. That means that bugs in React code might not be properly handled.
However, to ensure that other callbacks are handled, these should probably be wrapped in try/catch for each callback so that they're independently handled. Same thing for onRecoverableError.
There's also a question of what the default priority and execution context should be for these.
acdlite
approved these changes
Jan 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
sebmarkbage added a commit
that referenced
this pull request
Jan 20, 2026
Follow up to #35337. During a gesture, we always cancel the original animation and create a new one that we control. That's the one we need to add to the set that needs to be cancelled. Otherwise future gestures hang. An unfortunate consequence is that any custom ones that you start e.g. with #35556 or through other means aren't automatically cleaned up (in fact there's not even a clean up callback yet). This can lead these to freeze the whole UI afterwards. It would be really good to get this fixed in browsers instead so we can revert #35337.
sebmarkbage added a commit
that referenced
this pull request
Jan 20, 2026
…ts (#35564) Stacked on #35556 and #35559. Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any `Animation` started manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too. This lets you return a clean up function from all the events on `<ViewTransition>`.
github-actionsBot
pushed a commit
that referenced
this pull request
Jan 20, 2026
…ts (#35564) Stacked on #35556 and #35559. Given that we don't automatically clean up all view transition animations since #35337 and browsers are buggy, it's important that you clean up any `Animation` started manually from the events. However, there was no clean up function for when the View Transition is forced to stop. This also makes it harder to clean up custom timers etc too. This lets you return a clean up function from all the events on `<ViewTransition>`. DiffTrain build for [c55ffb5](c55ffb5)
sebmarkbage
commented
Jan 20, 2026
ContributorAuthor
cc @eps1lon for DefinitelyTyped |
sebmarkbage pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 20, 2026
[diff react/react@41b3e9a6...d2908752](react/react@41b3e9a...d290875) <details> <summary>React upstream changes</summary> - react/react#35567 - react/react#35566 - react/react#35565 - react/react#35564 - react/react#35559 - react/react#35556 </details>
m-kawafuji pushed a commit
to m-kawafuji/next.js
that referenced
this pull request
Aug 8, 2026
…#88774) [diff react/react@41b3e9a6...d2908752](react/react@41b3e9a...d290875) <details> <summary>React upstream changes</summary> - react/react#35567 - react/react#35566 - react/react#35565 - react/react#35564 - react/react#35559 - react/react#35556 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is like the onEnter/Exit/Share/Update events but for gestures. It allows manually controlling the animation using the passed timeline.