Update CSS shorthand property list - #35636

Merged
eps1lon merged 2 commits into
react:mainfrom
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged

Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom
kidonng:update-CSSShorthandProperty

Conversation

@kidonng

@kidonngkidonng commented Jan 26, 2026

Copy link
Copy Markdown
Contributor

Summary

This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.

This pull request updates the list, obtained via following code (a browser environment is required to load the test file):

<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>

Other considerations:

  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above

How did you test this change?

I modified existing test:

diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +

And checked the test still pass:

$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.

fayad-abbasi

This comment was marked as resolved.

Sign in to view

fayad-abbasi

This comment was marked as resolved.

Sign in to view

eps1lon
eps1lon approved these changes Mar 17, 2026
View reviewed changes

@eps1loneps1lon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@react-sizebot

react-sizebot commented Mar 17, 2026

Copy link
Copy Markdown

Comparing: 12ba7d8...74a99d6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6

@eps1lon
eps1lon merged commit 3f0b9e6 into react:mainMar 17, 2026
236 checks passed
github-actionsBot pushed a commit that referenced this pull request Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot pushed a commit that referenced this pull request Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot mentioned this pull request Mar 17, 2026
Merged
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot pushed a commit to code/lib-react that referenced this pull request Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte mentioned this pull request Jun 5, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes
+1 more reviewer
@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Update CSS shorthand property list - #35636
Merged
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Mar 17, 2026
Merged
Update CSS shorthand property list#35636
eps1lon merged 2 commits into
react:mainfrom 
kidonng:update-CSSShorthandProperty
Conversation
@kidonng
@kidonngkidonng
commented
Jan 26, 2026

Copy link


Copy Markdown

Contributor
Summary
This list was created in #14181 on Nov 10, 2018. CSS has changed a lot since then.
This pull request updates the list, obtained via following code (a browser environment is required to load the test file):
<textarea></textarea><script>functionok(){}</script><scriptsrc="https://cdn.jsdelivr.net/gh/mozilla-firefox/firefox@58f365ba0eb5761a182f1925e4654cc75212b8ac/layout/style/test/property_database.js"></script><script>constcamelCase=(string)=>string.replace(/-(.)/g,(_,char)=>char.toUpperCase());constresult=Object.fromEntries(Object.entries(gCSSProperties).filter(([name,value])=>!name.startsWith("-")&&"subproperties"invalue,).map(([name,value])=>[camelCase(name),value.subproperties.map(camelCase).sort((a,b)=>(a>b ? 1 : -1)),]).sort(([a],[b])=>(a>b ? 1 : -1)),);document.querySelector("textarea").value=JSON.stringify(result,null,2);</script>
Other considerations:
  • Bundle size: unchanged, since this is only used in the development build
  • Compatibility: unchanged, same as above
How did you test this change?
I modified existing test:
diff --git a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js
index c03107e467..6ee01ec7fd 100644
--- a/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js+++ b/packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js@@ -30,14 +30,14 @@ describe('ReactDOMShorthandCSSPropertyCollision', () => {
const container = document.createElement('div');
const root = ReactDOMClient.createRoot(container);
await act(() => {
- root.render(<div style={{font: 'foo', fontStyle: 'bar'}} />);+ root.render(<div style={{inset: 42, top: 37}} />);
});
await act(() => {
- root.render(<div style={{font: 'foo'}} />);+ root.render(<div style={{inset: 42}} />);
});
assertConsoleErrorDev([
- 'Removing a style property during rerender (fontStyle) ' +- 'when a conflicting property is set (font) can lead to styling ' ++ 'Removing a style property during rerender (top) ' ++ 'when a conflicting property is set (inset) can lead to styling ' +
"bugs. To avoid this, don't mix shorthand and non-shorthand " +
'properties for the same value; instead, replace the shorthand ' +
'with separate values.' +
And checked the test still pass:
$ yarn test ReactDOMShorthandCSSPropertyCollisionyarn run v1.22.22
$ node ./scripts/jest/jest-cli.js ReactDOMShorthandCSSPropertyCollision
$ NODE_ENV=development RELEASE_CHANNEL=experimental compactConsole=false node ./scripts/jest/jest.js --config ./scripts/jest/config.source.js ReactDOMShorthandCSSPropertyCollisionRunning tests for default (experimental)... PASS packages/react-dom/src/__tests__/ReactDOMShorthandCSSPropertyCollision-test.js ReactDOMShorthandCSSPropertyCollision ✓ should warn for conflicting CSS shorthand updates (248 ms)Test Suites: 1 passed, 1 totalTests: 1 passed, 1 totalSnapshots: 0 totalTime: 0.773 s, estimated 1 sRan all test suites matching /ReactDOMShorthandCSSPropertyCollision/i.Done in 1.53s.
fayad-abbasi

This comment was marked as resolved.

Sign in to view
fayad-abbasi

This comment was marked as resolved.

Sign in to view
eps1lon
eps1lon
approved these changes
Mar 17, 2026
View reviewed changes
@eps1loneps1lon
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@react-sizebot
react-sizebot
commented
Mar 17, 2026

Copy link


Copy Markdown

Comparing: 12ba7d8...74a99d6
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
oss-stable/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js=612.78 kB612.78 kB=108.29 kB108.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js=6.84 kB6.84 kB=1.88 kB1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js=678.71 kB678.71 kB=119.25 kB119.25 kB
facebook-www/ReactDOM-prod.classic.js=697.76 kB697.76 kB=122.60 kB122.60 kB
facebook-www/ReactDOM-prod.modern.js=688.08 kB688.08 kB=120.98 kB120.98 kB
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Name+/-BaseCurrent+/- gzipBase gzipCurrent gzip
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js+0.26%1,155.61 kB1,158.63 kB+0.35%191.68 kB192.36 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js+0.26%1,165.61 kB1,168.64 kB+0.35%194.80 kB195.48 kB
oss-stable/react-dom/cjs/react-dom-client.development.js+0.26%1,165.74 kB1,168.76 kB+0.35%194.83 kB195.51 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js+0.26%1,172.10 kB1,175.13 kB+0.35%194.54 kB195.22 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.22 kB1,185.25 kB+0.35%197.67 kB198.36 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js+0.26%1,182.35 kB1,185.38 kB+0.35%197.70 kB198.39 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js+0.24%1,256.11 kB1,259.14 kB+0.33%209.07 kB209.75 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%212.69 kB213.37 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js+0.24%1,272.65 kB1,275.68 kB+0.32%211.93 kB212.61 kB
facebook-www/ReactDOM-dev.modern.js+0.24%1,276.90 kB1,279.93 kB+0.33%211.58 kB212.27 kB
facebook-www/ReactDOM-dev.classic.js+0.24%1,286.11 kB1,289.14 kB+0.32%213.40 kB214.08 kB
facebook-www/ReactDOMTesting-dev.modern.js+0.23%1,293.44 kB1,296.47 kB+0.32%215.33 kB216.02 kB
facebook-www/ReactDOMTesting-dev.classic.js+0.23%1,302.65 kB1,305.68 kB+0.32%217.17 kB217.86 kB

Generated by 🚫 dangerJS against 74a99d6
@eps1lon
eps1lon
merged commit 3f0b9e6
into
react:mainMar 17, 2026

236 checks passed

github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
de67fe9
DiffTrain build for [3f0b9e6](3f0b9e6)
github-actionsBot
pushed a commit
that referenced
this pull request
Mar 17, 2026
@eps1lon
Update CSS shorthand property list (#35636)
83ac1fb
DiffTrain build for [3f0b9e6](3f0b9e6)
@nextjs-botnextjs-bot
mentioned this pull request
Mar 17, 2026
 Merged

github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
1524aea
DiffTrain build for [3f0b9e6](react@3f0b9e6)
github-actionsBot
pushed a commit
to code/lib-react
that referenced
this pull request
Mar 21, 2026
@pull
Update CSS shorthand property list (react#35636)
6c8569f
DiffTrain build for [3f0b9e6](react@3f0b9e6)
@rubennorterubennorte
mentioned this pull request
Jun 5, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@eps1loneps1loneps1lon approved these changes

+1 more reviewer

@fayad-abbasifayad-abbasifayad-abbasi left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CLA Signed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kidonng@react-sizebot@eps1lon@fayad-abbasi